From: checkpatch@dpdk.org
To: test-report@dpdk.org
Cc: Andrzej Ostruszka <amo@semihalf.com>
Subject: [dpdk-test-report] |WARNING| pw43931 [2/8] net/mvneta: add Rx/Tx support
Date: Tue, 28 Aug 2018 17:10:46 +0200 (CEST) [thread overview]
Message-ID: <20180828151046.96416532C@dpdk.org> (raw)
In-Reply-To: <1535469030-18647-3-git-send-email-amo@semihalf.com>
Test-Label: checkpatch
Test-Status: WARNING
http://dpdk.org/patch/43931
_coding style issues_
CHECK:MACRO_ARG_PRECEDENCE: Macro argument 'addr' may be better as '(addr)' to avoid precedence issues
#50: FILE: drivers/net/mvneta/mvneta_ethdev.c:59:
+#define MVNETA_SET_COOKIE_HIGH_ADDR(addr) { \
+ if (unlikely(cookie_addr_high == MVNETA_COOKIE_ADDR_INVALID)) \
+ cookie_addr_high = \
+ (uint64_t)addr & MVNETA_COOKIE_HIGH_ADDR_MASK; \
+}
CHECK:MACRO_ARG_PRECEDENCE: Macro argument 'addr' may be better as '(addr)' to avoid precedence issues
#56: FILE: drivers/net/mvneta/mvneta_ethdev.c:65:
+#define MVNETA_CHECK_COOKIE_HIGH_ADDR(addr) \
+ ((likely(cookie_addr_high == \
+ ((uint64_t)addr & MVNETA_COOKIE_HIGH_ADDR_MASK))) ? 1 : 0)
CHECK:OPEN_ENDED_LINE: Lines should not end with a '('
#336: FILE: drivers/net/mvneta/mvneta_ethdev.c:362:
+ rte_pktmbuf_free(
CHECK:OPEN_ENDED_LINE: Lines should not end with a '('
#707: FILE: drivers/net/mvneta/mvneta_ethdev.c:774:
+ bytes_sent -= rte_pktmbuf_pkt_len(
CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses around 'num != rxq->size'
#870: FILE: drivers/net/mvneta/mvneta_ethdev.c:1302:
+ if (ret || (num != rxq->size)) {
total: 0 errors, 0 warnings, 5 checks, 895 lines checked
parent reply other threads:[~2018-08-28 15:10 UTC|newest]
Thread overview: expand[flat|nested] mbox.gz Atom feed
[parent not found: <1535469030-18647-3-git-send-email-amo@semihalf.com>]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180828151046.96416532C@dpdk.org \
--to=checkpatch@dpdk.org \
--cc=amo@semihalf.com \
--cc=test-report@dpdk.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).