From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <checkpatch@dpdk.org>
Received: by dpdk.org (Postfix, from userid 1017)
 id 96416532C; Tue, 28 Aug 2018 17:10:46 +0200 (CEST)
In-Reply-To: <1535469030-18647-3-git-send-email-amo@semihalf.com>
References: <1535469030-18647-3-git-send-email-amo@semihalf.com>
To: test-report@dpdk.org
Cc: Andrzej Ostruszka <amo@semihalf.com>
Message-Id: <20180828151046.96416532C@dpdk.org>
Date: Tue, 28 Aug 2018 17:10:46 +0200 (CEST)
From: checkpatch@dpdk.org
Subject: [dpdk-test-report] |WARNING| pw43931 [2/8] net/mvneta: add Rx/Tx
	support
X-BeenThere: test-report@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: automatic DPDK test reports <test-report.dpdk.org>
List-Unsubscribe: <https://mails.dpdk.org/options/test-report>,
 <mailto:test-report-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://mails.dpdk.org/archives/test-report/>
List-Post: <mailto:test-report@dpdk.org>
List-Help: <mailto:test-report-request@dpdk.org?subject=help>
List-Subscribe: <https://mails.dpdk.org/listinfo/test-report>,
 <mailto:test-report-request@dpdk.org?subject=subscribe>
X-List-Received-Date: Tue, 28 Aug 2018 15:10:46 -0000

Test-Label: checkpatch
Test-Status: WARNING
http://dpdk.org/patch/43931

_coding style issues_


CHECK:MACRO_ARG_PRECEDENCE: Macro argument 'addr' may be better as '(addr)' to avoid precedence issues
#50: FILE: drivers/net/mvneta/mvneta_ethdev.c:59:
+#define MVNETA_SET_COOKIE_HIGH_ADDR(addr) {				\
+	if (unlikely(cookie_addr_high == MVNETA_COOKIE_ADDR_INVALID))	\
+		cookie_addr_high =					\
+			(uint64_t)addr & MVNETA_COOKIE_HIGH_ADDR_MASK;	\
+}

CHECK:MACRO_ARG_PRECEDENCE: Macro argument 'addr' may be better as '(addr)' to avoid precedence issues
#56: FILE: drivers/net/mvneta/mvneta_ethdev.c:65:
+#define MVNETA_CHECK_COOKIE_HIGH_ADDR(addr)			\
+	((likely(cookie_addr_high ==				\
+	((uint64_t)addr & MVNETA_COOKIE_HIGH_ADDR_MASK))) ? 1 : 0)

CHECK:OPEN_ENDED_LINE: Lines should not end with a '('
#336: FILE: drivers/net/mvneta/mvneta_ethdev.c:362:
+		rte_pktmbuf_free(

CHECK:OPEN_ENDED_LINE: Lines should not end with a '('
#707: FILE: drivers/net/mvneta/mvneta_ethdev.c:774:
+				bytes_sent -= rte_pktmbuf_pkt_len(

CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses around 'num != rxq->size'
#870: FILE: drivers/net/mvneta/mvneta_ethdev.c:1302:
+		if (ret || (num != rxq->size)) {

total: 0 errors, 0 warnings, 5 checks, 895 lines checked