From: checkpatch@dpdk.org
To: test-report@dpdk.org
Cc: Igor Russkikh <igor.russkikh@aquantia.com>
Subject: [dpdk-test-report] |WARNING| pw44395 [01/21] net/atlantic: atlantic PMD driver skeleton
Date: Fri, 7 Sep 2018 17:24:39 +0200 (CEST) [thread overview]
Message-ID: <20180907152439.58DCC4CBB@dpdk.org> (raw)
In-Reply-To: <1536333719-32155-2-git-send-email-igor.russkikh@aquantia.com>
Test-Label: checkpatch
Test-Status: WARNING
http://dpdk.org/patch/44395
_coding style issues_
CHECK:SPACING: spaces preferred around that '*' (ctx:VxV)
#198: FILE: drivers/net/atlantic/atl_common.h:54:
+#define ATL_MAX_RING_DESC (8*1024-8)
^
CHECK:SPACING: spaces preferred around that '-' (ctx:VxV)
#198: FILE: drivers/net/atlantic/atl_common.h:54:
+#define ATL_MAX_RING_DESC (8*1024-8)
^
WARNING:BRACES: braces {} are not necessary for single statement blocks
#401: FILE: drivers/net/atlantic/atl_ethdev.c:154:
+ if (rte_eal_process_type() != RTE_PROC_PRIMARY) {
+ return 0;
+ }
WARNING:BRACES: braces {} are not necessary for single statement blocks
#469: FILE: drivers/net/atlantic/atl_ethdev.c:222:
+ if (intr_vector > ATL_MAX_INTR_QUEUE_NUM) {
+ return -ENOTSUP;
+ }
WARNING:BRACES: braces {} are not necessary for single statement blocks
#472: FILE: drivers/net/atlantic/atl_ethdev.c:225:
+ if (rte_intr_efd_enable(intr_handle, intr_vector)) {
+ return -1;
+ }
WARNING:BRACES: braces {} are not necessary for single statement blocks
#480: FILE: drivers/net/atlantic/atl_ethdev.c:233:
+ if (intr_handle->intr_vec == NULL) {
+ return -ENOMEM;
+ }
CHECK:BRACES: Blank lines aren't necessary after an open brace '{'
#498: FILE: drivers/net/atlantic/atl_ethdev.c:251:
+{
+
CHECK:BRACES: Blank lines aren't necessary before a close brace '}'
#499: FILE: drivers/net/atlantic/atl_ethdev.c:252:
+
+}
total: 0 errors, 4 warnings, 526 lines checked
parent reply other threads:[~2018-09-07 15:24 UTC|newest]
Thread overview: expand[flat|nested] mbox.gz Atom feed
[parent not found: <1536333719-32155-2-git-send-email-igor.russkikh@aquantia.com>]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180907152439.58DCC4CBB@dpdk.org \
--to=checkpatch@dpdk.org \
--cc=igor.russkikh@aquantia.com \
--cc=test-report@dpdk.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).