From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <checkpatch@dpdk.org>
Received: by dpdk.org (Postfix, from userid 1017)
 id 58DCC4CBB; Fri,  7 Sep 2018 17:24:39 +0200 (CEST)
In-Reply-To: <1536333719-32155-2-git-send-email-igor.russkikh@aquantia.com>
References: <1536333719-32155-2-git-send-email-igor.russkikh@aquantia.com>
To: test-report@dpdk.org
Cc: Igor Russkikh <igor.russkikh@aquantia.com>
Message-Id: <20180907152439.58DCC4CBB@dpdk.org>
Date: Fri,  7 Sep 2018 17:24:39 +0200 (CEST)
From: checkpatch@dpdk.org
Subject: [dpdk-test-report] |WARNING| pw44395 [01/21] net/atlantic: atlantic
	PMD driver skeleton
X-BeenThere: test-report@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: automatic DPDK test reports <test-report.dpdk.org>
List-Unsubscribe: <https://mails.dpdk.org/options/test-report>,
 <mailto:test-report-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://mails.dpdk.org/archives/test-report/>
List-Post: <mailto:test-report@dpdk.org>
List-Help: <mailto:test-report-request@dpdk.org?subject=help>
List-Subscribe: <https://mails.dpdk.org/listinfo/test-report>,
 <mailto:test-report-request@dpdk.org?subject=subscribe>
X-List-Received-Date: Fri, 07 Sep 2018 15:24:39 -0000

Test-Label: checkpatch
Test-Status: WARNING
http://dpdk.org/patch/44395

_coding style issues_


CHECK:SPACING: spaces preferred around that '*' (ctx:VxV)
#198: FILE: drivers/net/atlantic/atl_common.h:54:
+#define ATL_MAX_RING_DESC	(8*1024-8)
                          	  ^

CHECK:SPACING: spaces preferred around that '-' (ctx:VxV)
#198: FILE: drivers/net/atlantic/atl_common.h:54:
+#define ATL_MAX_RING_DESC	(8*1024-8)
                          	       ^

WARNING:BRACES: braces {} are not necessary for single statement blocks
#401: FILE: drivers/net/atlantic/atl_ethdev.c:154:
+	if (rte_eal_process_type() != RTE_PROC_PRIMARY) {
+		return 0;
+	}

WARNING:BRACES: braces {} are not necessary for single statement blocks
#469: FILE: drivers/net/atlantic/atl_ethdev.c:222:
+		if (intr_vector > ATL_MAX_INTR_QUEUE_NUM) {
+			return -ENOTSUP;
+		}

WARNING:BRACES: braces {} are not necessary for single statement blocks
#472: FILE: drivers/net/atlantic/atl_ethdev.c:225:
+		if (rte_intr_efd_enable(intr_handle, intr_vector)) {
+			return -1;
+		}

WARNING:BRACES: braces {} are not necessary for single statement blocks
#480: FILE: drivers/net/atlantic/atl_ethdev.c:233:
+		if (intr_handle->intr_vec == NULL) {
+			return -ENOMEM;
+		}

CHECK:BRACES: Blank lines aren't necessary after an open brace '{'
#498: FILE: drivers/net/atlantic/atl_ethdev.c:251:
+{
+

CHECK:BRACES: Blank lines aren't necessary before a close brace '}'
#499: FILE: drivers/net/atlantic/atl_ethdev.c:252:
+
+}

total: 0 errors, 4 warnings, 526 lines checked