[dpdk-test-report] |WARNING| pw44398 [05/21] net/atlantic: b0 hardware layer main logic

[dpdk-test-report] |WARNING| pw44398 [05/21] net/atlantic: b0 hardware layer main logic

[checkpatch]

Test-Label: checkpatch
Test-Status: WARNING
http://dpdk.org/patch/44398

_coding style issues_


ERROR:TRAILING_WHITESPACE: trailing whitespace
#172: FILE: drivers/net/atlantic/hw_atl/hw_atl_b0.c:135:
+^Iu32 shift = 0;^I$

WARNING:TABSTOP: Statements should start on a tabstop
#189: FILE: drivers/net/atlantic/hw_atl/hw_atl_b0.c:152:
+		 if (err < 0)

ERROR:TRAILING_WHITESPACE: trailing whitespace
#199: FILE: drivers/net/atlantic/hw_atl/hw_atl_b0.c:162:
+}^I^I$

WARNING:LONG_LINE_COMMENT: line over 90 characters
#315: FILE: drivers/net/atlantic/hw_atl/hw_atl_b0.c:278:
+#define pif_rpf_rss_ipv4_hdr_only_i     (1 << 4)    //calc hash only in IPv4 header, regardless of presence of TCP

WARNING:LONG_LINE_COMMENT: line over 90 characters
#316: FILE: drivers/net/atlantic/hw_atl/hw_atl_b0.c:279:
+#define pif_rpf_rss_ipv4_tcp_hdr_only_i (1 << 3)    //calc hash only if TCP header and IPv4

WARNING:LONG_LINE_COMMENT: line over 90 characters
#317: FILE: drivers/net/atlantic/hw_atl/hw_atl_b0.c:280:
+#define pif_rpf_rss_ipv6_hdr_only_i     (1 << 2)    //calc hash only in IPv6 header, regardless of presence of TCP

WARNING:LONG_LINE_COMMENT: line over 90 characters
#318: FILE: drivers/net/atlantic/hw_atl/hw_atl_b0.c:281:
+#define pif_rpf_rss_ipv6_tcp_hdr_only_i (1 << 1)    //calc hash only if TCP header and IPv4

WARNING:TYPO_SPELLING: 'Isnt' may be misspelled - perhaps 'Isn't'?
#379: FILE: drivers/net/atlantic/hw_atl/hw_atl_b0.c:342:
+	// TODO: Isnt that link up is too early?

WARNING:LONG_LINE: line over 90 characters
#484: FILE: drivers/net/atlantic/hw_atl/hw_atl_b0.c:447:
+int hw_atl_b0_hw_ring_tx_init(struct aq_hw_s *self, uint64_t base_addr, int index, int size, int cpu, int vec)

WARNING:LONG_LINE: line over 90 characters
#567: FILE: drivers/net/atlantic/hw_atl/hw_atl_b0.h:20:
+int hw_atl_b0_hw_ring_tx_init(struct aq_hw_s *self, uint64_t base_addr, int index, int size, int cpu, int vec);

CHECK:SPACING: spaces preferred around that '*' (ctx:VxV)
#673: FILE: drivers/net/atlantic/hw_atl/hw_atl_b0_internal.h:75:
+#define HW_ATL_B0_RXD_BUF_SIZE_MAX  (16*1024)
                                        ^

total: 2 errors, 8 warnings, 1 checks, 700 lines checked