From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: by dpdk.org (Postfix, from userid 1017) id BD4705689; Fri, 7 Sep 2018 17:24:46 +0200 (CEST) In-Reply-To: <1536333719-32155-7-git-send-email-igor.russkikh@aquantia.com> References: <1536333719-32155-7-git-send-email-igor.russkikh@aquantia.com> To: test-report@dpdk.org Cc: Igor Russkikh Message-Id: <20180907152446.BD4705689@dpdk.org> Date: Fri, 7 Sep 2018 17:24:46 +0200 (CEST) From: checkpatch@dpdk.org Subject: [dpdk-test-report] |WARNING| pw44399 [06/21] net/atlantic: firmware operations layer X-BeenThere: test-report@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: automatic DPDK test reports List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 07 Sep 2018 15:24:47 -0000 Test-Label: checkpatch Test-Status: WARNING http://dpdk.org/patch/44399 _coding style issues_ WARNING:AVOID_EXTERNS: externs should be avoided in .c files #99: FILE: drivers/net/atlantic/hw_atl/hw_atl_utils.c:58: +int hw_atl_utils_mpi_set_state(struct aq_hw_s *self, WARNING:LONG_LINE_COMMENT: line over 90 characters #574: FILE: drivers/net/atlantic/hw_atl/hw_atl_utils.c:533: + unsigned int mtu = 1514; //TODO self->aq_nic_cfg ? self->aq_nic_cfg->mtu : 1514U; CHECK:MACRO_ARG_REUSE: Macro argument reuse '_N_' - possible side-effects? #800: FILE: drivers/net/atlantic/hw_atl/hw_atl_utils.c:759: +#define AQ_SDELTA(_N_) (self->curr_stats._N_ += \ + mbox.stats._N_ - self->last_stats._N_) CHECK:MACRO_ARG_PRECEDENCE: Macro argument '_N_' may be better as '(_N_)' to avoid precedence issues #800: FILE: drivers/net/atlantic/hw_atl/hw_atl_utils.c:759: +#define AQ_SDELTA(_N_) (self->curr_stats._N_ += \ + mbox.stats._N_ - self->last_stats._N_) WARNING:LONG_LINE: line over 90 characters #826: FILE: drivers/net/atlantic/hw_atl/hw_atl_utils.c:785: + self->curr_stats.dma_oct_rc = hw_atl_stats_rx_dma_good_octet_counterlsw_get(self) + WARNING:LONG_LINE: line over 90 characters #828: FILE: drivers/net/atlantic/hw_atl/hw_atl_utils.c:787: + self->curr_stats.dma_oct_tc = hw_atl_stats_tx_dma_good_octet_counterlsw_get(self) + WARNING:SUSPECT_CODE_INDENT: suspect code indent for conditional statements (8, 32) #898: FILE: drivers/net/atlantic/hw_atl/hw_atl_utils.c:857: + if (err < 0) + goto err_exit; WARNING:SIZEOF_PARENTHESIS: sizeof *prpc should be sizeof(*prpc) #901: FILE: drivers/net/atlantic/hw_atl/hw_atl_utils.c:860: + memset(prpc, 0, sizeof *prpc); WARNING:LONG_LINE: line over 90 characters #911: FILE: drivers/net/atlantic/hw_atl/hw_atl_utils.c:870: + ether_addr_copy((struct ether_addr *)mac, (struct ether_addr *)&prpc->msg_wol.wol_pattern); WARNING:LEADING_SPACE: please, no spaces at the start of a line #1010: FILE: drivers/net/atlantic/hw_atl/hw_atl_utils.h:21: + u64 buf_addr;$ ERROR:TRAILING_WHITESPACE: trailing whitespace #1011: FILE: drivers/net/atlantic/hw_atl/hw_atl_utils.h:22: + $ ERROR:CODE_INDENT: code indent should use tabs where possible #1011: FILE: drivers/net/atlantic/hw_atl/hw_atl_utils.h:22: + $ WARNING:LEADING_SPACE: please, no spaces at the start of a line #1011: FILE: drivers/net/atlantic/hw_atl/hw_atl_utils.h:22: + $ WARNING:LEADING_SPACE: please, no spaces at the start of a line #1012: FILE: drivers/net/atlantic/hw_atl/hw_atl_utils.h:23: + union {$ ERROR:CODE_INDENT: code indent should use tabs where possible #1013: FILE: drivers/net/atlantic/hw_atl/hw_atl_utils.h:24: + struct {$ WARNING:LEADING_SPACE: please, no spaces at the start of a line #1013: FILE: drivers/net/atlantic/hw_atl/hw_atl_utils.h:24: + struct {$ ERROR:CODE_INDENT: code indent should use tabs where possible #1014: FILE: drivers/net/atlantic/hw_atl/hw_atl_utils.h:25: + u32 type:3;$ WARNING:LEADING_SPACE: please, no spaces at the start of a line #1014: FILE: drivers/net/atlantic/hw_atl/hw_atl_utils.h:25: + u32 type:3;$ ERROR:CODE_INDENT: code indent should use tabs where possible #1015: FILE: drivers/net/atlantic/hw_atl/hw_atl_utils.h:26: + u32 :1;$ WARNING:LEADING_SPACE: please, no spaces at the start of a line #1015: FILE: drivers/net/atlantic/hw_atl/hw_atl_utils.h:26: + u32 :1;$ ERROR:SPACING: space prohibited before that ':' (ctx:WxV) #1015: FILE: drivers/net/atlantic/hw_atl/hw_atl_utils.h:26: + u32 :1; ^ ERROR:CODE_INDENT: code indent should use tabs where possible #1016: FILE: drivers/net/atlantic/hw_atl/hw_atl_utils.h:27: + u32 len:16;$ WARNING:LEADING_SPACE: please, no spaces at the start of a line #1016: FILE: drivers/net/atlantic/hw_atl/hw_atl_utils.h:27: + u32 len:16;$ ERROR:CODE_INDENT: code indent should use tabs where possible #1017: FILE: drivers/net/atlantic/hw_atl/hw_atl_utils.h:28: + u32 dd:1;$ WARNING:LEADING_SPACE: please, no spaces at the start of a line #1017: FILE: drivers/net/atlantic/hw_atl/hw_atl_utils.h:28: + u32 dd:1;$ ERROR:CODE_INDENT: code indent should use tabs where possible #1018: FILE: drivers/net/atlantic/hw_atl/hw_atl_utils.h:29: + u32 eop:1;$ WARNING:LEADING_SPACE: please, no spaces at the start of a line #1018: FILE: drivers/net/atlantic/hw_atl/hw_atl_utils.h:29: + u32 eop:1;$ ERROR:CODE_INDENT: code indent should use tabs where possible #1019: FILE: drivers/net/atlantic/hw_atl/hw_atl_utils.h:30: + u32 cmd:8;$ WARNING:LEADING_SPACE: please, no spaces at the start of a line #1019: FILE: drivers/net/atlantic/hw_atl/hw_atl_utils.h:30: + u32 cmd:8;$ ERROR:CODE_INDENT: code indent should use tabs where possible #1020: FILE: drivers/net/atlantic/hw_atl/hw_atl_utils.h:31: + u32 :14;$ WARNING:LEADING_SPACE: please, no spaces at the start of a line #1020: FILE: drivers/net/atlantic/hw_atl/hw_atl_utils.h:31: + u32 :14;$ ERROR:SPACING: space prohibited before that ':' (ctx:WxV) #1020: FILE: drivers/net/atlantic/hw_atl/hw_atl_utils.h:31: + u32 :14; ^ ERROR:CODE_INDENT: code indent should use tabs where possible #1021: FILE: drivers/net/atlantic/hw_atl/hw_atl_utils.h:32: + u32 ct_idx:1;$ WARNING:LEADING_SPACE: please, no spaces at the start of a line #1021: FILE: drivers/net/atlantic/hw_atl/hw_atl_utils.h:32: + u32 ct_idx:1;$ ERROR:CODE_INDENT: code indent should use tabs where possible #1022: FILE: drivers/net/atlantic/hw_atl/hw_atl_utils.h:33: + u32 ct_en:1;$ WARNING:LEADING_SPACE: please, no spaces at the start of a line #1022: FILE: drivers/net/atlantic/hw_atl/hw_atl_utils.h:33: + u32 ct_en:1;$ ERROR:CODE_INDENT: code indent should use tabs where possible #1023: FILE: drivers/net/atlantic/hw_atl/hw_atl_utils.h:34: + u32 pay_len:18;$ WARNING:LEADING_SPACE: please, no spaces at the start of a line #1023: FILE: drivers/net/atlantic/hw_atl/hw_atl_utils.h:34: + u32 pay_len:18;$ ERROR:CODE_INDENT: code indent should use tabs where possible #1024: FILE: drivers/net/atlantic/hw_atl/hw_atl_utils.h:35: + } __attribute__((__packed__));$ WARNING:LEADING_SPACE: please, no spaces at the start of a line #1024: FILE: drivers/net/atlantic/hw_atl/hw_atl_utils.h:35: + } __attribute__((__packed__));$ ERROR:TRAILING_WHITESPACE: trailing whitespace #1025: FILE: drivers/net/atlantic/hw_atl/hw_atl_utils.h:36: + u64 flags; $ ERROR:CODE_INDENT: code indent should use tabs where possible #1025: FILE: drivers/net/atlantic/hw_atl/hw_atl_utils.h:36: + u64 flags; $ WARNING:LEADING_SPACE: please, no spaces at the start of a line #1025: FILE: drivers/net/atlantic/hw_atl/hw_atl_utils.h:36: + u64 flags; $ WARNING:LEADING_SPACE: please, no spaces at the start of a line #1026: FILE: drivers/net/atlantic/hw_atl/hw_atl_utils.h:37: + };$ WARNING:LEADING_SPACE: please, no spaces at the start of a line #1031: FILE: drivers/net/atlantic/hw_atl/hw_atl_utils.h:42: + struct {$ ERROR:CODE_INDENT: code indent should use tabs where possible #1032: FILE: drivers/net/atlantic/hw_atl/hw_atl_utils.h:43: + u64 flags1;$ WARNING:LEADING_SPACE: please, no spaces at the start of a line #1032: FILE: drivers/net/atlantic/hw_atl/hw_atl_utils.h:43: + u64 flags1;$ ERROR:CODE_INDENT: code indent should use tabs where possible #1033: FILE: drivers/net/atlantic/hw_atl/hw_atl_utils.h:44: + u64 flags2;$ WARNING:LEADING_SPACE: please, no spaces at the start of a line #1033: FILE: drivers/net/atlantic/hw_atl/hw_atl_utils.h:44: + u64 flags2;$ WARNING:LEADING_SPACE: please, no spaces at the start of a line #1034: FILE: drivers/net/atlantic/hw_atl/hw_atl_utils.h:45: + };$ ERROR:TRAILING_WHITESPACE: trailing whitespace #1035: FILE: drivers/net/atlantic/hw_atl/hw_atl_utils.h:46: + $ WARNING:LEADING_SPACE: please, no spaces at the start of a line #1035: FILE: drivers/net/atlantic/hw_atl/hw_atl_utils.h:46: + $ WARNING:LEADING_SPACE: please, no spaces at the start of a line #1036: FILE: drivers/net/atlantic/hw_atl/hw_atl_utils.h:47: + struct {$ ERROR:CODE_INDENT: code indent should use tabs where possible #1037: FILE: drivers/net/atlantic/hw_atl/hw_atl_utils.h:48: + u64 :40;$ WARNING:LEADING_SPACE: please, no spaces at the start of a line #1037: FILE: drivers/net/atlantic/hw_atl/hw_atl_utils.h:48: + u64 :40;$ ERROR:SPACING: space prohibited before that ':' (ctx:WxV) #1037: FILE: drivers/net/atlantic/hw_atl/hw_atl_utils.h:48: + u64 :40; ^ ERROR:CODE_INDENT: code indent should use tabs where possible #1038: FILE: drivers/net/atlantic/hw_atl/hw_atl_utils.h:49: + u32 tun_len:8;$ WARNING:LEADING_SPACE: please, no spaces at the start of a line #1038: FILE: drivers/net/atlantic/hw_atl/hw_atl_utils.h:49: + u32 tun_len:8;$ ERROR:CODE_INDENT: code indent should use tabs where possible #1039: FILE: drivers/net/atlantic/hw_atl/hw_atl_utils.h:50: + u32 out_len:16;$ WARNING:LEADING_SPACE: please, no spaces at the start of a line #1039: FILE: drivers/net/atlantic/hw_atl/hw_atl_utils.h:50: + u32 out_len:16;$ ERROR:CODE_INDENT: code indent should use tabs where possible #1040: FILE: drivers/net/atlantic/hw_atl/hw_atl_utils.h:51: + u32 type:3;$ WARNING:LEADING_SPACE: please, no spaces at the start of a line #1040: FILE: drivers/net/atlantic/hw_atl/hw_atl_utils.h:51: + u32 type:3;$ ERROR:CODE_INDENT: code indent should use tabs where possible #1041: FILE: drivers/net/atlantic/hw_atl/hw_atl_utils.h:52: + u32 idx:1;$ WARNING:LEADING_SPACE: please, no spaces at the start of a line #1041: FILE: drivers/net/atlantic/hw_atl/hw_atl_utils.h:52: + u32 idx:1;$ ERROR:CODE_INDENT: code indent should use tabs where possible #1042: FILE: drivers/net/atlantic/hw_atl/hw_atl_utils.h:53: + u32 vlan_tag:16;$ WARNING:LEADING_SPACE: please, no spaces at the start of a line #1042: FILE: drivers/net/atlantic/hw_atl/hw_atl_utils.h:53: + u32 vlan_tag:16;$ ERROR:CODE_INDENT: code indent should use tabs where possible #1043: FILE: drivers/net/atlantic/hw_atl/hw_atl_utils.h:54: + u32 cmd:4;$ WARNING:LEADING_SPACE: please, no spaces at the start of a line #1043: FILE: drivers/net/atlantic/hw_atl/hw_atl_utils.h:54: + u32 cmd:4;$ ERROR:CODE_INDENT: code indent should use tabs where possible #1044: FILE: drivers/net/atlantic/hw_atl/hw_atl_utils.h:55: + u32 l2_len:7;$ WARNING:LEADING_SPACE: please, no spaces at the start of a line #1044: FILE: drivers/net/atlantic/hw_atl/hw_atl_utils.h:55: + u32 l2_len:7;$ ERROR:CODE_INDENT: code indent should use tabs where possible #1045: FILE: drivers/net/atlantic/hw_atl/hw_atl_utils.h:56: + u32 l3_len:9;$ WARNING:LEADING_SPACE: please, no spaces at the start of a line #1045: FILE: drivers/net/atlantic/hw_atl/hw_atl_utils.h:56: + u32 l3_len:9;$ ERROR:CODE_INDENT: code indent should use tabs where possible #1046: FILE: drivers/net/atlantic/hw_atl/hw_atl_utils.h:57: + u32 l4_len:8;$ WARNING:LEADING_SPACE: please, no spaces at the start of a line #1046: FILE: drivers/net/atlantic/hw_atl/hw_atl_utils.h:57: + u32 l4_len:8;$ ERROR:CODE_INDENT: code indent should use tabs where possible #1047: FILE: drivers/net/atlantic/hw_atl/hw_atl_utils.h:58: + u32 mss_len:16;$ WARNING:LEADING_SPACE: please, no spaces at the start of a line #1047: FILE: drivers/net/atlantic/hw_atl/hw_atl_utils.h:58: + u32 mss_len:16;$ WARNING:LEADING_SPACE: please, no spaces at the start of a line #1048: FILE: drivers/net/atlantic/hw_atl/hw_atl_utils.h:59: + } __attribute__((__packed__));$ WARNING:LEADING_SPACE: please, no spaces at the start of a line #1052: FILE: drivers/net/atlantic/hw_atl/hw_atl_utils.h:63: + tx_desc_type_desc = 1,$ WARNING:LEADING_SPACE: please, no spaces at the start of a line #1053: FILE: drivers/net/atlantic/hw_atl/hw_atl_utils.h:64: + tx_desc_type_ctx = 2,$ WARNING:LEADING_SPACE: please, no spaces at the start of a line #1057: FILE: drivers/net/atlantic/hw_atl/hw_atl_utils.h:68: + tx_desc_cmd_vlan = 1,$ WARNING:LEADING_SPACE: please, no spaces at the start of a line #1058: FILE: drivers/net/atlantic/hw_atl/hw_atl_utils.h:69: + tx_desc_cmd_fcs = 2,$ WARNING:LEADING_SPACE: please, no spaces at the start of a line #1059: FILE: drivers/net/atlantic/hw_atl/hw_atl_utils.h:70: + tx_desc_cmd_ipv4 = 4,$ WARNING:LEADING_SPACE: please, no spaces at the start of a line #1060: FILE: drivers/net/atlantic/hw_atl/hw_atl_utils.h:71: + tx_desc_cmd_l4cs = 8,$ WARNING:LEADING_SPACE: please, no spaces at the start of a line #1061: FILE: drivers/net/atlantic/hw_atl/hw_atl_utils.h:72: + tx_desc_cmd_lso = 0x10,$ WARNING:LEADING_SPACE: please, no spaces at the start of a line #1062: FILE: drivers/net/atlantic/hw_atl/hw_atl_utils.h:73: + tx_desc_cmd_wb = 0x20,$ CHECK:CAMELCASE: Avoid CamelCase: #1180: FILE: drivers/net/atlantic/hw_atl/hw_atl_utils.h:191: + u16 tcQuanta[8]; CHECK:CAMELCASE: Avoid CamelCase: #1181: FILE: drivers/net/atlantic/hw_atl/hw_atl_utils.h:192: + u16 tcThreshold[8]; ERROR:SPACING: spaces required around that '|=' (ctx:VxW) #1642: FILE: drivers/net/atlantic/hw_atl/hw_atl_utils_fw2x.c:131: + rate|= AQ_NIC_RATE_EEE_1G; ^ ERROR:SPACING: space required before the open parenthesis '(' #1674: FILE: drivers/net/atlantic/hw_atl/hw_atl_utils_fw2x.c:163: + switch(state) { WARNING:BLOCK_COMMENT_STYLE: Block comments use * on subsequent lines #1678: FILE: drivers/net/atlantic/hw_atl/hw_atl_utils_fw2x.c:167: +/* if (self->aq_nic_cfg->flow_control & AQ_NIC_FC_RX) + mpi_state |= BIT(CAPS_HI_PAUSE); CHECK:SPACING: spaces preferred around that '/' (ctx:VxV) #1810: FILE: drivers/net/atlantic/hw_atl/hw_atl_utils_fw2x.c:299: + sizeof(temp_res)/sizeof(u32)); ^ CHECK:SPACING: spaces preferred around that '/' (ctx:VxV) #1829: FILE: drivers/net/atlantic/hw_atl/hw_atl_utils_fw2x.c:318: + sizeof(cable_len_res)/sizeof(u32)); ^ CHECK:SPACING: spaces preferred around that '/' (ctx:VxV) #1972: FILE: drivers/net/atlantic/hw_atl/hw_atl_utils_fw2x.c:461: + sizeof(caps_hi)/sizeof(u32)); ^ WARNING:CONSTANT_COMPARISON: Comparisons should place the constant on the right side of the test #2000: FILE: drivers/net/atlantic/hw_atl/hw_atl_utils_fw2x.c:489: + if (HW_ATL_FW_FEATURE_LED > self->fw_ver_actual) WARNING:CONSTANT_COMPARISON: Comparisons should place the constant on the right side of the test #2014: FILE: drivers/net/atlantic/hw_atl/hw_atl_utils_fw2x.c:503: + if (HW_ATL_FW_FEATURE_EEPROM > self->fw_ver_actual) CHECK:SPACING: spaces preferred around that '*' (ctx:VxV) #2051: FILE: drivers/net/atlantic/hw_atl/hw_atl_utils_fw2x.c:540: + err = hw_atl_utils_fw_downld_dwords(self, self->rpc_addr + sizeof(u32)*2, ^ WARNING:CONSTANT_COMPARISON: Comparisons should place the constant on the right side of the test #2069: FILE: drivers/net/atlantic/hw_atl/hw_atl_utils_fw2x.c:558: + if (HW_ATL_FW_FEATURE_EEPROM > self->fw_ver_actual) total: 35 errors, 54 warnings, 8 checks, 2081 lines checked