From: checkpatch@dpdk.org
To: test-report@dpdk.org
Cc: Igor Russkikh <igor.russkikh@aquantia.com>
Subject: [dpdk-test-report] |WARNING| pw44402 [08/21] net/atlantic: rte device start, stop, initial configuration
Date: Fri, 7 Sep 2018 17:24:54 +0200 (CEST) [thread overview]
Message-ID: <20180907152454.66E0C5592@dpdk.org> (raw)
In-Reply-To: <1536333719-32155-9-git-send-email-igor.russkikh@aquantia.com>
Test-Label: checkpatch
Test-Status: WARNING
http://dpdk.org/patch/44402
_coding style issues_
CHECK:SPACING: space preferred before that '|' (ctx:VxE)
#102: FILE: drivers/net/atlantic/atl_ethdev.c:206:
+ adapter->hw_cfg.link_speed_msk = AQ_NIC_RATE_10G|
^
CHECK:SPACING: space preferred before that '|' (ctx:VxE)
#103: FILE: drivers/net/atlantic/atl_ethdev.c:207:
+ AQ_NIC_RATE_5G|
^
CHECK:SPACING: space preferred before that '|' (ctx:VxE)
#104: FILE: drivers/net/atlantic/atl_ethdev.c:208:
+ AQ_NIC_RATE_2G5|
^
CHECK:SPACING: space preferred before that '|' (ctx:VxE)
#105: FILE: drivers/net/atlantic/atl_ethdev.c:209:
+ AQ_NIC_RATE_1G|
^
ERROR:CODE_INDENT: code indent should use tabs where possible
#111: FILE: drivers/net/atlantic/atl_ethdev.c:215:
+ hw->aq_nic_cfg = &adapter->hw_cfg;$
WARNING:LEADING_SPACE: please, no spaces at the start of a line
#111: FILE: drivers/net/atlantic/atl_ethdev.c:215:
+ hw->aq_nic_cfg = &adapter->hw_cfg;$
ERROR:TRAILING_WHITESPACE: trailing whitespace
#126: FILE: drivers/net/atlantic/atl_ethdev.c:230:
+^Ierr = hw_atl_utils_initfw(hw, &hw->aq_fw_ops); $
ERROR:POINTER_LOCATION: "(foo*)" should be "(foo *)"
#131: FILE: drivers/net/atlantic/atl_ethdev.c:235:
+ if (hw->aq_fw_ops->get_mac_permanent(hw, (u8*)ð_dev->data->mac_addrs[0]) != 0)
WARNING:BRACES: braces {} are not necessary for single statement blocks
#212: FILE: drivers/net/atlantic/atl_ethdev.c:352:
+ if (status != 0) {
+ return -1;
+ }
ERROR:POINTER_LOCATION: "(foo*)" should be "(foo *)"
#216: FILE: drivers/net/atlantic/atl_ethdev.c:356:
+ err = hw_atl_b0_hw_init(hw, (uint8_t*)dev->data->mac_addrs);
ERROR:CODE_INDENT: code indent should use tabs where possible
#330: FILE: drivers/net/atlantic/atl_ethdev.c:511:
+ atl_dev_link_update(dev, 0);$
WARNING:LEADING_SPACE: please, no spaces at the start of a line
#330: FILE: drivers/net/atlantic/atl_ethdev.c:511:
+ atl_dev_link_update(dev, 0);$
ERROR:CODE_INDENT: code indent should use tabs where possible
#331: FILE: drivers/net/atlantic/atl_ethdev.c:512:
+ intr->flags &= ~ATL_FLAG_NEED_LINK_UPDATE;$
WARNING:LEADING_SPACE: please, no spaces at the start of a line
#331: FILE: drivers/net/atlantic/atl_ethdev.c:512:
+ intr->flags &= ~ATL_FLAG_NEED_LINK_UPDATE;$
ERROR:CODE_INDENT: code indent should use tabs where possible
#332: FILE: drivers/net/atlantic/atl_ethdev.c:513:
+ atl_dev_link_status_print(dev);$
WARNING:LEADING_SPACE: please, no spaces at the start of a line
#332: FILE: drivers/net/atlantic/atl_ethdev.c:513:
+ atl_dev_link_status_print(dev);$
ERROR:CODE_INDENT: code indent should use tabs where possible
#333: FILE: drivers/net/atlantic/atl_ethdev.c:514:
+ _rte_eth_dev_callback_process(dev, RTE_ETH_EVENT_INTR_LSC, NULL);$
WARNING:LEADING_SPACE: please, no spaces at the start of a line
#333: FILE: drivers/net/atlantic/atl_ethdev.c:514:
+ _rte_eth_dev_callback_process(dev, RTE_ETH_EVENT_INTR_LSC, NULL);$
total: 8 errors, 6 warnings, 4 checks, 332 lines checked
parent reply other threads:[~2018-09-07 15:24 UTC|newest]
Thread overview: expand[flat|nested] mbox.gz Atom feed
[parent not found: <1536333719-32155-9-git-send-email-igor.russkikh@aquantia.com>]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180907152454.66E0C5592@dpdk.org \
--to=checkpatch@dpdk.org \
--cc=igor.russkikh@aquantia.com \
--cc=test-report@dpdk.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).