* [dpdk-test-report] |WARNING| pw44402 [08/21] net/atlantic: rte device start, stop, initial configuration
[not found] <1536333719-32155-9-git-send-email-igor.russkikh@aquantia.com>
@ 2018-09-07 15:24 ` checkpatch
0 siblings, 0 replies; only message in thread
From: checkpatch @ 2018-09-07 15:24 UTC (permalink / raw)
To: test-report; +Cc: Igor Russkikh
Test-Label: checkpatch
Test-Status: WARNING
http://dpdk.org/patch/44402
_coding style issues_
CHECK:SPACING: space preferred before that '|' (ctx:VxE)
#102: FILE: drivers/net/atlantic/atl_ethdev.c:206:
+ adapter->hw_cfg.link_speed_msk = AQ_NIC_RATE_10G|
^
CHECK:SPACING: space preferred before that '|' (ctx:VxE)
#103: FILE: drivers/net/atlantic/atl_ethdev.c:207:
+ AQ_NIC_RATE_5G|
^
CHECK:SPACING: space preferred before that '|' (ctx:VxE)
#104: FILE: drivers/net/atlantic/atl_ethdev.c:208:
+ AQ_NIC_RATE_2G5|
^
CHECK:SPACING: space preferred before that '|' (ctx:VxE)
#105: FILE: drivers/net/atlantic/atl_ethdev.c:209:
+ AQ_NIC_RATE_1G|
^
ERROR:CODE_INDENT: code indent should use tabs where possible
#111: FILE: drivers/net/atlantic/atl_ethdev.c:215:
+ hw->aq_nic_cfg = &adapter->hw_cfg;$
WARNING:LEADING_SPACE: please, no spaces at the start of a line
#111: FILE: drivers/net/atlantic/atl_ethdev.c:215:
+ hw->aq_nic_cfg = &adapter->hw_cfg;$
ERROR:TRAILING_WHITESPACE: trailing whitespace
#126: FILE: drivers/net/atlantic/atl_ethdev.c:230:
+^Ierr = hw_atl_utils_initfw(hw, &hw->aq_fw_ops); $
ERROR:POINTER_LOCATION: "(foo*)" should be "(foo *)"
#131: FILE: drivers/net/atlantic/atl_ethdev.c:235:
+ if (hw->aq_fw_ops->get_mac_permanent(hw, (u8*)ð_dev->data->mac_addrs[0]) != 0)
WARNING:BRACES: braces {} are not necessary for single statement blocks
#212: FILE: drivers/net/atlantic/atl_ethdev.c:352:
+ if (status != 0) {
+ return -1;
+ }
ERROR:POINTER_LOCATION: "(foo*)" should be "(foo *)"
#216: FILE: drivers/net/atlantic/atl_ethdev.c:356:
+ err = hw_atl_b0_hw_init(hw, (uint8_t*)dev->data->mac_addrs);
ERROR:CODE_INDENT: code indent should use tabs where possible
#330: FILE: drivers/net/atlantic/atl_ethdev.c:511:
+ atl_dev_link_update(dev, 0);$
WARNING:LEADING_SPACE: please, no spaces at the start of a line
#330: FILE: drivers/net/atlantic/atl_ethdev.c:511:
+ atl_dev_link_update(dev, 0);$
ERROR:CODE_INDENT: code indent should use tabs where possible
#331: FILE: drivers/net/atlantic/atl_ethdev.c:512:
+ intr->flags &= ~ATL_FLAG_NEED_LINK_UPDATE;$
WARNING:LEADING_SPACE: please, no spaces at the start of a line
#331: FILE: drivers/net/atlantic/atl_ethdev.c:512:
+ intr->flags &= ~ATL_FLAG_NEED_LINK_UPDATE;$
ERROR:CODE_INDENT: code indent should use tabs where possible
#332: FILE: drivers/net/atlantic/atl_ethdev.c:513:
+ atl_dev_link_status_print(dev);$
WARNING:LEADING_SPACE: please, no spaces at the start of a line
#332: FILE: drivers/net/atlantic/atl_ethdev.c:513:
+ atl_dev_link_status_print(dev);$
ERROR:CODE_INDENT: code indent should use tabs where possible
#333: FILE: drivers/net/atlantic/atl_ethdev.c:514:
+ _rte_eth_dev_callback_process(dev, RTE_ETH_EVENT_INTR_LSC, NULL);$
WARNING:LEADING_SPACE: please, no spaces at the start of a line
#333: FILE: drivers/net/atlantic/atl_ethdev.c:514:
+ _rte_eth_dev_callback_process(dev, RTE_ETH_EVENT_INTR_LSC, NULL);$
total: 8 errors, 6 warnings, 4 checks, 332 lines checked
^ permalink raw reply [flat|nested] only message in thread