automatic DPDK test reports
 help / color / mirror / Atom feed
From: checkpatch@dpdk.org
To: test-report@dpdk.org
Cc: Igor Russkikh <igor.russkikh@aquantia.com>
Subject: [dpdk-test-report] |WARNING| pw44409 [14/21] net/atlantic: eeprom and register manipulation routines
Date: Fri,  7 Sep 2018 17:24:59 +0200 (CEST)	[thread overview]
Message-ID: <20180907152459.B714B7CE7@dpdk.org> (raw)
In-Reply-To: <1536333719-32155-15-git-send-email-igor.russkikh@aquantia.com>

Test-Label: checkpatch
Test-Status: WARNING
http://dpdk.org/patch/44409

_coding style issues_


WARNING:LONG_LINE: line over 90 characters
#35: FILE: drivers/net/atlantic/atl_ethdev.c:71:
+static int atl_dev_get_eeprom(struct rte_eth_dev *dev, struct rte_dev_eeprom_info *eeprom);

WARNING:LONG_LINE: line over 90 characters
#36: FILE: drivers/net/atlantic/atl_ethdev.c:72:
+static int atl_dev_set_eeprom(struct rte_eth_dev *dev, struct rte_dev_eeprom_info *eeprom);

CHECK:BRACES: Blank lines aren't necessary before a close brace '}'
#82: FILE: drivers/net/atlantic/atl_ethdev.c:880:
+
+}

ERROR:CODE_INDENT: code indent should use tabs where possible
#92: FILE: drivers/net/atlantic/atl_ethdev.c:890:
+        if (eeprom->length != SFP_EEPROM_SIZE || eeprom->data == NULL)$

WARNING:LEADING_SPACE: please, no spaces at the start of a line
#92: FILE: drivers/net/atlantic/atl_ethdev.c:890:
+        if (eeprom->length != SFP_EEPROM_SIZE || eeprom->data == NULL)$

ERROR:CODE_INDENT: code indent should use tabs where possible
#93: FILE: drivers/net/atlantic/atl_ethdev.c:891:
+                return -EINVAL;$

WARNING:LEADING_SPACE: please, no spaces at the start of a line
#93: FILE: drivers/net/atlantic/atl_ethdev.c:891:
+                return -EINVAL;$

total: 2 errors, 4 warnings, 1 checks, 95 lines checked

           reply	other threads:[~2018-09-07 15:24 UTC|newest]

Thread overview: expand[flat|nested]  mbox.gz  Atom feed
 [parent not found: <1536333719-32155-15-git-send-email-igor.russkikh@aquantia.com>]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20180907152459.B714B7CE7@dpdk.org \
    --to=checkpatch@dpdk.org \
    --cc=igor.russkikh@aquantia.com \
    --cc=test-report@dpdk.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).