From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <checkpatch@dpdk.org>
Received: by dpdk.org (Postfix, from userid 1017)
 id B714B7CE7; Fri,  7 Sep 2018 17:24:59 +0200 (CEST)
In-Reply-To: <1536333719-32155-15-git-send-email-igor.russkikh@aquantia.com>
References: <1536333719-32155-15-git-send-email-igor.russkikh@aquantia.com>
To: test-report@dpdk.org
Cc: Igor Russkikh <igor.russkikh@aquantia.com>
Message-Id: <20180907152459.B714B7CE7@dpdk.org>
Date: Fri,  7 Sep 2018 17:24:59 +0200 (CEST)
From: checkpatch@dpdk.org
Subject: [dpdk-test-report] |WARNING| pw44409 [14/21] net/atlantic: eeprom
	and register manipulation routines
X-BeenThere: test-report@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: automatic DPDK test reports <test-report.dpdk.org>
List-Unsubscribe: <https://mails.dpdk.org/options/test-report>,
 <mailto:test-report-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://mails.dpdk.org/archives/test-report/>
List-Post: <mailto:test-report@dpdk.org>
List-Help: <mailto:test-report-request@dpdk.org?subject=help>
List-Subscribe: <https://mails.dpdk.org/listinfo/test-report>,
 <mailto:test-report-request@dpdk.org?subject=subscribe>
X-List-Received-Date: Fri, 07 Sep 2018 15:25:00 -0000

Test-Label: checkpatch
Test-Status: WARNING
http://dpdk.org/patch/44409

_coding style issues_


WARNING:LONG_LINE: line over 90 characters
#35: FILE: drivers/net/atlantic/atl_ethdev.c:71:
+static int atl_dev_get_eeprom(struct rte_eth_dev *dev, struct rte_dev_eeprom_info *eeprom);

WARNING:LONG_LINE: line over 90 characters
#36: FILE: drivers/net/atlantic/atl_ethdev.c:72:
+static int atl_dev_set_eeprom(struct rte_eth_dev *dev, struct rte_dev_eeprom_info *eeprom);

CHECK:BRACES: Blank lines aren't necessary before a close brace '}'
#82: FILE: drivers/net/atlantic/atl_ethdev.c:880:
+
+}

ERROR:CODE_INDENT: code indent should use tabs where possible
#92: FILE: drivers/net/atlantic/atl_ethdev.c:890:
+        if (eeprom->length != SFP_EEPROM_SIZE || eeprom->data == NULL)$

WARNING:LEADING_SPACE: please, no spaces at the start of a line
#92: FILE: drivers/net/atlantic/atl_ethdev.c:890:
+        if (eeprom->length != SFP_EEPROM_SIZE || eeprom->data == NULL)$

ERROR:CODE_INDENT: code indent should use tabs where possible
#93: FILE: drivers/net/atlantic/atl_ethdev.c:891:
+                return -EINVAL;$

WARNING:LEADING_SPACE: please, no spaces at the start of a line
#93: FILE: drivers/net/atlantic/atl_ethdev.c:891:
+                return -EINVAL;$

total: 2 errors, 4 warnings, 1 checks, 95 lines checked