From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <checkpatch@dpdk.org>
Received: by dpdk.org (Postfix, from userid 1017)
 id 363CE1041; Fri,  7 Sep 2018 17:28:24 +0200 (CEST)
In-Reply-To: <1536333719-32155-20-git-send-email-igor.russkikh@aquantia.com>
References: <1536333719-32155-20-git-send-email-igor.russkikh@aquantia.com>
To: test-report@dpdk.org
Cc: Igor Russkikh <igor.russkikh@aquantia.com>
Message-Id: <20180907152824.363CE1041@dpdk.org>
Date: Fri,  7 Sep 2018 17:28:24 +0200 (CEST)
From: checkpatch@dpdk.org
Subject: [dpdk-test-report] |WARNING| pw44414 [19/21] net/atlantic: device
	MTU and statuses
X-BeenThere: test-report@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: automatic DPDK test reports <test-report.dpdk.org>
List-Unsubscribe: <https://mails.dpdk.org/options/test-report>,
 <mailto:test-report-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://mails.dpdk.org/archives/test-report/>
List-Post: <mailto:test-report@dpdk.org>
List-Help: <mailto:test-report-request@dpdk.org?subject=help>
List-Subscribe: <https://mails.dpdk.org/listinfo/test-report>,
 <mailto:test-report-request@dpdk.org?subject=subscribe>
X-List-Received-Date: Fri, 07 Sep 2018 15:28:24 -0000

Test-Label: checkpatch
Test-Status: WARNING
http://dpdk.org/patch/44414

_coding style issues_


ERROR:SPACING: space prohibited after that open parenthesis '('
#58: FILE: drivers/net/atlantic/atl_ethdev.c:198:
+#define ATL_RX_OFFLOADS ( DEV_RX_OFFLOAD_VLAN_STRIP \

ERROR:SPACING: space prohibited after that open parenthesis '('
#65: FILE: drivers/net/atlantic/atl_ethdev.c:205:
+#define ATL_TX_OFFLOADS ( DEV_TX_OFFLOAD_VLAN_INSERT \

WARNING:EMBEDDED_FUNCTION_NAME: Prefer using '"%s...", __func__' to using 'atl_dev_start', this function's name, in a string
#92: FILE: drivers/net/atlantic/atl_ethdev.c:686:
+	PMD_INIT_LOG(ERR, "failure in atl_dev_start(): %d", err);

WARNING:LONG_LINE: line over 90 characters
#113: FILE: drivers/net/atlantic/atl_ethdev.c:880:
+	ret = snprintf(fw_version, fw_size, "%u.%u.%u", fw_ver >> 24, (fw_ver >> 16) & 0xFFU, fw_ver & 0xFFFFU);

CHECK:SPACING: spaces preferred around that '/' (ctx:VxV)
#156: FILE: drivers/net/atlantic/atl_ethdev.c:923:
+	dev_info->hash_key_size = HW_ATL_B0_RSS_HASHKEY_BITS/8;
 	                                                    ^

CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses around 'mtu < ETHER_MIN_MTU'
#218: FILE: drivers/net/atlantic/atl_ethdev.c:1395:
+	if ((mtu < ETHER_MIN_MTU) || (frame_size > dev_info.max_rx_pktlen))

CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses around 'frame_size > dev_info.max_rx_pktlen'
#218: FILE: drivers/net/atlantic/atl_ethdev.c:1395:
+	if ((mtu < ETHER_MIN_MTU) || (frame_size > dev_info.max_rx_pktlen))

total: 2 errors, 2 warnings, 3 checks, 210 lines checked