From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: by dpdk.org (Postfix, from userid 1017) id A85434CB3; Fri, 7 Sep 2018 17:28:27 +0200 (CEST) In-Reply-To: <1536333719-32155-22-git-send-email-igor.russkikh@aquantia.com> References: <1536333719-32155-22-git-send-email-igor.russkikh@aquantia.com> To: test-report@dpdk.org Cc: Igor Russkikh Message-Id: <20180907152827.A85434CB3@dpdk.org> Date: Fri, 7 Sep 2018 17:28:27 +0200 (CEST) From: checkpatch@dpdk.org Subject: [dpdk-test-report] |WARNING| pw44416 [21/21] net/atlantic: TX side structures and implementation X-BeenThere: test-report@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: automatic DPDK test reports List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 07 Sep 2018 15:28:27 -0000 Test-Label: checkpatch Test-Status: WARNING http://dpdk.org/patch/44416 _coding style issues_ WARNING:LONG_LINE: line over 90 characters #175: FILE: drivers/net/atlantic/atl_rxtx.c:257: + "greater than or equal to %d", AQ_HW_MAX_TX_RING_SIZE, AQ_HW_MIN_TX_RING_SIZE); WARNING:LONG_LINE: line over 90 characters #190: FILE: drivers/net/atlantic/atl_rxtx.c:272: + txq = rte_zmalloc_socket("atlantic Tx queue", sizeof(*txq), RTE_CACHE_LINE_SIZE, socket_id); ERROR:SPACING: spaces required around that '=' (ctx:WxV) #247: FILE: drivers/net/atlantic/atl_rxtx.c:329: + for (i =0 ; i < eth_dev->data->nb_tx_queues; i++) { ^ WARNING:LONG_LINE: line over 90 characters #251: FILE: drivers/net/atlantic/atl_rxtx.c:333: + err = hw_atl_b0_hw_ring_tx_init(hw, base_addr, txq->queue_id, txq->nb_tx_desc, 0, txq->port_id); CHECK:BRACES: Blank lines aren't necessary after an open brace '{' #323: FILE: drivers/net/atlantic/atl_rxtx.c:553: +{ + WARNING:LONG_LINE: line over 90 characters #383: FILE: drivers/net/atlantic/atl_rxtx.c:648: +atl_txq_info_get(struct rte_eth_dev *dev, uint16_t queue_id, struct rte_eth_txq_info *qinfo) ERROR:TRAILING_WHITESPACE: trailing whitespace #481: FILE: drivers/net/atlantic/atl_rxtx.c:1094: +static void $ WARNING:BRACES: braces {} are not necessary for single statement blocks #520: FILE: drivers/net/atlantic/atl_rxtx.c:1133: + if (txd->dd) { + to_clean--; + } ERROR:TRAILING_WHITESPACE: trailing whitespace #545: FILE: drivers/net/atlantic/atl_rxtx.c:1158: +^I$ WARNING:BRACES: braces {} are not necessary for single statement blocks #626: FILE: drivers/net/atlantic/atl_rxtx.c:1239: + if (tx_cmd) { + txd->ct_idx = 0; + } ERROR:TRAILING_WHITESPACE: trailing whitespace #633: FILE: drivers/net/atlantic/atl_rxtx.c:1246: +^I$ WARNING:LONG_LINE: line over 90 characters #700: FILE: drivers/net/atlantic/atl_rxtx.c:1313: + if ((tx_pkt->nb_segs == 0) || ((tx_pkt->nb_segs > 1) && (tx_pkt->next == NULL))) CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses around 'tx_pkt->nb_segs == 0' #700: FILE: drivers/net/atlantic/atl_rxtx.c:1313: + if ((tx_pkt->nb_segs == 0) || ((tx_pkt->nb_segs > 1) && (tx_pkt->next == NULL))) CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses around 'tx_pkt->nb_segs > 1' #700: FILE: drivers/net/atlantic/atl_rxtx.c:1313: + if ((tx_pkt->nb_segs == 0) || ((tx_pkt->nb_segs > 1) && (tx_pkt->next == NULL))) CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses around 'tx_pkt->next == NULL' #700: FILE: drivers/net/atlantic/atl_rxtx.c:1313: + if ((tx_pkt->nb_segs == 0) || ((tx_pkt->nb_segs > 1) && (tx_pkt->next == NULL))) WARNING:EMBEDDED_FUNCTION_NAME: Prefer using '"%s...", __func__' to using 'atl_xmit_pkts', this function's name, in a string #707: FILE: drivers/net/atlantic/atl_rxtx.c:1320: + PMD_TX_LOG(DEBUG, "atl_xmit_pkts %d transmitted", nb_tx); total: 4 errors, 8 warnings, 4 checks, 663 lines checked