From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: by dpdk.org (Postfix, from userid 1017) id DA3675B12; Fri, 7 Sep 2018 19:17:05 +0200 (CEST) In-Reply-To: <20180907171311.20371-2-marko.kovacevic@intel.com> References: <20180907171311.20371-2-marko.kovacevic@intel.com> To: test-report@dpdk.org Cc: Marko Kovacevic Message-Id: <20180907171705.DA3675B12@dpdk.org> Date: Fri, 7 Sep 2018 19:17:05 +0200 (CEST) From: checkpatch@dpdk.org Subject: [dpdk-test-report] |WARNING| pw44426 [v1, 1/2] test/test: cryptodev application for FIPS certification X-BeenThere: test-report@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: automatic DPDK test reports List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 07 Sep 2018 17:17:06 -0000 Test-Label: checkpatch Test-Status: WARNING http://dpdk.org/patch/44426 _coding style issues_ WARNING:LONG_LINE: line over 90 characters #156: FILE: test/test/test_cryptodev_fips.c:111: + ts_params->enabled_devs[ts_params->nb_enabled_devs] = dev_id; WARNING:LONG_LINE: line over 90 characters #196: FILE: test/test/test_cryptodev_fips.c:151: + ts_params->enabled_devs[ts_params->nb_enabled_devs] = dev_id; WARNING:BRACES: braces {} are not necessary for single statement blocks #280: FILE: test/test/test_cryptodev_fips.c:235: + for (i = 0; i < ts_params->nb_enabled_devs; i++) { + rte_cryptodev_stop(ts_params->enabled_devs[i]); + } WARNING:LONG_LINE: line over 90 characters #476: FILE: test/test/test_cryptodev_fips.c:431: + memcpy(prev_in, rte_pktmbuf_mtod(mbuf, uint8_t *), AES_BLOCK_LENGTH); WARNING:LONG_LINE: line over 90 characters #488: FILE: test/test/test_cryptodev_fips.c:443: + num_deqd = rte_cryptodev_dequeue_burst(dev_id, 0, &deqd_op, 1); WARNING:LONG_LINE: line over 90 characters #505: FILE: test/test/test_cryptodev_fips.c:460: + if (aes_data->test_cases[vid].test_op == RTE_CRYPTO_CIPHER_OP_ENCRYPT) { WARNING:LONG_LINE_COMMENT: line over 90 characters #506: FILE: test/test/test_cryptodev_fips.c:461: + /* PT[j+1] = CT[j-1] (CT[j-1] stored in prev_out, store CT[j]) */ WARNING:LONG_LINE_COMMENT: line over 90 characters #514: FILE: test/test/test_cryptodev_fips.c:469: + /* CT[j+1] = PT[j-1] (PT[j-1] stored in prev_out, store PT[j]) */ WARNING:BRACES: braces {} are not necessary for single statement blocks #588: FILE: test/test/test_cryptodev_fips.c:543: + if (rte_cryptodev_sym_capability_get(dev_id, &cap_idx) != NULL) { + break; + } ERROR:SPACING: need consistent spacing around '*' (ctx:WxV) #598: FILE: test/test/test_cryptodev_fips.c:553: + DIR *d; ^ WARNING:LONG_LINE: line over 90 characters #651: FILE: test/test/test_cryptodev_fips.c:606: + aes_mct_data->test_cases[mct_vec_id].count = (aes_data->test_cases[j].count * AES_MCT_NUM_EXTERNAL_ITER) + k; WARNING:LONG_LINE: line over 90 characters #664: FILE: test/test/test_cryptodev_fips.c:619: + aes_mct_data->test_cases[mct_vec_id].test_op = aes_data->test_cases[j].test_op; WARNING:LONG_LINE: line over 90 characters #665: FILE: test/test/test_cryptodev_fips.c:620: + aes_mct_data->test_cases[mct_vec_id].iv_len = aes_data->test_cases[j].iv_len; WARNING:LONG_LINE: line over 90 characters #666: FILE: test/test/test_cryptodev_fips.c:621: + aes_mct_data->test_cases[mct_vec_id].count = mct_vec_id; WARNING:LONG_LINE: line over 90 characters #667: FILE: test/test/test_cryptodev_fips.c:622: + if (aes_data->test_cases[j].test_op == RTE_CRYPTO_CIPHER_OP_ENCRYPT) { WARNING:DEEP_INDENTATION: Too many leading tabs - consider code refactoring #667: FILE: test/test/test_cryptodev_fips.c:622: + if (aes_data->test_cases[j].test_op == RTE_CRYPTO_CIPHER_OP_ENCRYPT) { WARNING:LONG_LINE: line over 90 characters #668: FILE: test/test/test_cryptodev_fips.c:623: + aes_mct_data->test_cases[mct_vec_id].plaintext_len = aes_data->test_cases[j].plaintext_len; WARNING:DEEP_INDENTATION: Too many leading tabs - consider code refactoring #669: FILE: test/test/test_cryptodev_fips.c:624: + if (aes_data->key_len == 16) { WARNING:LONG_LINE: line over 90 characters #670: FILE: test/test/test_cryptodev_fips.c:625: + for (m = 0; m < aes_data->key_len; m++) { WARNING:DEEP_INDENTATION: Too many leading tabs - consider code refactoring #670: FILE: test/test/test_cryptodev_fips.c:625: + for (m = 0; m < aes_data->key_len; m++) { WARNING:LONG_LINE_COMMENT: line over 90 characters #671: FILE: test/test/test_cryptodev_fips.c:626: + /* Key[i+1] = Key[i] xor CT[j] */ WARNING:LONG_LINE: line over 90 characters #672: FILE: test/test/test_cryptodev_fips.c:627: + aes_mct_data->test_cases[mct_vec_id].key[m] = WARNING:LONG_LINE: line over 90 characters #673: FILE: test/test/test_cryptodev_fips.c:628: + aes_mct_data->test_cases[mct_vec_id - 1].key[m] ^ WARNING:LONG_LINE: line over 90 characters #674: FILE: test/test/test_cryptodev_fips.c:629: + aes_mct_data->test_cases[mct_vec_id - 1].ciphertext[m]; WARNING:LONG_LINE: line over 90 characters #676: FILE: test/test/test_cryptodev_fips.c:631: + } else if (aes_data->key_len == 24) { WARNING:DEEP_INDENTATION: Too many leading tabs - consider code refactoring #676: FILE: test/test/test_cryptodev_fips.c:631: + } else if (aes_data->key_len == 24) { WARNING:LONG_LINE_COMMENT: line over 90 characters #677: FILE: test/test/test_cryptodev_fips.c:632: + /* Key[i+1] = Key[i] xor (last 64-bits of CT[j-1] || CT[j]) */ WARNING:DEEP_INDENTATION: Too many leading tabs - consider code refactoring #678: FILE: test/test/test_cryptodev_fips.c:633: + for (m = 0; m < 8; m++) WARNING:LONG_LINE: line over 90 characters #679: FILE: test/test/test_cryptodev_fips.c:634: + aes_mct_data->test_cases[mct_vec_id].key[m] = WARNING:LONG_LINE: line over 90 characters #680: FILE: test/test/test_cryptodev_fips.c:635: + aes_mct_data->test_cases[mct_vec_id - 1].key[m] ^ WARNING:LONG_LINE: line over 90 characters #681: FILE: test/test/test_cryptodev_fips.c:636: + second_last_out[m + 8]; WARNING:LONG_LINE: line over 90 characters #682: FILE: test/test/test_cryptodev_fips.c:637: + for (m = 8; m < aes_data->key_len; m++) WARNING:DEEP_INDENTATION: Too many leading tabs - consider code refactoring #682: FILE: test/test/test_cryptodev_fips.c:637: + for (m = 8; m < aes_data->key_len; m++) WARNING:LONG_LINE: line over 90 characters #683: FILE: test/test/test_cryptodev_fips.c:638: + aes_mct_data->test_cases[mct_vec_id].key[m] = WARNING:LONG_LINE: line over 90 characters #684: FILE: test/test/test_cryptodev_fips.c:639: + aes_mct_data->test_cases[mct_vec_id - 1].key[m] ^ WARNING:LONG_LINE: line over 90 characters #685: FILE: test/test/test_cryptodev_fips.c:640: + aes_mct_data->test_cases[mct_vec_id - 1].ciphertext[m - 8]; WARNING:DEEP_INDENTATION: Too many leading tabs - consider code refactoring #686: FILE: test/test/test_cryptodev_fips.c:641: + } else { WARNING:LONG_LINE_COMMENT: line over 90 characters #687: FILE: test/test/test_cryptodev_fips.c:642: + /* Key[i+1] = Key[i] xor (CT[j-1] || CT[j]) */ WARNING:DEEP_INDENTATION: Too many leading tabs - consider code refactoring #688: FILE: test/test/test_cryptodev_fips.c:643: + for (m = 0; m < 16; m++) WARNING:LONG_LINE: line over 90 characters #689: FILE: test/test/test_cryptodev_fips.c:644: + aes_mct_data->test_cases[mct_vec_id].key[m] = WARNING:LONG_LINE: line over 90 characters #690: FILE: test/test/test_cryptodev_fips.c:645: + aes_mct_data->test_cases[mct_vec_id - 1].key[m] ^ WARNING:LONG_LINE: line over 90 characters #691: FILE: test/test/test_cryptodev_fips.c:646: + second_last_out[m]; WARNING:LONG_LINE: line over 90 characters #692: FILE: test/test/test_cryptodev_fips.c:647: + for (m = 16; m < aes_data->key_len; m++) WARNING:DEEP_INDENTATION: Too many leading tabs - consider code refactoring #692: FILE: test/test/test_cryptodev_fips.c:647: + for (m = 16; m < aes_data->key_len; m++) WARNING:LONG_LINE: line over 90 characters #693: FILE: test/test/test_cryptodev_fips.c:648: + aes_mct_data->test_cases[mct_vec_id].key[m] = WARNING:LONG_LINE: line over 90 characters #694: FILE: test/test/test_cryptodev_fips.c:649: + aes_mct_data->test_cases[mct_vec_id - 1].key[m] ^ WARNING:LONG_LINE: line over 90 characters #695: FILE: test/test/test_cryptodev_fips.c:650: + aes_mct_data->test_cases[mct_vec_id - 1].ciphertext[m - 16]; WARNING:LONG_LINE: line over 90 characters #699: FILE: test/test/test_cryptodev_fips.c:654: + memcpy(aes_mct_data->test_cases[mct_vec_id].iv, WARNING:LONG_LINE: line over 90 characters #700: FILE: test/test/test_cryptodev_fips.c:655: + aes_mct_data->test_cases[mct_vec_id - 1].ciphertext, WARNING:LONG_LINE: line over 90 characters #703: FILE: test/test/test_cryptodev_fips.c:658: + memcpy(aes_mct_data->test_cases[mct_vec_id].plaintext, WARNING:LONG_LINE: line over 90 characters #704: FILE: test/test/test_cryptodev_fips.c:659: + second_last_out, AES_BLOCK_LENGTH); WARNING:DEEP_INDENTATION: Too many leading tabs - consider code refactoring #705: FILE: test/test/test_cryptodev_fips.c:660: + } else { WARNING:LONG_LINE: line over 90 characters #706: FILE: test/test/test_cryptodev_fips.c:661: + aes_mct_data->test_cases[mct_vec_id].ciphertext_len = aes_data->test_cases[j].ciphertext_len; WARNING:DEEP_INDENTATION: Too many leading tabs - consider code refactoring #707: FILE: test/test/test_cryptodev_fips.c:662: + if (aes_data->key_len == 16) { WARNING:LONG_LINE: line over 90 characters #708: FILE: test/test/test_cryptodev_fips.c:663: + for (m = 0; m < aes_data->key_len; m++) { WARNING:DEEP_INDENTATION: Too many leading tabs - consider code refactoring #708: FILE: test/test/test_cryptodev_fips.c:663: + for (m = 0; m < aes_data->key_len; m++) { WARNING:LONG_LINE_COMMENT: line over 90 characters #709: FILE: test/test/test_cryptodev_fips.c:664: + /* Key[i+1] = Key[i] xor PT[j] */ WARNING:LONG_LINE: line over 90 characters #710: FILE: test/test/test_cryptodev_fips.c:665: + aes_mct_data->test_cases[mct_vec_id].key[m] = WARNING:LONG_LINE: line over 90 characters #711: FILE: test/test/test_cryptodev_fips.c:666: + aes_mct_data->test_cases[mct_vec_id - 1].key[m] ^ WARNING:LONG_LINE: line over 90 characters #712: FILE: test/test/test_cryptodev_fips.c:667: + aes_mct_data->test_cases[mct_vec_id - 1].plaintext[m]; WARNING:LONG_LINE: line over 90 characters #714: FILE: test/test/test_cryptodev_fips.c:669: + } else if (aes_data->key_len == 24) { WARNING:DEEP_INDENTATION: Too many leading tabs - consider code refactoring #714: FILE: test/test/test_cryptodev_fips.c:669: + } else if (aes_data->key_len == 24) { WARNING:LONG_LINE_COMMENT: line over 90 characters #715: FILE: test/test/test_cryptodev_fips.c:670: + /* Key[i+1] = Key[i] xor (last 64-bits of PT[j-1] || PT[j]) */ WARNING:DEEP_INDENTATION: Too many leading tabs - consider code refactoring #716: FILE: test/test/test_cryptodev_fips.c:671: + for (m = 0; m < 8; m++) WARNING:LONG_LINE: line over 90 characters #717: FILE: test/test/test_cryptodev_fips.c:672: + aes_mct_data->test_cases[mct_vec_id].key[m] = WARNING:LONG_LINE: line over 90 characters #718: FILE: test/test/test_cryptodev_fips.c:673: + aes_mct_data->test_cases[mct_vec_id - 1].key[m] ^ WARNING:LONG_LINE: line over 90 characters #719: FILE: test/test/test_cryptodev_fips.c:674: + second_last_out[m + 8]; WARNING:LONG_LINE: line over 90 characters #720: FILE: test/test/test_cryptodev_fips.c:675: + for (m = 8; m < aes_data->key_len; m++) WARNING:DEEP_INDENTATION: Too many leading tabs - consider code refactoring #720: FILE: test/test/test_cryptodev_fips.c:675: + for (m = 8; m < aes_data->key_len; m++) WARNING:LONG_LINE: line over 90 characters #721: FILE: test/test/test_cryptodev_fips.c:676: + aes_mct_data->test_cases[mct_vec_id].key[m] = WARNING:LONG_LINE: line over 90 characters #722: FILE: test/test/test_cryptodev_fips.c:677: + aes_mct_data->test_cases[mct_vec_id - 1].key[m] ^ WARNING:LONG_LINE: line over 90 characters #723: FILE: test/test/test_cryptodev_fips.c:678: + aes_mct_data->test_cases[mct_vec_id - 1].plaintext[m - 8]; WARNING:DEEP_INDENTATION: Too many leading tabs - consider code refactoring #724: FILE: test/test/test_cryptodev_fips.c:679: + } else { WARNING:LONG_LINE_COMMENT: line over 90 characters #725: FILE: test/test/test_cryptodev_fips.c:680: + /* Key[i+1] = Key[i] xor (PT[j-1] || PT[j]) */ WARNING:DEEP_INDENTATION: Too many leading tabs - consider code refactoring #726: FILE: test/test/test_cryptodev_fips.c:681: + for (m = 0; m < 16; m++) WARNING:LONG_LINE: line over 90 characters #727: FILE: test/test/test_cryptodev_fips.c:682: + aes_mct_data->test_cases[mct_vec_id].key[m] = WARNING:LONG_LINE: line over 90 characters #728: FILE: test/test/test_cryptodev_fips.c:683: + aes_mct_data->test_cases[mct_vec_id - 1].key[m] ^ WARNING:LONG_LINE: line over 90 characters #729: FILE: test/test/test_cryptodev_fips.c:684: + second_last_out[m]; WARNING:LONG_LINE: line over 90 characters #730: FILE: test/test/test_cryptodev_fips.c:685: + for (m = 16; m < aes_data->key_len; m++) WARNING:DEEP_INDENTATION: Too many leading tabs - consider code refactoring #730: FILE: test/test/test_cryptodev_fips.c:685: + for (m = 16; m < aes_data->key_len; m++) WARNING:LONG_LINE: line over 90 characters #731: FILE: test/test/test_cryptodev_fips.c:686: + aes_mct_data->test_cases[mct_vec_id].key[m] = WARNING:LONG_LINE: line over 90 characters #732: FILE: test/test/test_cryptodev_fips.c:687: + aes_mct_data->test_cases[mct_vec_id - 1].key[m] ^ WARNING:LONG_LINE: line over 90 characters #733: FILE: test/test/test_cryptodev_fips.c:688: + aes_mct_data->test_cases[mct_vec_id - 1].plaintext[m - 16]; WARNING:LONG_LINE: line over 90 characters #736: FILE: test/test/test_cryptodev_fips.c:691: + memcpy(aes_mct_data->test_cases[mct_vec_id].iv, WARNING:LONG_LINE: line over 90 characters #737: FILE: test/test/test_cryptodev_fips.c:692: + aes_mct_data->test_cases[mct_vec_id - 1].plaintext, WARNING:LONG_LINE: line over 90 characters #740: FILE: test/test/test_cryptodev_fips.c:695: + memcpy(aes_mct_data->test_cases[mct_vec_id].ciphertext, WARNING:LONG_LINE: line over 90 characters #741: FILE: test/test/test_cryptodev_fips.c:696: + second_last_out, AES_BLOCK_LENGTH); total: 1 errors, 86 warnings, 778 lines checked