From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <checkpatch@dpdk.org>
Received: by dpdk.org (Postfix, from userid 1017)
 id A9E874F9C; Mon, 10 Sep 2018 11:35:14 +0200 (CEST)
In-Reply-To: <1536572016-18134-25-git-send-email-arybchenko@solarflare.com>
References: <1536572016-18134-25-git-send-email-arybchenko@solarflare.com>
To: test-report@dpdk.org
Cc: Andrew Rybchenko <arybchenko@solarflare.com>
Message-Id: <20180910093514.A9E874F9C@dpdk.org>
Date: Mon, 10 Sep 2018 11:35:14 +0200 (CEST)
From: checkpatch@dpdk.org
Subject: [dpdk-test-report] |WARNING| pw44487 [24/37] net/sfc/base: add
	routine to check for hardware presence
X-BeenThere: test-report@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: automatic DPDK test reports <test-report.dpdk.org>
List-Unsubscribe: <https://mails.dpdk.org/options/test-report>,
 <mailto:test-report-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://mails.dpdk.org/archives/test-report/>
List-Post: <mailto:test-report@dpdk.org>
List-Help: <mailto:test-report-request@dpdk.org?subject=help>
List-Subscribe: <https://mails.dpdk.org/listinfo/test-report>,
 <mailto:test-report-request@dpdk.org?subject=subscribe>
X-List-Received-Date: Mon, 10 Sep 2018 09:35:14 -0000

Test-Label: checkpatch
Test-Status: WARNING
http://dpdk.org/patch/44487

_coding style issues_


CHECK:CAMELCASE: Avoid CamelCase: <__checkReturn>
#69: FILE: drivers/net/sfc/base/ef10_impl.h:193:
+extern	__checkReturn	boolean_t

CHECK:OPEN_ENDED_LINE: Lines should not end with a '('
#70: FILE: drivers/net/sfc/base/ef10_impl.h:194:
+ef10_nic_hw_unavailable(

CHECK:OPEN_ENDED_LINE: Lines should not end with a '('
#85: FILE: drivers/net/sfc/base/ef10_nic.c:2308:
+ef10_nic_hw_unavailable(

ERROR:RETURN_PARENTHESES: return is not a function, parentheses are not required
#97: FILE: drivers/net/sfc/base/ef10_nic.c:2320:
+	return (B_FALSE);

ERROR:RETURN_PARENTHESES: return is not a function, parentheses are not required
#103: FILE: drivers/net/sfc/base/ef10_nic.c:2326:
+	return (B_TRUE);

CHECK:OPEN_ENDED_LINE: Lines should not end with a '('
#118: FILE: drivers/net/sfc/base/efx.h:159:
+efx_nic_hw_unavailable(

WARNING:FUNCTION_ARGUMENTS: function definition argument 'efx_nic_t *' should also have an identifier name
#140: FILE: drivers/net/sfc/base/efx_impl.h:360:
+	boolean_t	(*eno_hw_unavailable)(efx_nic_t *);

ERROR:RETURN_PARENTHESES: return is not a function, parentheses are not required
#155: FILE: drivers/net/sfc/base/efx_mcdi.c:502:
+		return (B_FALSE);

CHECK:OPEN_ENDED_LINE: Lines should not end with a '('
#202: FILE: drivers/net/sfc/base/efx_nic.c:660:
+efx_nic_hw_unavailable(

CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses around function pointer (enop->eno_hw_unavailable)
#211: FILE: drivers/net/sfc/base/efx_nic.c:669:
+		if ((enop->eno_hw_unavailable)(enp) != B_FALSE)

CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses around 'enop->eno_hw_unavailable'
#211: FILE: drivers/net/sfc/base/efx_nic.c:669:
+		if ((enop->eno_hw_unavailable)(enp) != B_FALSE)

ERROR:RETURN_PARENTHESES: return is not a function, parentheses are not required
#220: FILE: drivers/net/sfc/base/efx_nic.c:678:
+	return (B_TRUE);

total: 4 errors, 1 warnings, 7 checks, 153 lines checked