[dpdk-test-report] |WARNING| pw44488 [17/37] net/sfc/base: add API to retrieve sensor limits

[dpdk-test-report] |WARNING| pw44488 [17/37] net/sfc/base: add API to retrieve sensor limits

[checkpatch]

Test-Label: checkpatch
Test-Status: WARNING
http://dpdk.org/patch/44488

_coding style issues_


CHECK:CAMELCASE: Avoid CamelCase: <__checkReturn>
#50: FILE: drivers/net/sfc/base/efx.h:829:
+extern	__checkReturn			efx_rc_t

CHECK:OPEN_ENDED_LINE: Lines should not end with a '('
#51: FILE: drivers/net/sfc/base/efx.h:830:
+efx_mon_limits_update(

WARNING:FUNCTION_ARGUMENTS: function definition argument 'efx_nic_t *' should also have an identifier name
#66: FILE: drivers/net/sfc/base/efx_impl.h:320:
+	efx_rc_t	(*emo_limits_update)(efx_nic_t *,

WARNING:FUNCTION_ARGUMENTS: function definition argument 'efx_mon_stat_limits_t *' should also have an identifier name
#66: FILE: drivers/net/sfc/base/efx_impl.h:320:
+	efx_rc_t	(*emo_limits_update)(efx_nic_t *,

CHECK:OPEN_ENDED_LINE: Lines should not end with a '('
#90: FILE: drivers/net/sfc/base/efx_mon.c:820:
+efx_mon_limits_update(

CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses around enp->en_mon
#94: FILE: drivers/net/sfc/base/efx_mon.c:824:
+	efx_mon_t *emp = &(enp->en_mon);

ERROR:RETURN_PARENTHESES: return is not a function, parentheses are not required
#100: FILE: drivers/net/sfc/base/efx_mon.c:830:
+	return (emop->emo_limits_update(enp, values));

CHECK:OPEN_ENDED_LINE: Lines should not end with a '('
#115: FILE: drivers/net/sfc/base/mcdi_mon.c:338:
+efx_mcdi_sensor_info_page(

WARNING:SPACING: space prohibited between function name and open parenthesis '('
#119: FILE: drivers/net/sfc/base/mcdi_mon.c:342:
+	__out_ecount((sizeof (*mask_part) * 8) - 1)

WARNING:SPACING: space prohibited between function name and open parenthesis '('
#134: FILE: drivers/net/sfc/base/mcdi_mon.c:357:
+	    ((sizeof (*mask_part) * 8) - 1) * sizeof (efx_mon_stat_limits_t));

WARNING:SPACING: space prohibited between function name and open parenthesis '('
#134: FILE: drivers/net/sfc/base/mcdi_mon.c:357:
+	    ((sizeof (*mask_part) * 8) - 1) * sizeof (efx_mon_stat_limits_t));

CHECK:SPACING: No space is necessary after a cast
#136: FILE: drivers/net/sfc/base/mcdi_mon.c:359:
+	(void) memset(payload, 0, sizeof (payload));

WARNING:SPACING: space prohibited between function name and open parenthesis '('
#136: FILE: drivers/net/sfc/base/mcdi_mon.c:359:
+	(void) memset(payload, 0, sizeof (payload));

WARNING:SPACING: space prohibited between function name and open parenthesis '('
#152: FILE: drivers/net/sfc/base/mcdi_mon.c:375:
+	EFSYS_ASSERT(sizeof (*limit_info) ==

CHECK:BRACES: Blank lines aren't necessary after an open brace '{'
#162: FILE: drivers/net/sfc/base/mcdi_mon.c:385:
+	while (mask_copy) {
+

ERROR:RETURN_PARENTHESES: return is not a function, parentheses are not required
#192: FILE: drivers/net/sfc/base/mcdi_mon.c:415:
+	return (rc);

ERROR:RETURN_PARENTHESES: return is not a function, parentheses are not required
#205: FILE: drivers/net/sfc/base/mcdi_mon.c:443:
+	return (rc);

CHECK:OPEN_ENDED_LINE: Lines should not end with a '('
#209: FILE: drivers/net/sfc/base/mcdi_mon.c:447:
+lowest_set_bit(

CHECK:OPEN_ENDED_LINE: Lines should not end with a '('
#240: FILE: drivers/net/sfc/base/mcdi_mon.c:478:
+mcdi_mon_limits_update(

WARNING:SPACING: space prohibited between function name and open parenthesis '('
#248: FILE: drivers/net/sfc/base/mcdi_mon.c:486:
+	efx_mon_stat_limits_t limits[sizeof (page_mask) * 8];

WARNING:SPACING: space prohibited between function name and open parenthesis '('
#273: FILE: drivers/net/sfc/base/mcdi_mon.c:511:
+			    page_index + (sizeof (page_mask) * 8 * page);

ERROR:RETURN_PARENTHESES: return is not a function, parentheses are not required
#290: FILE: drivers/net/sfc/base/mcdi_mon.c:528:
+	return (rc);

CHECK:OPEN_ENDED_LINE: Lines should not end with a '('
#304: FILE: drivers/net/sfc/base/mcdi_mon.h:43:
+mcdi_mon_limits_update(

total: 4 errors, 9 warnings, 10 checks, 255 lines checked