From: checkpatch@dpdk.org
To: test-report@dpdk.org
Cc: Andrew Rybchenko <arybchenko@solarflare.com>
Subject: [dpdk-test-report] |WARNING| pw44489 [20/37] net/sfc/base: generalise EF10 NVRAM buffer interface
Date: Mon, 10 Sep 2018 11:38:37 +0200 (CEST) [thread overview]
Message-ID: <20180910093837.404F94F91@dpdk.org> (raw)
In-Reply-To: <1536572016-18134-21-git-send-email-arybchenko@solarflare.com>
Test-Label: checkpatch
Test-Status: WARNING
http://dpdk.org/patch/44489
_coding style issues_
CHECK:OPEN_ENDED_LINE: Lines should not end with a '('
#50: FILE: drivers/net/sfc/base/ef10_impl.h:486:
+ef10_nvram_buffer_init(
CHECK:CAMELCASE: Avoid CamelCase: <__checkReturn>
#69: FILE: drivers/net/sfc/base/ef10_impl.h:522:
+extern __checkReturn efx_rc_t
CHECK:OPEN_ENDED_LINE: Lines should not end with a '('
#70: FILE: drivers/net/sfc/base/ef10_impl.h:523:
+ef10_nvram_buffer_peek_item(
CHECK:OPEN_ENDED_LINE: Lines should not end with a '('
#107: FILE: drivers/net/sfc/base/ef10_impl.h:557:
+ef10_nvram_buffer_modify_item(
CHECK:OPEN_ENDED_LINE: Lines should not end with a '('
#212: FILE: drivers/net/sfc/base/ef10_nvram.c:741:
+ef10_nvram_buffer_init(
ERROR:ASSIGN_IN_IF: do not use assignment in if condition
#251: FILE: drivers/net/sfc/base/ef10_nvram.c:806:
+ if ((rc = ef10_nvram_buffer_validate(partn_type,
CHECK:OPEN_ENDED_LINE: Lines should not end with a '('
#260: FILE: drivers/net/sfc/base/ef10_nvram.c:978:
+ef10_nvram_buffer_peek_item(
ERROR:ASSIGN_IN_IF: do not use assignment in if condition
#273: FILE: drivers/net/sfc/base/ef10_nvram.c:991:
+ if ((rc = tlv_init_cursor_at_offset(&cursor, (uint8_t *)bufferp,
WARNING:SPACING: space prohibited between function name and open parenthesis '('
#285: FILE: drivers/net/sfc/base/ef10_nvram.c:1003:
+ *lengthp = sizeof (tag);
WARNING:SPACING: space prohibited between function name and open parenthesis '('
#286: FILE: drivers/net/sfc/base/ef10_nvram.c:1004:
+ *value_offsetp = sizeof (tag);
ERROR:RETURN_PARENTHESES: return is not a function, parentheses are not required
#298: FILE: drivers/net/sfc/base/ef10_nvram.c:1016:
+ return (rc);
ERROR:RETURN_PARENTHESES: return is not a function, parentheses are not required
#370: FILE: drivers/net/sfc/base/ef10_nvram.c:1095:
+ return (0);
ERROR:RETURN_PARENTHESES: return is not a function, parentheses are not required
#377: FILE: drivers/net/sfc/base/ef10_nvram.c:1102:
+ return (rc);
CHECK:OPEN_ENDED_LINE: Lines should not end with a '('
#381: FILE: drivers/net/sfc/base/ef10_nvram.c:1106:
+ef10_nvram_buffer_modify_item(
ERROR:ASSIGN_IN_IF: do not use assignment in if condition
#394: FILE: drivers/net/sfc/base/ef10_nvram.c:1119:
+ if ((rc = tlv_init_cursor_at_offset(&cursor, (uint8_t *)bufferp,
WARNING:FUNCTION_ARGUMENTS: function definition argument 'uint32_t' should also have an identifier name
#420: FILE: drivers/net/sfc/base/efx_impl.h:512:
+ efx_rc_t (*envo_buffer_validate)(uint32_t,
WARNING:FUNCTION_ARGUMENTS: function definition argument 'caddr_t' should also have an identifier name
#420: FILE: drivers/net/sfc/base/efx_impl.h:512:
+ efx_rc_t (*envo_buffer_validate)(uint32_t,
WARNING:FUNCTION_ARGUMENTS: function definition argument 'size_t' should also have an identifier name
#420: FILE: drivers/net/sfc/base/efx_impl.h:512:
+ efx_rc_t (*envo_buffer_validate)(uint32_t,
CHECK:OPEN_ENDED_LINE: Lines should not end with a '('
#459: FILE: drivers/net/sfc/base/efx_lic.c:1229:
+ if ((rc = ef10_nvram_buffer_create(
ERROR:ASSIGN_IN_IF: do not use assignment in if condition
#459: FILE: drivers/net/sfc/base/efx_lic.c:1229:
+ if ((rc = ef10_nvram_buffer_create(
CHECK:OPEN_ENDED_LINE: Lines should not end with a '('
#476: FILE: drivers/net/sfc/base/efx_lic.c:1261:
+ if ((rc = ef10_nvram_buffer_validate(
ERROR:ASSIGN_IN_IF: do not use assignment in if condition
#476: FILE: drivers/net/sfc/base/efx_lic.c:1261:
+ if ((rc = ef10_nvram_buffer_validate(
ERROR:ASSIGN_IN_IF: do not use assignment in if condition
#490: FILE: drivers/net/sfc/base/efx_nvram.c:471:
+ if ((rc = envop->envo_buffer_validate(partn,
total: 9 errors, 5 warnings, 9 checks, 415 lines checked
parent reply other threads:[~2018-09-10 9:38 UTC|newest]
Thread overview: expand[flat|nested] mbox.gz Atom feed
[parent not found: <1536572016-18134-21-git-send-email-arybchenko@solarflare.com>]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180910093837.404F94F91@dpdk.org \
--to=checkpatch@dpdk.org \
--cc=arybchenko@solarflare.com \
--cc=test-report@dpdk.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).