[dpdk-test-report] |WARNING| pw44493 [18/37] net/sfc/base: add buffer editing functions to boot config

[dpdk-test-report] |WARNING| pw44493 [18/37] net/sfc/base: add buffer editing functions to boot config

[checkpatch]

Test-Label: checkpatch
Test-Status: WARNING
http://dpdk.org/patch/44493

_coding style issues_


WARNING:LEADING_SPACE: please, no spaces at the start of a line
#71: FILE: drivers/net/sfc/base/efx.h:1694:
+  (uint16_t)(((encapsulator) << 8) | (encapsulated))$

CHECK:CAMELCASE: Avoid CamelCase: <__checkReturn>
#73: FILE: drivers/net/sfc/base/efx.h:1696:
+extern	__checkReturn		uint8_t

CHECK:OPEN_ENDED_LINE: Lines should not end with a '('
#74: FILE: drivers/net/sfc/base/efx.h:1697:
+efx_dhcp_csum(

CHECK:OPEN_ENDED_LINE: Lines should not end with a '('
#79: FILE: drivers/net/sfc/base/efx.h:1702:
+efx_dhcp_verify(

CHECK:OPEN_ENDED_LINE: Lines should not end with a '('
#85: FILE: drivers/net/sfc/base/efx.h:1708:
+efx_dhcp_find_tag(

CHECK:OPEN_ENDED_LINE: Lines should not end with a '('
#93: FILE: drivers/net/sfc/base/efx.h:1716:
+efx_dhcp_find_end(

CHECK:OPEN_ENDED_LINE: Lines should not end with a '('
#100: FILE: drivers/net/sfc/base/efx.h:1723:
+efx_dhcp_delete_tag(

CHECK:OPEN_ENDED_LINE: Lines should not end with a '('
#106: FILE: drivers/net/sfc/base/efx.h:1729:
+efx_dhcp_add_tag(

CHECK:OPEN_ENDED_LINE: Lines should not end with a '('
#114: FILE: drivers/net/sfc/base/efx.h:1737:
+efx_dhcp_update_tag(

CHECK:MACRO_ARG_REUSE: Macro argument reuse 'opt' - possible side-effects?
#148: FILE: drivers/net/sfc/base/efx_bootcfg.c:22:
+#define	DHCP_OPT_HAS_VALUE(opt) \
+	(((opt) > EFX_DHCP_PAD) && ((opt) < EFX_DHCP_END))

WARNING:SPACING: space prohibited between function name and open parenthesis '('
#167: FILE: drivers/net/sfc/base/efx_bootcfg.c:41:
+	(sizeof (efx_dhcp_tag_hdr_t) + (hdr)->length)

CHECK:MACRO_ARG_REUSE: Macro argument reuse 'hdr' - possible side-effects?
#169: FILE: drivers/net/sfc/base/efx_bootcfg.c:43:
+#define	DHCP_NEXT_TAG(hdr) \
+	((efx_dhcp_tag_hdr_t *)(((uint8_t *)(hdr)) + \
+	DHCP_FULL_TAG_LENGTH((hdr))))

WARNING:SPACING: space prohibited between function name and open parenthesis '('
#174: FILE: drivers/net/sfc/base/efx_bootcfg.c:48:
+	((payload_len) + sizeof (efx_dhcp_tag_hdr_t))

CHECK:OPEN_ENDED_LINE: Lines should not end with a '('
#186: FILE: drivers/net/sfc/base/efx_bootcfg.c:139:
+efx_dhcp_csum(

CHECK:OPEN_ENDED_LINE: Lines should not end with a '('
#203: FILE: drivers/net/sfc/base/efx_bootcfg.c:152:
+efx_dhcp_verify(

CHECK:OPEN_ENDED_LINE: Lines should not end with a '('
#244: FILE: drivers/net/sfc/base/efx_bootcfg.c:223:
+efx_dhcp_walk_tags(

WARNING:SPACING: space prohibited between function name and open parenthesis '('
#263: FILE: drivers/net/sfc/base/efx_bootcfg.c:242:
+			(*tagpp) += sizeof (efx_dhcp_tag_hdr_t);

WARNING:SPACING: space prohibited between function name and open parenthesis '('
#288: FILE: drivers/net/sfc/base/efx_bootcfg.c:267:
+			if (*buffer_sizep < sizeof (efx_dhcp_tag_hdr_t)) {

ERROR:RETURN_PARENTHESES: return is not a function, parentheses are not required
#325: FILE: drivers/net/sfc/base/efx_bootcfg.c:304:
+	return (rc);

CHECK:OPEN_ENDED_LINE: Lines should not end with a '('
#334: FILE: drivers/net/sfc/base/efx_bootcfg.c:313:
+efx_dhcp_find_tag(

ERROR:RETURN_PARENTHESES: return is not a function, parentheses are not required
#361: FILE: drivers/net/sfc/base/efx_bootcfg.c:340:
+	return (rc);

CHECK:OPEN_ENDED_LINE: Lines should not end with a '('
#371: FILE: drivers/net/sfc/base/efx_bootcfg.c:350:
+efx_dhcp_find_end(

ERROR:RETURN_PARENTHESES: return is not a function, parentheses are not required
#386: FILE: drivers/net/sfc/base/efx_bootcfg.c:365:
+	return (rc);

ERROR:RETURN_PARENTHESES: return is not a function, parentheses are not required
#391: FILE: drivers/net/sfc/base/efx_bootcfg.c:370:
+	return (rc);

CHECK:OPEN_ENDED_LINE: Lines should not end with a '('
#401: FILE: drivers/net/sfc/base/efx_bootcfg.c:380:
+efx_dhcp_delete_tag(

CHECK:OPEN_ENDED_LINE: Lines should not end with a '('
#439: FILE: drivers/net/sfc/base/efx_bootcfg.c:418:
+			encap_hdrp->length = (uint8_t)(

ERROR:RETURN_PARENTHESES: return is not a function, parentheses are not required
#463: FILE: drivers/net/sfc/base/efx_bootcfg.c:442:
+	return (0);

ERROR:RETURN_PARENTHESES: return is not a function, parentheses are not required
#474: FILE: drivers/net/sfc/base/efx_bootcfg.c:453:
+	return (rc);

CHECK:OPEN_ENDED_LINE: Lines should not end with a '('
#482: FILE: drivers/net/sfc/base/efx_bootcfg.c:461:
+efx_dhcp_write_tag(

CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses around 'value_length > 0'
#492: FILE: drivers/net/sfc/base/efx_bootcfg.c:471:
+	if ((value_length > 0) && (valuep != NULL))

CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses around 'valuep != NULL'
#492: FILE: drivers/net/sfc/base/efx_bootcfg.c:471:
+	if ((value_length > 0) && (valuep != NULL))

CHECK:OPEN_ENDED_LINE: Lines should not end with a '('
#502: FILE: drivers/net/sfc/base/efx_bootcfg.c:481:
+efx_dhcp_add_tag(

CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses around 'value_length > 0'
#528: FILE: drivers/net/sfc/base/efx_bootcfg.c:507:
+	if ((value_length > 0) && (valuep == NULL)) {

CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses around 'valuep == NULL'
#528: FILE: drivers/net/sfc/base/efx_bootcfg.c:507:
+	if ((value_length > 0) && (valuep == NULL)) {

WARNING:SPACING: space prohibited between function name and open parenthesis '('
#589: FILE: drivers/net/sfc/base/efx_bootcfg.c:568:
+	    (DHCP_IS_ENCAP_OPT(opt) ? sizeof (efx_dhcp_tag_hdr_t) : 0);

WARNING:SPACING: space prohibited between function name and open parenthesis '('
#601: FILE: drivers/net/sfc/base/efx_bootcfg.c:580:
+		added_length -= sizeof (efx_dhcp_tag_hdr_t);

WARNING:SPACING: space prohibited between function name and open parenthesis '('
#604: FILE: drivers/net/sfc/base/efx_bootcfg.c:583:
+		insert_pointp += sizeof (efx_dhcp_tag_hdr_t);

ERROR:RETURN_PARENTHESES: return is not a function, parentheses are not required
#612: FILE: drivers/net/sfc/base/efx_bootcfg.c:591:
+	return (0);

ERROR:RETURN_PARENTHESES: return is not a function, parentheses are not required
#633: FILE: drivers/net/sfc/base/efx_bootcfg.c:612:
+	return (rc);

CHECK:OPEN_ENDED_LINE: Lines should not end with a '('
#641: FILE: drivers/net/sfc/base/efx_bootcfg.c:620:
+efx_dhcp_update_tag(

WARNING:SPACING: space prohibited between function name and open parenthesis '('
#650: FILE: drivers/net/sfc/base/efx_bootcfg.c:629:
+	uint8_t *write_pointp = value_locationp - sizeof (efx_dhcp_tag_hdr_t);

CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses around 'value_length > 0'
#665: FILE: drivers/net/sfc/base/efx_bootcfg.c:644:
+	if ((value_length > 0) && (valuep == NULL)) {

CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses around 'valuep == NULL'
#665: FILE: drivers/net/sfc/base/efx_bootcfg.c:644:
+	if ((value_length > 0) && (valuep == NULL)) {

WARNING:TYPO_SPELLING: 'accomodate' may be misspelled - perhaps 'accommodate'?
#711: FILE: drivers/net/sfc/base/efx_bootcfg.c:690:
+	 * Move the following data up/down to accomodate the new payload

ERROR:RETURN_PARENTHESES: return is not a function, parentheses are not required
#726: FILE: drivers/net/sfc/base/efx_bootcfg.c:705:
+	return (0);

ERROR:RETURN_PARENTHESES: return is not a function, parentheses are not required
#743: FILE: drivers/net/sfc/base/efx_bootcfg.c:722:
+	return (rc);

ERROR:ASSIGN_IN_IF: do not use assignment in if condition
#911: FILE: drivers/net/sfc/base/efx_bootcfg.c:1028:
+	if ((rc = efx_dhcp_verify(data, size, &used_bytes)) != 0)

CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses around 'used_bytes < 2'
#921: FILE: drivers/net/sfc/base/efx_bootcfg.c:1035:
+	if ((used_bytes < 2) || ((uint8_t)data[used_bytes - 1] !=
+	    EFX_DHCP_END)) {

total: 11 errors, 10 warnings, 27 checks, 880 lines checked