From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <checkpatch@dpdk.org>
Received: by dpdk.org (Postfix, from userid 1017)
 id CE78D4C92; Mon, 10 Sep 2018 11:40:28 +0200 (CEST)
In-Reply-To: <1536572016-18134-33-git-send-email-arybchenko@solarflare.com>
References: <1536572016-18134-33-git-send-email-arybchenko@solarflare.com>
To: test-report@dpdk.org
Cc: Andrew Rybchenko <arybchenko@solarflare.com>
Message-Id: <20180910094028.CE78D4C92@dpdk.org>
Date: Mon, 10 Sep 2018 11:40:28 +0200 (CEST)
From: checkpatch@dpdk.org
Subject: [dpdk-test-report] |WARNING| pw44502 [32/37] net/sfc/base: check
	buffer size for hash flags
X-BeenThere: test-report@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: automatic DPDK test reports <test-report.dpdk.org>
List-Unsubscribe: <https://mails.dpdk.org/options/test-report>,
 <mailto:test-report-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://mails.dpdk.org/archives/test-report/>
List-Post: <mailto:test-report@dpdk.org>
List-Help: <mailto:test-report-request@dpdk.org?subject=help>
List-Subscribe: <https://mails.dpdk.org/listinfo/test-report>,
 <mailto:test-report-request@dpdk.org?subject=subscribe>
X-List-Received-Date: Mon, 10 Sep 2018 09:40:29 -0000

Test-Label: checkpatch
Test-Status: WARNING
http://dpdk.org/patch/44502

_coding style issues_


WARNING:MACRO_WITH_FLOW_CONTROL: Macros with flow control statements should be avoided
#117: FILE: drivers/net/sfc/base/efx_rx.c:320:
+#define	INSERT_FLAGS(_flags)			\
+	do {					\
+		if (nflags >= max_nflags) {	\
+			rc = E2BIG;		\
+			goto fail2;		\
+		}				\
+		*(flagsp + nflags) = (_flags);	\
+		nflags++;			\
+						\
+		_NOTE(CONSTANTCONDITION)	\
 	} while (B_FALSE)

CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses around 'encp->enc_rx_scale_l4_hash_supported != B_FALSE'
#136: FILE: drivers/net/sfc/base/efx_rx.c:337:
+	if ((encp->enc_rx_scale_l4_hash_supported != B_FALSE) &&
+	    (encp->enc_rx_scale_additional_modes_supported != B_FALSE)) {

CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses around 'encp->enc_rx_scale_additional_modes_supported != B_FALSE'
#136: FILE: drivers/net/sfc/base/efx_rx.c:337:
+	if ((encp->enc_rx_scale_l4_hash_supported != B_FALSE) &&
+	    (encp->enc_rx_scale_additional_modes_supported != B_FALSE)) {

total: 0 errors, 1 warnings, 2 checks, 177 lines checked