From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <checkpatch@dpdk.org>
Received: by dpdk.org (Postfix, from userid 1017)
 id 8FE0A2BE5; Mon, 17 Sep 2018 09:47:04 +0200 (CEST)
In-Reply-To: <1537170493-83190-1-git-send-email-yogev@cgstowernetworks.com>
References: <1537170493-83190-1-git-send-email-yogev@cgstowernetworks.com>
To: test-report@dpdk.org
Cc: yogev ch <yogev@cgstowernetworks.com>
Message-Id: <20180917074704.8FE0A2BE5@dpdk.org>
Date: Mon, 17 Sep 2018 09:47:04 +0200 (CEST)
From: checkpatch@dpdk.org
Subject: [dpdk-test-report] |WARNING| pw44771 vmxnet3: stats_reset
	implementation
X-BeenThere: test-report@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: automatic DPDK test reports <test-report.dpdk.org>
List-Unsubscribe: <https://mails.dpdk.org/options/test-report>,
 <mailto:test-report-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://mails.dpdk.org/archives/test-report/>
List-Post: <mailto:test-report@dpdk.org>
List-Help: <mailto:test-report-request@dpdk.org?subject=help>
List-Subscribe: <https://mails.dpdk.org/listinfo/test-report>,
 <mailto:test-report-request@dpdk.org?subject=subscribe>
X-List-Received-Date: Mon, 17 Sep 2018 07:47:04 -0000

Test-Label: checkpatch
Test-Status: WARNING
http://dpdk.org/patch/44771

_coding style issues_


WARNING:COMMIT_LOG_LONG_LINE: Possible unwrapped commit description (prefer a maximum 75 chars per line)
#17: 
This commit implements the callback by taking a snapshot of the stats (SNAPSHOT) each time 'stats_reset()' is called.

CHECK:CAMELCASE: Avoid CamelCase: <UPT1_TxStats>
#67: FILE: drivers/net/vmxnet3/vmxnet3_ethdev.c:904:
+					struct UPT1_TxStats *res)

CHECK:MACRO_ARG_REUSE: Macro argument reuse 'f' - possible side-effects?
#71: FILE: drivers/net/vmxnet3/vmxnet3_ethdev.c:908:
+#define VMXNET3_REDUCE_SNAPSHOT_TX_STAT(h, i, f, r)	\
+		((r)->f -= (h)->snapshot_tx_stats[(i)].f)

CHECK:MACRO_ARG_PRECEDENCE: Macro argument 'f' may be better as '(f)' to avoid precedence issues
#71: FILE: drivers/net/vmxnet3/vmxnet3_ethdev.c:908:
+#define VMXNET3_REDUCE_SNAPSHOT_TX_STAT(h, i, f, r)	\
+		((r)->f -= (h)->snapshot_tx_stats[(i)].f)

CHECK:CAMELCASE: Avoid CamelCase: <ucastPktsTxOK>
#74: FILE: drivers/net/vmxnet3/vmxnet3_ethdev.c:911:
+	VMXNET3_REDUCE_SNAPSHOT_TX_STAT(hw, q, ucastPktsTxOK, res);

CHECK:CAMELCASE: Avoid CamelCase: <mcastPktsTxOK>
#75: FILE: drivers/net/vmxnet3/vmxnet3_ethdev.c:912:
+	VMXNET3_REDUCE_SNAPSHOT_TX_STAT(hw, q, mcastPktsTxOK, res);

CHECK:CAMELCASE: Avoid CamelCase: <bcastPktsTxOK>
#76: FILE: drivers/net/vmxnet3/vmxnet3_ethdev.c:913:
+	VMXNET3_REDUCE_SNAPSHOT_TX_STAT(hw, q, bcastPktsTxOK, res);

CHECK:CAMELCASE: Avoid CamelCase: <ucastBytesTxOK>
#77: FILE: drivers/net/vmxnet3/vmxnet3_ethdev.c:914:
+	VMXNET3_REDUCE_SNAPSHOT_TX_STAT(hw, q, ucastBytesTxOK, res);

CHECK:CAMELCASE: Avoid CamelCase: <mcastBytesTxOK>
#78: FILE: drivers/net/vmxnet3/vmxnet3_ethdev.c:915:
+	VMXNET3_REDUCE_SNAPSHOT_TX_STAT(hw, q, mcastBytesTxOK, res);

CHECK:CAMELCASE: Avoid CamelCase: <bcastBytesTxOK>
#79: FILE: drivers/net/vmxnet3/vmxnet3_ethdev.c:916:
+	VMXNET3_REDUCE_SNAPSHOT_TX_STAT(hw, q, bcastBytesTxOK, res);

CHECK:CAMELCASE: Avoid CamelCase: <pktsTxError>
#80: FILE: drivers/net/vmxnet3/vmxnet3_ethdev.c:917:
+	VMXNET3_REDUCE_SNAPSHOT_TX_STAT(hw, q, pktsTxError, res);

CHECK:CAMELCASE: Avoid CamelCase: <pktsTxDiscard>
#81: FILE: drivers/net/vmxnet3/vmxnet3_ethdev.c:918:
+	VMXNET3_REDUCE_SNAPSHOT_TX_STAT(hw, q, pktsTxDiscard, res);

CHECK:CAMELCASE: Avoid CamelCase: <UPT1_RxStats>
#88: FILE: drivers/net/vmxnet3/vmxnet3_ethdev.c:925:
+					struct UPT1_RxStats *res)

CHECK:MACRO_ARG_REUSE: Macro argument reuse 'f' - possible side-effects?
#92: FILE: drivers/net/vmxnet3/vmxnet3_ethdev.c:929:
+#define VMXNET3_REDUCE_SNAPSHOT_RX_STAT(h, i, f, r)	\
+		((r)->f -= (h)->snapshot_rx_stats[(i)].f)

CHECK:MACRO_ARG_PRECEDENCE: Macro argument 'f' may be better as '(f)' to avoid precedence issues
#92: FILE: drivers/net/vmxnet3/vmxnet3_ethdev.c:929:
+#define VMXNET3_REDUCE_SNAPSHOT_RX_STAT(h, i, f, r)	\
+		((r)->f -= (h)->snapshot_rx_stats[(i)].f)

CHECK:CAMELCASE: Avoid CamelCase: <ucastPktsRxOK>
#95: FILE: drivers/net/vmxnet3/vmxnet3_ethdev.c:932:
+	VMXNET3_REDUCE_SNAPSHOT_RX_STAT(hw, q, ucastPktsRxOK, res);

CHECK:CAMELCASE: Avoid CamelCase: <mcastPktsRxOK>
#96: FILE: drivers/net/vmxnet3/vmxnet3_ethdev.c:933:
+	VMXNET3_REDUCE_SNAPSHOT_RX_STAT(hw, q, mcastPktsRxOK, res);

CHECK:CAMELCASE: Avoid CamelCase: <bcastPktsRxOK>
#97: FILE: drivers/net/vmxnet3/vmxnet3_ethdev.c:934:
+	VMXNET3_REDUCE_SNAPSHOT_RX_STAT(hw, q, bcastPktsRxOK, res);

CHECK:CAMELCASE: Avoid CamelCase: <ucastBytesRxOK>
#98: FILE: drivers/net/vmxnet3/vmxnet3_ethdev.c:935:
+	VMXNET3_REDUCE_SNAPSHOT_RX_STAT(hw, q, ucastBytesRxOK, res);

CHECK:CAMELCASE: Avoid CamelCase: <mcastBytesRxOK>
#99: FILE: drivers/net/vmxnet3/vmxnet3_ethdev.c:936:
+	VMXNET3_REDUCE_SNAPSHOT_RX_STAT(hw, q, mcastBytesRxOK, res);

CHECK:CAMELCASE: Avoid CamelCase: <bcastBytesRxOK>
#100: FILE: drivers/net/vmxnet3/vmxnet3_ethdev.c:937:
+	VMXNET3_REDUCE_SNAPSHOT_RX_STAT(hw, q, bcastBytesRxOK, res);

CHECK:CAMELCASE: Avoid CamelCase: <pktsRxError>
#101: FILE: drivers/net/vmxnet3/vmxnet3_ethdev.c:938:
+	VMXNET3_REDUCE_SNAPSHOT_RX_STAT(hw, q, pktsRxError, res);

CHECK:CAMELCASE: Avoid CamelCase: <pktsRxOutOfBuf>
#102: FILE: drivers/net/vmxnet3/vmxnet3_ethdev.c:939:
+	VMXNET3_REDUCE_SNAPSHOT_RX_STAT(hw, q, pktsRxOutOfBuf, res);

CHECK:CAMELCASE: Avoid CamelCase: <txStats>
#113: FILE: drivers/net/vmxnet3/vmxnet3_ethdev.c:1056:
+		vmxnet3_tx_stats_get(hw, i, &txStats);

CHECK:CAMELCASE: Avoid CamelCase: <rxStats>
#122: FILE: drivers/net/vmxnet3/vmxnet3_ethdev.c:1073:
+		vmxnet3_rx_stats_get(hw, i, &rxStats);

total: 0 errors, 1 warnings, 24 checks, 129 lines checked