From: checkpatch@dpdk.org
To: test-report@dpdk.org
Cc: Igor Ryzhov <iryzhov@nfware.com>
Subject: [dpdk-test-report] |WARNING| pw45180 [v2] kni: dynamically allocate memory for each KNI
Date: Sun, 23 Sep 2018 21:12:55 +0200 (CEST) [thread overview]
Message-ID: <20180923191255.2229A4C8D@dpdk.org> (raw)
In-Reply-To: <20180923191202.64896-1-iryzhov@nfware.com>
Test-Label: checkpatch
Test-Status: WARNING
http://dpdk.org/patch/45180
_coding style issues_
WARNING:MACRO_WITH_FLOW_CONTROL: Macros with flow control statements should be avoided
#54: FILE: lib/librte_kni/rte_kni.c:36:
+#define KNI_MEM_CHECK(cond, fail) do { if (cond) goto fail; } while (0)
WARNING:BRACES: braces {} are not necessary for single statement blocks
#609: FILE: lib/librte_kni/rte_kni.c:383:
+ if (te == NULL) {
+ goto unlock;
+ }
WARNING:BRACES: braces {} are not necessary for single statement blocks
#689: FILE: lib/librte_kni/rte_kni.c:648:
+ if (te == NULL) {
+ return NULL;
+ }
total: 0 errors, 3 warnings, 674 lines checked
parent reply other threads:[~2018-09-23 19:12 UTC|newest]
Thread overview: expand[flat|nested] mbox.gz Atom feed
[parent not found: <20180923191202.64896-1-iryzhov@nfware.com>]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180923191255.2229A4C8D@dpdk.org \
--to=checkpatch@dpdk.org \
--cc=iryzhov@nfware.com \
--cc=test-report@dpdk.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).