From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <checkpatch@dpdk.org>
Received: by dpdk.org (Postfix, from userid 1017)
 id 2229A4C8D; Sun, 23 Sep 2018 21:12:55 +0200 (CEST)
In-Reply-To: <20180923191202.64896-1-iryzhov@nfware.com>
References: <20180923191202.64896-1-iryzhov@nfware.com>
To: test-report@dpdk.org
Cc: Igor Ryzhov <iryzhov@nfware.com>
Message-Id: <20180923191255.2229A4C8D@dpdk.org>
Date: Sun, 23 Sep 2018 21:12:55 +0200 (CEST)
From: checkpatch@dpdk.org
Subject: [dpdk-test-report] |WARNING| pw45180 [v2] kni: dynamically allocate
	memory for each KNI
X-BeenThere: test-report@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: automatic DPDK test reports <test-report.dpdk.org>
List-Unsubscribe: <https://mails.dpdk.org/options/test-report>,
 <mailto:test-report-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://mails.dpdk.org/archives/test-report/>
List-Post: <mailto:test-report@dpdk.org>
List-Help: <mailto:test-report-request@dpdk.org?subject=help>
List-Subscribe: <https://mails.dpdk.org/listinfo/test-report>,
 <mailto:test-report-request@dpdk.org?subject=subscribe>
X-List-Received-Date: Sun, 23 Sep 2018 19:12:55 -0000

Test-Label: checkpatch
Test-Status: WARNING
http://dpdk.org/patch/45180

_coding style issues_


WARNING:MACRO_WITH_FLOW_CONTROL: Macros with flow control statements should be avoided
#54: FILE: lib/librte_kni/rte_kni.c:36:
+#define KNI_MEM_CHECK(cond, fail) do { if (cond) goto fail; } while (0)

WARNING:BRACES: braces {} are not necessary for single statement blocks
#609: FILE: lib/librte_kni/rte_kni.c:383:
+	if (te == NULL) {
+		goto unlock;
+	}

WARNING:BRACES: braces {} are not necessary for single statement blocks
#689: FILE: lib/librte_kni/rte_kni.c:648:
+	if (te == NULL) {
+		return NULL;
+	}

total: 0 errors, 3 warnings, 674 lines checked