[dpdk-test-report] |WARNING| pw45212 [09/11] net/sfc/base: add accessor to whole link status

[dpdk-test-report] |WARNING| pw45212 [09/11] net/sfc/base: add accessor to whole link status

[checkpatch]

Test-Label: checkpatch
Test-Status: WARNING
http://dpdk.org/patch/45212

_coding style issues_


CHECK:OPEN_ENDED_LINE: Lines should not end with a '('
#59: FILE: drivers/net/sfc/base/ef10_impl.h:633:
+ef10_phy_link_state_get(

CHECK:OPEN_ENDED_LINE: Lines should not end with a '('
#139: FILE: drivers/net/sfc/base/ef10_phy.c:554:
+ef10_phy_link_state_get(

CHECK:CAMELCASE: Avoid CamelCase: <__checkReturn>
#174: FILE: drivers/net/sfc/base/efx.h:3269:
+extern	__checkReturn	efx_rc_t

CHECK:OPEN_ENDED_LINE: Lines should not end with a '('
#175: FILE: drivers/net/sfc/base/efx.h:3270:
+efx_phy_link_state_get(

WARNING:FUNCTION_ARGUMENTS: function definition argument 'efx_nic_t *' should also have an identifier name
#192: FILE: drivers/net/sfc/base/efx_impl.h:227:
+	efx_rc_t	(*epo_link_state_get)(efx_nic_t *, efx_phy_link_state_t *);

WARNING:FUNCTION_ARGUMENTS: function definition argument 'efx_phy_link_state_t *' should also have an identifier name
#192: FILE: drivers/net/sfc/base/efx_impl.h:227:
+	efx_rc_t	(*epo_link_state_get)(efx_nic_t *, efx_phy_link_state_t *);

ERROR:ASSIGN_IN_IF: do not use assignment in if condition
#226: FILE: drivers/net/sfc/base/efx_phy.c:328:
+	if ((rc = efx_phy_link_state_get(enp, &epls)) != 0)

ERROR:RETURN_PARENTHESES: return is not a function, parentheses are not required
#231: FILE: drivers/net/sfc/base/efx_phy.c:333:
+	return (0);

ERROR:RETURN_PARENTHESES: return is not a function, parentheses are not required
#236: FILE: drivers/net/sfc/base/efx_phy.c:338:
+	return (rc);

CHECK:OPEN_ENDED_LINE: Lines should not end with a '('
#240: FILE: drivers/net/sfc/base/efx_phy.c:342:
+efx_phy_link_state_get(

ERROR:ASSIGN_IN_IF: do not use assignment in if condition
#258: FILE: drivers/net/sfc/base/efx_phy.c:358:
+	if ((rc = epop->epo_link_state_get(enp, eplsp)) != 0)

total: 4 errors, 2 warnings, 5 checks, 185 lines checked