From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <checkpatch@dpdk.org>
Received: by dpdk.org (Postfix, from userid 1017)
 id B3FC61B476; Sat, 29 Sep 2018 04:02:18 +0200 (CEST)
In-Reply-To: <20180929020006.71505-9-ajit.khaparde@broadcom.com>
References: <20180929020006.71505-9-ajit.khaparde@broadcom.com>
To: test-report@dpdk.org
Cc: Ajit Khaparde <ajit.khaparde@broadcom.com>
Message-Id: <20180929020218.B3FC61B476@dpdk.org>
Date: Sat, 29 Sep 2018 04:02:18 +0200 (CEST)
From: checkpatch@dpdk.org
Subject: [dpdk-test-report] |WARNING| pw45631 [v3,
	08/15] net/bnxt: add support to enable new mailbox channel
X-BeenThere: test-report@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: automatic DPDK test reports <test-report.dpdk.org>
List-Unsubscribe: <https://mails.dpdk.org/options/test-report>,
 <mailto:test-report-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://mails.dpdk.org/archives/test-report/>
List-Post: <mailto:test-report@dpdk.org>
List-Help: <mailto:test-report-request@dpdk.org?subject=help>
List-Subscribe: <https://mails.dpdk.org/listinfo/test-report>,
 <mailto:test-report-request@dpdk.org?subject=subscribe>
X-List-Received-Date: Sat, 29 Sep 2018 02:02:19 -0000

Test-Label: checkpatch
Test-Status: WARNING
http://dpdk.org/patch/45631

_coding style issues_


CHECK:MACRO_ARG_REUSE: Macro argument reuse 'req' - possible side-effects?
#122: FILE: drivers/net/bnxt/bnxt_hwrm.c:163:
+#define HWRM_PREP(req, type, kong) do { \
 	rte_spinlock_lock(&bp->hwrm_lock); \
 	memset(bp->hwrm_cmd_resp_addr, 0, bp->max_resp_len); \
 	req.req_type = rte_cpu_to_le_16(HWRM_##type); \
 	req.cmpl_ring = rte_cpu_to_le_16(-1); \
+	req.seq_id = kong ? rte_cpu_to_le_16(bp->kong_cmd_seq++) :\
+		rte_cpu_to_le_16(bp->hwrm_cmd_seq++); \
 	req.target_id = rte_cpu_to_le_16(0xffff); \
 	req.resp_addr = rte_cpu_to_le_64(bp->hwrm_cmd_resp_dma_addr); \
 } while (0)

total: 0 errors, 0 warnings, 1 checks, 1171 lines checked