From: checkpatch@dpdk.org
To: test-report@dpdk.org
Cc: Igor Russkikh <igor.russkikh@aquantia.com>
Subject: [dpdk-test-report] |WARNING| pw45669 [v3, 05/22] net/atlantic: firmware operations layer
Date: Sat, 29 Sep 2018 12:31:55 +0200 (CEST) [thread overview]
Message-ID: <20180929103155.857A91B2AE@dpdk.org> (raw)
In-Reply-To: <d7f643d74e8d71ef03fb908b78fb80df43e99137.1538215990.git.igor.russkikh@aquantia.com>
Test-Label: checkpatch
Test-Status: WARNING
http://dpdk.org/patch/45669
_coding style issues_
CHECK:BOOL_MEMBER: Avoid using bool structure members because of possible alignment issues - see: https://lkml.org/lkml/2017/11/21/384
#89: FILE: drivers/net/atlantic/atl_types.h:60:
+ bool is_lro;
CHECK:MACRO_ARG_REUSE: Macro argument reuse '_N_' - possible side-effects?
#918: FILE: drivers/net/atlantic/hw_atl/hw_atl_utils.c:753:
+#define AQ_SDELTA(_N_) (self->curr_stats._N_ += \
+ mbox.stats._N_ - self->last_stats._N_)
CHECK:MACRO_ARG_PRECEDENCE: Macro argument '_N_' may be better as '(_N_)' to avoid precedence issues
#918: FILE: drivers/net/atlantic/hw_atl/hw_atl_utils.c:753:
+#define AQ_SDELTA(_N_) (self->curr_stats._N_ += \
+ mbox.stats._N_ - self->last_stats._N_)
CHECK:CAMELCASE: Avoid CamelCase: <tcQuanta>
#1298: FILE: drivers/net/atlantic/hw_atl/hw_atl_utils.h:185:
+ u16 tcQuanta[8];
CHECK:CAMELCASE: Avoid CamelCase: <tcThreshold>
#1299: FILE: drivers/net/atlantic/hw_atl/hw_atl_utils.h:186:
+ u16 tcThreshold[8];
total: 0 errors, 0 warnings, 5 checks, 2189 lines checked
parent reply other threads:[~2018-09-29 10:31 UTC|newest]
Thread overview: expand[flat|nested] mbox.gz Atom feed
[parent not found: <d7f643d74e8d71ef03fb908b78fb80df43e99137.1538215990.git.igor.russkikh@aquantia.com>]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180929103155.857A91B2AE@dpdk.org \
--to=checkpatch@dpdk.org \
--cc=igor.russkikh@aquantia.com \
--cc=test-report@dpdk.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).