[dpdk-test-report] |WARNING| pw45669 [v3, 05/22] net/atlantic: firmware operations layer

[dpdk-test-report] |WARNING| pw45669 [v3, 05/22] net/atlantic: firmware operations layer

[checkpatch]

Test-Label: checkpatch
Test-Status: WARNING
http://dpdk.org/patch/45669

_coding style issues_


CHECK:BOOL_MEMBER: Avoid using bool structure members because of possible alignment issues - see: https://lkml.org/lkml/2017/11/21/384
#89: FILE: drivers/net/atlantic/atl_types.h:60:
+	bool is_lro;

CHECK:MACRO_ARG_REUSE: Macro argument reuse '_N_' - possible side-effects?
#918: FILE: drivers/net/atlantic/hw_atl/hw_atl_utils.c:753:
+#define AQ_SDELTA(_N_) (self->curr_stats._N_ += \
+			mbox.stats._N_ - self->last_stats._N_)

CHECK:MACRO_ARG_PRECEDENCE: Macro argument '_N_' may be better as '(_N_)' to avoid precedence issues
#918: FILE: drivers/net/atlantic/hw_atl/hw_atl_utils.c:753:
+#define AQ_SDELTA(_N_) (self->curr_stats._N_ += \
+			mbox.stats._N_ - self->last_stats._N_)

CHECK:CAMELCASE: Avoid CamelCase: <tcQuanta>
#1298: FILE: drivers/net/atlantic/hw_atl/hw_atl_utils.h:185:
+			u16 tcQuanta[8];

CHECK:CAMELCASE: Avoid CamelCase: <tcThreshold>
#1299: FILE: drivers/net/atlantic/hw_atl/hw_atl_utils.h:186:
+			u16 tcThreshold[8];

total: 0 errors, 0 warnings, 5 checks, 2189 lines checked