From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <checkpatch@dpdk.org>
Received: by dpdk.org (Postfix, from userid 1017)
 id 857A91B2AE; Sat, 29 Sep 2018 12:31:55 +0200 (CEST)
In-Reply-To: <d7f643d74e8d71ef03fb908b78fb80df43e99137.1538215990.git.igor.russkikh@aquantia.com>
References: <d7f643d74e8d71ef03fb908b78fb80df43e99137.1538215990.git.igor.russkikh@aquantia.com>
To: test-report@dpdk.org
Cc: Igor Russkikh <igor.russkikh@aquantia.com>
Message-Id: <20180929103155.857A91B2AE@dpdk.org>
Date: Sat, 29 Sep 2018 12:31:55 +0200 (CEST)
From: checkpatch@dpdk.org
Subject: [dpdk-test-report] |WARNING| pw45669 [v3,
	05/22] net/atlantic: firmware operations layer
X-BeenThere: test-report@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: automatic DPDK test reports <test-report.dpdk.org>
List-Unsubscribe: <https://mails.dpdk.org/options/test-report>,
 <mailto:test-report-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://mails.dpdk.org/archives/test-report/>
List-Post: <mailto:test-report@dpdk.org>
List-Help: <mailto:test-report-request@dpdk.org?subject=help>
List-Subscribe: <https://mails.dpdk.org/listinfo/test-report>,
 <mailto:test-report-request@dpdk.org?subject=subscribe>
X-List-Received-Date: Sat, 29 Sep 2018 10:31:55 -0000

Test-Label: checkpatch
Test-Status: WARNING
http://dpdk.org/patch/45669

_coding style issues_


CHECK:BOOL_MEMBER: Avoid using bool structure members because of possible alignment issues - see: https://lkml.org/lkml/2017/11/21/384
#89: FILE: drivers/net/atlantic/atl_types.h:60:
+	bool is_lro;

CHECK:MACRO_ARG_REUSE: Macro argument reuse '_N_' - possible side-effects?
#918: FILE: drivers/net/atlantic/hw_atl/hw_atl_utils.c:753:
+#define AQ_SDELTA(_N_) (self->curr_stats._N_ += \
+			mbox.stats._N_ - self->last_stats._N_)

CHECK:MACRO_ARG_PRECEDENCE: Macro argument '_N_' may be better as '(_N_)' to avoid precedence issues
#918: FILE: drivers/net/atlantic/hw_atl/hw_atl_utils.c:753:
+#define AQ_SDELTA(_N_) (self->curr_stats._N_ += \
+			mbox.stats._N_ - self->last_stats._N_)

CHECK:CAMELCASE: Avoid CamelCase: <tcQuanta>
#1298: FILE: drivers/net/atlantic/hw_atl/hw_atl_utils.h:185:
+			u16 tcQuanta[8];

CHECK:CAMELCASE: Avoid CamelCase: <tcThreshold>
#1299: FILE: drivers/net/atlantic/hw_atl/hw_atl_utils.h:186:
+			u16 tcThreshold[8];

total: 0 errors, 0 warnings, 5 checks, 2189 lines checked