From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <checkpatch@dpdk.org>
Received: by dpdk.org (Postfix, from userid 1017)
 id B52A01B39C; Fri,  5 Oct 2018 16:48:53 +0200 (CEST)
In-Reply-To: <1538750823-26291-3-git-send-email-arybchenko@solarflare.com>
References: <1538750823-26291-3-git-send-email-arybchenko@solarflare.com>
To: test-report@dpdk.org
Cc: Andrew Rybchenko <arybchenko@solarflare.com>
Message-Id: <20181005144853.B52A01B39C@dpdk.org>
Date: Fri,  5 Oct 2018 16:48:53 +0200 (CEST)
From: checkpatch@dpdk.org
Subject: [dpdk-test-report] |WARNING| pw46179 [2/3] net/sfc: support TSO in
	EF10 Tx datapath
X-BeenThere: test-report@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: automatic DPDK test reports <test-report.dpdk.org>
List-Unsubscribe: <https://mails.dpdk.org/options/test-report>,
 <mailto:test-report-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://mails.dpdk.org/archives/test-report/>
List-Post: <mailto:test-report@dpdk.org>
List-Help: <mailto:test-report-request@dpdk.org?subject=help>
List-Subscribe: <https://mails.dpdk.org/listinfo/test-report>,
 <mailto:test-report-request@dpdk.org?subject=subscribe>
X-List-Received-Date: Fri, 05 Oct 2018 14:48:54 -0000

Test-Label: checkpatch
Test-Status: WARNING
http://dpdk.org/patch/46179

_coding style issues_


CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses around 'header_len > SFC_TSOH_STD_LEN'
#199: FILE: drivers/net/sfc/sfc_ef10_tx.c:344:
+	if (unlikely((header_len > SFC_TSOH_STD_LEN) |
+		     (tcph_off > txq->tso_tcp_header_offset_limit)))

CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses around 'tcph_off > txq->tso_tcp_header_offset_limit'
#199: FILE: drivers/net/sfc/sfc_ef10_tx.c:344:
+	if (unlikely((header_len > SFC_TSOH_STD_LEN) |
+		     (tcph_off > txq->tso_tcp_header_offset_limit)))

WARNING:USE_NEGATIVE_ERRNO: return of an errno should typically be negative (ie: return -EMSGSIZE)
#201: FILE: drivers/net/sfc/sfc_ef10_tx.c:346:
+		return EMSGSIZE;

WARNING:USE_NEGATIVE_ERRNO: return of an errno should typically be negative (ie: return -ENOSPC)
#222: FILE: drivers/net/sfc/sfc_ef10_tx.c:367:
+			return ENOSPC;

WARNING:USE_NEGATIVE_ERRNO: return of an errno should typically be negative (ie: return -EMSGSIZE)
#231: FILE: drivers/net/sfc/sfc_ef10_tx.c:376:
+			return EMSGSIZE;

WARNING:USE_NEGATIVE_ERRNO: return of an errno should typically be negative (ie: return -EINVAL)
#292: FILE: drivers/net/sfc/sfc_ef10_tx.c:437:
+		return EINVAL;

WARNING:USE_NEGATIVE_ERRNO: return of an errno should typically be negative (ie: return -ENOSPC)
#360: FILE: drivers/net/sfc/sfc_ef10_tx.c:505:
+					return ENOSPC;

total: 0 errors, 5 warnings, 2 checks, 437 lines checked