From: checkpatch@dpdk.org
To: test-report@dpdk.org
Cc: Phil Yang <phil.yang@arm.com>
Subject: [dpdk-test-report] |WARNING| pw46242 [v3, 4/4] kni: introduce c11 atomic into kni fifo synchronization
Date: Mon, 8 Oct 2018 11:13:36 +0200 (CEST) [thread overview]
Message-ID: <20181008091336.BC2434C8F@dpdk.org> (raw)
In-Reply-To: <1538989906-8349-4-git-send-email-phil.yang@arm.com>
Test-Label: checkpatch
Test-Status: WARNING
http://dpdk.org/patch/46242
_coding style issues_
WARNING:UNSPECIFIED_INT: Prefer 'unsigned int' to bare use of 'unsigned'
#39: FILE: lib/librte_eal/linuxapp/eal/include/exec-env/rte_kni_common.h:59:
+ unsigned write; /**< Next position to be written*/
WARNING:UNSPECIFIED_INT: Prefer 'unsigned int' to bare use of 'unsigned'
#40: FILE: lib/librte_eal/linuxapp/eal/include/exec-env/rte_kni_common.h:60:
+ unsigned read; /**< Next position to be read */
WARNING:SINGLE_STATEMENT_DO_WHILE_MACRO: Single statement macros should not use a do {} while (0) loop
#70: FILE: lib/librte_kni/rte_kni_fifo.h:22:
+#define __KNI_STORE_RELEASE(dst, value) do { \
+ __atomic_store_n((dst), value, __ATOMIC_RELEASE); \
+ } while(0)
ERROR:SPACING: space required before the open parenthesis '('
#72: FILE: lib/librte_kni/rte_kni_fifo.h:24:
+ } while(0)
WARNING:SPACING: space prohibited between function name and open parenthesis '('
#75: FILE: lib/librte_kni/rte_kni_fifo.h:27:
+ typeof (*(src)) val = *(src); \
ERROR:SPACING: space required before the open parenthesis '('
#82: FILE: lib/librte_kni/rte_kni_fifo.h:34:
+ } while(0)
WARNING:UNSPECIFIED_INT: Prefer 'unsigned int' to bare use of 'unsigned'
#95: FILE: lib/librte_kni/rte_kni_fifo.h:62:
+ unsigned fifo_read = __KNI_LOAD_ACQUIRE(&fifo->read);
WARNING:UNSPECIFIED_INT: Prefer 'unsigned int' to bare use of 'unsigned'
#115: FILE: lib/librte_kni/rte_kni_fifo.h:84:
+ unsigned fifo_write = __KNI_LOAD_ACQUIRE(&fifo->write);
WARNING:UNSPECIFIED_INT: Prefer 'unsigned int' to bare use of 'unsigned'
#136: FILE: lib/librte_kni/rte_kni_fifo.h:103:
+ unsigned fifo_write = __KNI_LOAD_ACQUIRE(&fifo->write);
WARNING:UNSPECIFIED_INT: Prefer 'unsigned int' to bare use of 'unsigned'
#137: FILE: lib/librte_kni/rte_kni_fifo.h:104:
+ unsigned fifo_read = __KNI_LOAD_ACQUIRE(&fifo->read);
total: 2 errors, 8 warnings, 95 lines checked
parent reply other threads:[~2018-10-08 9:13 UTC|newest]
Thread overview: expand[flat|nested] mbox.gz Atom feed
[parent not found: <1538989906-8349-4-git-send-email-phil.yang@arm.com>]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20181008091336.BC2434C8F@dpdk.org \
--to=checkpatch@dpdk.org \
--cc=phil.yang@arm.com \
--cc=test-report@dpdk.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).