From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <checkpatch@dpdk.org>
Received: by dpdk.org (Postfix, from userid 1017)
 id BC2434C8F; Mon,  8 Oct 2018 11:13:36 +0200 (CEST)
In-Reply-To: <1538989906-8349-4-git-send-email-phil.yang@arm.com>
References: <1538989906-8349-4-git-send-email-phil.yang@arm.com>
To: test-report@dpdk.org
Cc: Phil Yang <phil.yang@arm.com>
Message-Id: <20181008091336.BC2434C8F@dpdk.org>
Date: Mon,  8 Oct 2018 11:13:36 +0200 (CEST)
From: checkpatch@dpdk.org
Subject: [dpdk-test-report] |WARNING| pw46242 [v3,
	4/4] kni: introduce c11 atomic into kni fifo synchronization
X-BeenThere: test-report@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: automatic DPDK test reports <test-report.dpdk.org>
List-Unsubscribe: <https://mails.dpdk.org/options/test-report>,
 <mailto:test-report-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://mails.dpdk.org/archives/test-report/>
List-Post: <mailto:test-report@dpdk.org>
List-Help: <mailto:test-report-request@dpdk.org?subject=help>
List-Subscribe: <https://mails.dpdk.org/listinfo/test-report>,
 <mailto:test-report-request@dpdk.org?subject=subscribe>
X-List-Received-Date: Mon, 08 Oct 2018 09:13:37 -0000

Test-Label: checkpatch
Test-Status: WARNING
http://dpdk.org/patch/46242

_coding style issues_


WARNING:UNSPECIFIED_INT: Prefer 'unsigned int' to bare use of 'unsigned'
#39: FILE: lib/librte_eal/linuxapp/eal/include/exec-env/rte_kni_common.h:59:
+	unsigned write;              /**< Next position to be written*/

WARNING:UNSPECIFIED_INT: Prefer 'unsigned int' to bare use of 'unsigned'
#40: FILE: lib/librte_eal/linuxapp/eal/include/exec-env/rte_kni_common.h:60:
+	unsigned read;               /**< Next position to be read */

WARNING:SINGLE_STATEMENT_DO_WHILE_MACRO: Single statement macros should not use a do {} while (0) loop
#70: FILE: lib/librte_kni/rte_kni_fifo.h:22:
+#define __KNI_STORE_RELEASE(dst, value) do {               \
+		__atomic_store_n((dst), value, __ATOMIC_RELEASE);   \
+	} while(0)

ERROR:SPACING: space required before the open parenthesis '('
#72: FILE: lib/librte_kni/rte_kni_fifo.h:24:
+	} while(0)

WARNING:SPACING: space prohibited between function name and open parenthesis '('
#75: FILE: lib/librte_kni/rte_kni_fifo.h:27:
+		typeof (*(src)) val = *(src);                       \

ERROR:SPACING: space required before the open parenthesis '('
#82: FILE: lib/librte_kni/rte_kni_fifo.h:34:
+	} while(0)

WARNING:UNSPECIFIED_INT: Prefer 'unsigned int' to bare use of 'unsigned'
#95: FILE: lib/librte_kni/rte_kni_fifo.h:62:
+	unsigned fifo_read = __KNI_LOAD_ACQUIRE(&fifo->read);

WARNING:UNSPECIFIED_INT: Prefer 'unsigned int' to bare use of 'unsigned'
#115: FILE: lib/librte_kni/rte_kni_fifo.h:84:
+	unsigned fifo_write = __KNI_LOAD_ACQUIRE(&fifo->write);

WARNING:UNSPECIFIED_INT: Prefer 'unsigned int' to bare use of 'unsigned'
#136: FILE: lib/librte_kni/rte_kni_fifo.h:103:
+	unsigned fifo_write = __KNI_LOAD_ACQUIRE(&fifo->write);

WARNING:UNSPECIFIED_INT: Prefer 'unsigned int' to bare use of 'unsigned'
#137: FILE: lib/librte_kni/rte_kni_fifo.h:104:
+	unsigned fifo_read = __KNI_LOAD_ACQUIRE(&fifo->read);

total: 2 errors, 8 warnings, 95 lines checked