From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <checkpatch@dpdk.org>
Received: by dpdk.org (Postfix, from userid 1017)
 id ABB3A6C9B; Wed, 24 Oct 2018 10:19:26 +0200 (CEST)
In-Reply-To: <20181024081833.21432-2-olivier.matz@6wind.com>
References: <20181024081833.21432-2-olivier.matz@6wind.com>
To: test-report@dpdk.org
Cc: Olivier Matz <olivier.matz@6wind.com>
Message-Id: <20181024081926.ABB3A6C9B@dpdk.org>
Date: Wed, 24 Oct 2018 10:19:26 +0200 (CEST)
From: checkpatch@dpdk.org
Subject: [dpdk-test-report] |WARNING| pw47290 [RFC,
	01/14] net: add rte prefix to arp structures
X-BeenThere: test-report@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: automatic DPDK test reports <test-report.dpdk.org>
List-Unsubscribe: <https://mails.dpdk.org/options/test-report>,
 <mailto:test-report-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://mails.dpdk.org/archives/test-report/>
List-Post: <mailto:test-report@dpdk.org>
List-Help: <mailto:test-report-request@dpdk.org?subject=help>
List-Subscribe: <https://mails.dpdk.org/listinfo/test-report>,
 <mailto:test-report-request@dpdk.org?subject=subscribe>
X-List-Received-Date: Wed, 24 Oct 2018 08:19:27 -0000

Test-Label: checkpatch
Test-Status: WARNING
http://dpdk.org/patch/47290

_coding style issues_


ERROR:SPACING: space prohibited before that close parenthesis ')'
#54: FILE: app/test-pmd/icmpecho.c:41:
+	switch (arp_opcode ) {

CHECK:SPACING: No space is necessary after a cast
#222: FILE: drivers/net/bonding/rte_eth_bond_alb.c:84:
+	arp = (struct rte_arp_hdr *) ((char *) (eth_h + 1) + offset);

ERROR:COMPLEX_MACRO: Macros with complex values should be enclosed in parentheses
#313: FILE: drivers/net/bonding/rte_eth_bond_pmd.c:569:
+#define MODE6_DEBUG(info, src_ip, dst_ip, eth_h, arp_opcode, port, burstnumber) \
 	rte_log(RTE_LOG_DEBUG, bond_logtype,				\
 		"%s port:%d SrcMAC:%02X:%02X:%02X:%02X:%02X:%02X SrcIP:%s " \
 		"DstMAC:%02X:%02X:%02X:%02X:%02X:%02X DstIP:%s %s %d
", \

CHECK:CAMELCASE: Avoid CamelCase: <ArpOp>
#344: FILE: drivers/net/bonding/rte_eth_bond_pmd.c:620:
+		arp_opcode_name(rte_be_to_cpu_16(arp_h->arp_opcode), ArpOp);

WARNING:LONG_LINE: line over 90 characters
#353: FILE: drivers/net/bonding/rte_eth_bond_pmd.c:1128:
+				pkt_size = sizeof(struct ether_hdr) + sizeof(struct rte_arp_hdr)

WARNING:LONG_LINE: line over 90 characters
#472: FILE: examples/bond/main.c:370:
+				arp_hdr = (struct rte_arp_hdr *)((char *)(eth_hdr + 1) + offset);

WARNING:LONG_LINE: line over 90 characters
#476: FILE: examples/bond/main.c:372:
+					if (arp_hdr->arp_opcode == rte_cpu_to_be_16(ARP_OP_REQUEST)) {

WARNING:LONG_LINE: line over 90 characters
#477: FILE: examples/bond/main.c:373:
+						arp_hdr->arp_opcode = rte_cpu_to_be_16(ARP_OP_REPLY);

WARNING:LONG_LINE: line over 90 characters
#686: FILE: test/test/test_link_bonding.c:4549:
+			arp_pkt = (struct rte_arp_hdr *)((char *)eth_pkt + sizeof(struct ether_hdr));

WARNING:LONG_LINE: line over 90 characters
#740: FILE: test/test/test_link_bonding.c:4670:
+			arp_pkt = (struct rte_arp_hdr *)((char *)eth_pkt + sizeof(struct ether_hdr));

total: 2 errors, 6 warnings, 599 lines checked