From: checkpatch@dpdk.org
To: test-report@dpdk.org
Cc: Olivier Matz <olivier.matz@6wind.com>
Subject: [dpdk-test-report] |WARNING| pw47292 [RFC, 04/14] net: add rte prefix to ether functions
Date: Wed, 24 Oct 2018 10:19:32 +0200 (CEST) [thread overview]
Message-ID: <20181024081932.BD19A6C9B@dpdk.org> (raw)
In-Reply-To: <20181024081833.21432-5-olivier.matz@6wind.com>
Test-Label: checkpatch
Test-Status: WARNING
http://dpdk.org/patch/47292
_coding style issues_
WARNING:COMMIT_LOG_LONG_LINE: Possible unwrapped commit description (prefer a maximum 75 chars per line)
#23:
- rename is_valid_assigned_ether_addr() as rte_is_valid_assigned_ether_addr().
WARNING:LONG_LINE: line over 90 characters
#287: FILE: app/test-pmd/icmpecho.c:401:
+ rte_ether_addr_copy(&arp_h->arp_data.arp_sha, &arp_h->arp_data.arp_tha);
ERROR:SPACING: space required after that ',' (ctx:VxO)
#365: FILE: app/test-pmd/txonly.c:230:
+ rte_ether_addr_copy(&peer_eth_addrs[fs->peer_addr],ð_hdr.d_addr);
^
ERROR:SPACING: space required before that '&' (ctx:OxV)
#365: FILE: app/test-pmd/txonly.c:230:
+ rte_ether_addr_copy(&peer_eth_addrs[fs->peer_addr],ð_hdr.d_addr);
^
WARNING:LONG_LINE: line over 90 characters
#723: FILE: drivers/net/bonding/rte_eth_bond_8023ad.c:697:
+ rte_is_same_ether_addr(&agg->partner.system, &port->partner.system) == 1
WARNING:LONG_LINE: line over 90 characters
#763: FILE: drivers/net/bonding/rte_eth_bond_alb.c:104:
+ !rte_is_same_ether_addr(&client_info->cli_mac, &arp->arp_data.arp_sha) ||
WARNING:LONG_LINE: line over 90 characters
#794: FILE: drivers/net/bonding/rte_eth_bond_alb.c:158:
+ if (!rte_is_broadcast_ether_addr(&arp->arp_data.arp_tha)) {
WARNING:LONG_LINE: line over 90 characters
#801: FILE: drivers/net/bonding/rte_eth_bond_alb.c:164:
+ rte_ether_addr_copy(&client_info->app_mac, &arp->arp_data.arp_sha);
WARNING:LONG_LINE: line over 90 characters
#853: FILE: drivers/net/bonding/rte_eth_bond_pmd.c:454:
+ !rte_is_same_ether_addr(&bond_mac, &hdr->d_addr)))) {
WARNING:LONG_LINE: line over 90 characters
#872: FILE: drivers/net/bonding/rte_eth_bond_pmd.c:1029:
+ if (rte_is_same_ether_addr(ðer_hdr->s_addr, &primary_slave_addr))
WARNING:LONG_LINE: line over 90 characters
#873: FILE: drivers/net/bonding/rte_eth_bond_pmd.c:1030:
+ rte_ether_addr_copy(&active_slave_addr, ðer_hdr->s_addr);
CHECK:SPACING: No space is necessary after a cast
#986: FILE: drivers/net/e1000/em_ethdev.c:296:
+ rte_ether_addr_copy((struct rte_ether_addr *) hw->mac.addr,
WARNING:LONG_LINE: line over 90 characters
#999: FILE: drivers/net/e1000/igb_ethdev.c:822:
+ rte_ether_addr_copy((struct rte_ether_addr *)hw->mac.addr, ð_dev->data->mac_addrs[0]);
CHECK:SPACING: No space is necessary after a cast
#1019: FILE: drivers/net/e1000/igb_ethdev.c:1042:
+ rte_ether_addr_copy((struct rte_ether_addr *) hw->mac.perm_addr,
CHECK:SPACING: No space is necessary after a cast
#1108: FILE: drivers/net/enic/enic_main.c:1678:
+ rte_ether_addr_copy((struct rte_ether_addr *) enic->mac_addr,
CHECK:SPACING: No space is necessary after a cast
#1199: FILE: drivers/net/i40e/i40e_ethdev.c:1460:
+ rte_ether_addr_copy((struct rte_ether_addr *) hw->mac.addr,
CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses around pf->dev_addr
#1226: FILE: drivers/net/i40e/i40e_ethdev.c:4071:
+ if (add && rte_is_same_ether_addr(new_mac, &(pf->dev_addr))) {
CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses around pf->dev_addr
#1244: FILE: drivers/net/i40e/i40e_ethdev.c:4100:
+ if (rte_is_same_ether_addr(&(pf->dev_addr), new_mac))
ERROR:SPACING: space required before the open parenthesis '('
#1506: FILE: drivers/net/i40e/i40e_pf.c:890:
+ if(rte_is_zero_ether_addr(mac) ||
CHECK:SPACING: No space is necessary after a cast
#1562: FILE: drivers/net/ixgbe/ixgbe_ethdev.c:1218:
+ rte_ether_addr_copy((struct rte_ether_addr *) hw->mac.perm_addr,
CHECK:ASSIGNMENT_CONTINUATIONS: Assignment operator '=' should be on the previous line
#2262: FILE: drivers/net/virtio/virtio_ethdev.c:1021:
struct virtio_net_ctrl_mac *tbl
+ = rte_is_multicast_ether_addr(addr) ? mc : uc;
CHECK:SPACING: No space is necessary after a cast
#2284: FILE: drivers/net/virtio/virtio_ethdev.c:1486:
+ rte_ether_addr_copy((struct rte_ether_addr *) hw->mac_addr,
CHECK:SPACING: No space is necessary after a cast
#2312: FILE: drivers/net/vmxnet3/vmxnet3_ethdev.c:314:
+ rte_ether_addr_copy((struct rte_ether_addr *) hw->perm_addr,
WARNING:LONG_LINE: line over 90 characters
#2334: FILE: examples/bond/main.c:375:
+ rte_ether_addr_copy(ð_hdr->s_addr, ð_hdr->d_addr);
WARNING:LONG_LINE: line over 90 characters
#2337: FILE: examples/bond/main.c:377:
+ rte_ether_addr_copy(&arp_hdr->arp_data.arp_sha, &arp_hdr->arp_data.arp_tha);
WARNING:LONG_LINE: line over 90 characters
#2341: FILE: examples/bond/main.c:380:
+ rte_ether_addr_copy(&d_addr, &arp_hdr->arp_data.arp_sha);
WARNING:LONG_LINE: line over 90 characters
#2350: FILE: examples/bond/main.c:395:
+ rte_ether_addr_copy(ð_hdr->s_addr, ð_hdr->d_addr);
WARNING:LONG_LINE: line over 90 characters
#3379: FILE: test/test/test_link_bonding.c:4552:
+ if (!rte_is_same_ether_addr(slave_mac1, &arp_pkt->arp_data.arp_sha)) {
WARNING:LONG_LINE: line over 90 characters
#3385: FILE: test/test/test_link_bonding.c:4557:
+ if (!rte_is_same_ether_addr(slave_mac2, &arp_pkt->arp_data.arp_sha)) {
WARNING:LONG_LINE: line over 90 characters
#3403: FILE: test/test/test_link_bonding.c:4673:
+ if (!rte_is_same_ether_addr(slave_mac1, &arp_pkt->arp_data.arp_sha)) {
WARNING:LONG_LINE: line over 90 characters
#3409: FILE: test/test/test_link_bonding.c:4678:
+ if (!rte_is_same_ether_addr(slave_mac2, &arp_pkt->arp_data.arp_sha)) {
total: 3 errors, 18 warnings, 2645 lines checked
parent reply other threads:[~2018-10-24 8:19 UTC|newest]
Thread overview: expand[flat|nested] mbox.gz Atom feed
[parent not found: <20181024081833.21432-5-olivier.matz@6wind.com>]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20181024081932.BD19A6C9B@dpdk.org \
--to=checkpatch@dpdk.org \
--cc=olivier.matz@6wind.com \
--cc=test-report@dpdk.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).