automatic DPDK test reports
 help / color / mirror / Atom feed
From: checkpatch@dpdk.org
To: test-report@dpdk.org
Cc: Olivier Matz <olivier.matz@6wind.com>
Subject: [dpdk-test-report] |WARNING| pw47298 [RFC, 10/14] net: add rte prefix to ip structure
Date: Wed, 24 Oct 2018 10:21:25 +0200 (CEST)	[thread overview]
Message-ID: <20181024082125.3C354695D@dpdk.org> (raw)
In-Reply-To: <20181024081833.21432-11-olivier.matz@6wind.com>

Test-Label: checkpatch
Test-Status: WARNING
http://dpdk.org/patch/47298

_coding style issues_


WARNING:LONG_LINE: line over 90 characters
#1524: FILE: examples/bond/main.c:393:
+				ipv4_hdr = (struct rte_ipv4_hdr *)((char *)(eth_hdr + 1) + offset);

WARNING:LONG_LINE: line over 90 characters
#1833: FILE: examples/ipv4_multicast/main.c:319:
+	iphdr = (struct rte_ipv4_hdr *)rte_pktmbuf_adj(m, (uint16_t)sizeof(struct rte_ether_hdr));

ERROR:POINTER_LOCATION: "foo * bar" should be "foo *bar"
#3793: FILE: lib/librte_ip_frag/rte_ip_frag.h:298:
+rte_ipv4_frag_pkt_is_fragmented(const struct rte_ipv4_hdr * hdr) {

WARNING:SPACING: space prohibited between function name and open parenthesis '('
#3839: FILE: lib/librte_ip_frag/rte_ipv4_fragmentation.c:95:
+	    (uint16_t)(pkt_in->pkt_len - sizeof (struct rte_ipv4_hdr))))

WARNING:SPACING: space prohibited between function name and open parenthesis '('
#3954: FILE: lib/librte_ip_frag/rte_ipv6_fragmentation.c:88:
+	    (uint16_t)(pkt_in->pkt_len - sizeof (struct rte_ipv6_hdr))))

WARNING:LONG_LINE: line over 90 characters
#3981: FILE: lib/librte_ip_frag/rte_ipv6_fragmentation.c:112:
+		out_pkt->data_len = sizeof(struct rte_ipv6_hdr) + sizeof(struct ipv6_extension_fragment);

WARNING:LONG_LINE: line over 90 characters
#3982: FILE: lib/librte_ip_frag/rte_ipv6_fragmentation.c:113:
+		out_pkt->pkt_len  = sizeof(struct rte_ipv6_hdr) + sizeof(struct ipv6_extension_fragment);

WARNING:LONG_LINE: line over 90 characters
#4578: FILE: test/test/packet_burst_generator.c:303:
+			copy_buf_to_pkt(ip_hdr, sizeof(struct rte_ipv4_hdr), pkt, eth_hdr_size);

WARNING:LONG_LINE: line over 90 characters
#4584: FILE: test/test/packet_burst_generator.c:307:
+			copy_buf_to_pkt(ip_hdr, sizeof(struct rte_ipv6_hdr), pkt, eth_hdr_size);

WARNING:LONG_LINE: line over 90 characters
#4838: FILE: test/test/test_sched.c:90:
+	ip_hdr = (struct rte_ipv4_hdr *)((uintptr_t)eth_hdr +  sizeof(eth_hdr->ether_type));

total: 1 errors, 9 warnings, 3993 lines checked

           reply	other threads:[~2018-10-24  8:21 UTC|newest]

Thread overview: expand[flat|nested]  mbox.gz  Atom feed
 [parent not found: <20181024081833.21432-11-olivier.matz@6wind.com>]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20181024082125.3C354695D@dpdk.org \
    --to=checkpatch@dpdk.org \
    --cc=olivier.matz@6wind.com \
    --cc=test-report@dpdk.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).