automatic DPDK test reports
 help / color / mirror / Atom feed
From: checkpatch@dpdk.org
To: test-report@dpdk.org
Cc: Olivier Matz <olivier.matz@6wind.com>
Subject: [dpdk-test-report] |WARNING| pw47310 [RFC, 05/14] net: add rte prefix to ether defines
Date: Wed, 24 Oct 2018 11:13:49 +0200 (CEST)	[thread overview]
Message-ID: <20181024091350.0073D1B127@dpdk.org> (raw)
In-Reply-To: <20181024081833.21432-6-olivier.matz@6wind.com>

Test-Label: checkpatch
Test-Status: WARNING
http://dpdk.org/patch/47310

_coding style issues_


CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses around 'mtu < RTE_ETHER_MIN_MTU'
#921: FILE: drivers/net/atlantic/atl_ethdev.c:1262:
+	if ((mtu < RTE_ETHER_MIN_MTU) || (frame_size > dev_info.max_rx_pktlen))

CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses around 'frame_size > dev_info.max_rx_pktlen'
#921: FILE: drivers/net/atlantic/atl_ethdev.c:1262:
+	if ((mtu < RTE_ETHER_MIN_MTU) || (frame_size > dev_info.max_rx_pktlen))

CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses around 'new_mtu < RTE_ETHER_MIN_MTU'
#1981: FILE: drivers/net/cxgbe/cxgbe_ethdev.c:284:
+	if ((new_mtu < RTE_ETHER_MIN_MTU) || (new_mtu > dev_info.max_rx_pktlen))

CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses around 'new_mtu > dev_info.max_rx_pktlen'
#1981: FILE: drivers/net/cxgbe/cxgbe_ethdev.c:284:
+	if ((new_mtu < RTE_ETHER_MIN_MTU) || (new_mtu > dev_info.max_rx_pktlen))

CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses around 'm->pkt_len > RTE_ETHER_MAX_LEN'
#2223: FILE: drivers/net/cxgbe/sge.c:1147:
+	if (!((m->ol_flags & PKT_TX_TCP_SEG) || (m->pkt_len > RTE_ETHER_MAX_LEN))) {

CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses around 'mtu < RTE_ETHER_MIN_MTU'
#2345: FILE: drivers/net/dpaa2/dpaa2_ethdev.c:1030:
+	if ((mtu < RTE_ETHER_MIN_MTU) || (frame_size > DPAA2_MAX_RX_PKT_LEN))

CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses around 'frame_size > DPAA2_MAX_RX_PKT_LEN'
#2345: FILE: drivers/net/dpaa2/dpaa2_ethdev.c:1030:
+	if ((mtu < RTE_ETHER_MIN_MTU) || (frame_size > DPAA2_MAX_RX_PKT_LEN))

CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses around 'mtu < RTE_ETHER_MIN_MTU'
#2453: FILE: drivers/net/e1000/em_ethdev.c:1781:
+	if ((mtu < RTE_ETHER_MIN_MTU) || (frame_size > dev_info.max_rx_pktlen))

CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses around 'frame_size > dev_info.max_rx_pktlen'
#2453: FILE: drivers/net/e1000/em_ethdev.c:1781:
+	if ((mtu < RTE_ETHER_MIN_MTU) || (frame_size > dev_info.max_rx_pktlen))

CHECK:SPACING: No space is necessary after a cast
#2488: FILE: drivers/net/e1000/em_rxtx.c:1016:
+					(uint16_t) (data_len - RTE_ETHER_CRC_LEN);

CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses around 'mtu < RTE_ETHER_MIN_MTU'
#2660: FILE: drivers/net/e1000/igb_ethdev.c:4465:
+	if ((mtu < RTE_ETHER_MIN_MTU) ||
 	    (frame_size > dev_info.max_rx_pktlen))

CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses around 'frame_size > dev_info.max_rx_pktlen'
#2660: FILE: drivers/net/e1000/igb_ethdev.c:4465:
+	if ((mtu < RTE_ETHER_MIN_MTU) ||
 	    (frame_size > dev_info.max_rx_pktlen))

WARNING:LONG_LINE: line over 90 characters
#2748: FILE: drivers/net/e1000/igb_pf.c:406:
+	if ((max_frame < RTE_ETHER_MIN_LEN) || (max_frame > RTE_ETHER_MAX_JUMBO_FRAME_LEN))

CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses around 'max_frame < RTE_ETHER_MIN_LEN'
#2748: FILE: drivers/net/e1000/igb_pf.c:406:
+	if ((max_frame < RTE_ETHER_MIN_LEN) || (max_frame > RTE_ETHER_MAX_JUMBO_FRAME_LEN))

CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses around 'max_frame > RTE_ETHER_MAX_JUMBO_FRAME_LEN'
#2748: FILE: drivers/net/e1000/igb_pf.c:406:
+	if ((max_frame < RTE_ETHER_MIN_LEN) || (max_frame > RTE_ETHER_MAX_JUMBO_FRAME_LEN))

CHECK:SPACING: No space is necessary after a cast
#2774: FILE: drivers/net/e1000/igb_rxtx.c:1156:
+					(uint16_t) (data_len - RTE_ETHER_CRC_LEN);

CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses around 'mtu < RTE_ETHER_MIN_MTU'
#3137: FILE: drivers/net/i40e/i40e_ethdev.c:11895:
+	if ((mtu < RTE_ETHER_MIN_MTU) || (frame_size > I40E_FRAME_SIZE_MAX))

CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses around 'frame_size > I40E_FRAME_SIZE_MAX'
#3137: FILE: drivers/net/i40e/i40e_ethdev.c:11895:
+	if ((mtu < RTE_ETHER_MIN_MTU) || (frame_size > I40E_FRAME_SIZE_MAX))

CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses around 'mtu < RTE_ETHER_MIN_MTU'
#3215: FILE: drivers/net/i40e/i40e_ethdev_vf.c:2614:
+	if ((mtu < RTE_ETHER_MIN_MTU) || (frame_size > I40E_FRAME_SIZE_MAX))

CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses around 'frame_size > I40E_FRAME_SIZE_MAX'
#3215: FILE: drivers/net/i40e/i40e_ethdev_vf.c:2614:
+	if ((mtu < RTE_ETHER_MIN_MTU) || (frame_size > I40E_FRAME_SIZE_MAX))

CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses around 'mtu < RTE_ETHER_MIN_MTU'
#3610: FILE: drivers/net/ixgbe/ixgbe_ethdev.c:4923:
+	if ((mtu < RTE_ETHER_MIN_MTU) || (frame_size > dev_info.max_rx_pktlen))

CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses around 'frame_size > dev_info.max_rx_pktlen'
#3610: FILE: drivers/net/ixgbe/ixgbe_ethdev.c:4923:
+	if ((mtu < RTE_ETHER_MIN_MTU) || (frame_size > dev_info.max_rx_pktlen))

CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses around 'mtu < RTE_ETHER_MIN_MTU'
#3634: FILE: drivers/net/ixgbe/ixgbe_ethdev.c:6312:
+	if ((mtu < RTE_ETHER_MIN_MTU) || (max_frame > RTE_ETHER_MAX_JUMBO_FRAME_LEN))

CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses around 'max_frame > RTE_ETHER_MAX_JUMBO_FRAME_LEN'
#3634: FILE: drivers/net/ixgbe/ixgbe_ethdev.c:6312:
+	if ((mtu < RTE_ETHER_MIN_MTU) || (max_frame > RTE_ETHER_MAX_JUMBO_FRAME_LEN))

WARNING:LONG_LINE: line over 90 characters
#3776: FILE: drivers/net/ixgbe/ixgbe_pf.c:565:
+	if ((max_frame < RTE_ETHER_MIN_LEN) || (max_frame > RTE_ETHER_MAX_JUMBO_FRAME_LEN))

CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses around 'max_frame < RTE_ETHER_MIN_LEN'
#3776: FILE: drivers/net/ixgbe/ixgbe_pf.c:565:
+	if ((max_frame < RTE_ETHER_MIN_LEN) || (max_frame > RTE_ETHER_MAX_JUMBO_FRAME_LEN))

CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses around 'max_frame > RTE_ETHER_MAX_JUMBO_FRAME_LEN'
#3776: FILE: drivers/net/ixgbe/ixgbe_pf.c:565:
+	if ((max_frame < RTE_ETHER_MIN_LEN) || (max_frame > RTE_ETHER_MAX_JUMBO_FRAME_LEN))

CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses around 'vlan > RTE_ETHER_MAX_VLAN_ID'
#3838: FILE: drivers/net/ixgbe/rte_pmd_ixgbe.c:479:
+	if ((vlan > RTE_ETHER_MAX_VLAN_ID) || (vf_mask == 0))

CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses around 'vf_mask == 0'
#3838: FILE: drivers/net/ixgbe/rte_pmd_ixgbe.c:479:
+	if ((vlan > RTE_ETHER_MAX_VLAN_ID) || (vf_mask == 0))

CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses around 'mtu < RTE_ETHER_MIN_MTU'
#3860: FILE: drivers/net/liquidio/lio_ethdev.c:447:
+	if ((mtu < RTE_ETHER_MIN_MTU) || (mtu > pf_mtu)) {

CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses around 'mtu > pf_mtu'
#3860: FILE: drivers/net/liquidio/lio_ethdev.c:447:
+	if ((mtu < RTE_ETHER_MIN_MTU) || (mtu > pf_mtu)) {

WARNING:FUNCTION_ARGUMENTS: function definition argument 'uint8_t' should also have an identifier name
#3938: FILE: drivers/net/mlx4/mlx4.h:118:
+int mlx4_get_mac(struct priv *priv, uint8_t (*mac)[RTE_ETHER_ADDR_LEN]);

WARNING:BRACES: braces {} are not necessary for single statement blocks
#3986: FILE: drivers/net/mlx4/mlx4_flow.c:255:
+	for (i = 0; i < RTE_ETHER_ADDR_LEN; ++i) {
 		eth->val.dst_mac[i] &= eth->mask.dst_mac[i];
 	}

WARNING:FUNCTION_ARGUMENTS: function definition argument 'uint8_t' should also have an identifier name
#4025: FILE: drivers/net/mlx5/mlx5.h:286:
+int mlx5_get_mac(struct rte_eth_dev *dev, uint8_t (*mac)[RTE_ETHER_ADDR_LEN]);

CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses around 'mtu < RTE_ETHER_MIN_MTU'
#4508: FILE: drivers/net/nfp/nfp_net.c:1425:
+	if ((mtu < RTE_ETHER_MIN_MTU) || ((uint32_t)mtu > hw->max_mtu))

CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses around 'mtu < RTE_ETHER_MIN_MTU'
#4746: FILE: drivers/net/qede/qede_ethdev.c:2234:
+	if ((mtu < RTE_ETHER_MIN_MTU) || (frame_size > dev_info.max_rx_pktlen)) {

CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses around 'frame_size > dev_info.max_rx_pktlen'
#4746: FILE: drivers/net/qede/qede_ethdev.c:2234:
+	if ((mtu < RTE_ETHER_MIN_MTU) || (frame_size > dev_info.max_rx_pktlen)) {

WARNING:LONG_LINE: line over 90 characters
#5377: FILE: drivers/net/virtio/virtio_ethdev.c:1659:
+	eth_dev->data->mac_addrs = rte_zmalloc("virtio", VIRTIO_MAX_MAC_ADDRS * RTE_ETHER_ADDR_LEN, 0);

WARNING:LONG_LINE_COMMENT: line over 90 characters
#6213: FILE: examples/performance-thread/l3fwd-thread/main.c:2978:
+				/* if no max-pkt-len set, use the default value RTE_ETHER_MAX_LEN */

WARNING:UNSPECIFIED_INT: Prefer 'unsigned int' to bare use of 'unsigned'
#6522: FILE: lib/librte_ethdev/rte_ethdev.c:1133:
+				(unsigned)RTE_ETHER_MIN_LEN);

WARNING:LONG_LINE: line over 90 characters
#7433: FILE: test/test/test_link_bonding.c:3989:
+					(struct rte_ether_addr *)dst_mac_0, RTE_ETHER_TYPE_IPv4, 0, 0);

WARNING:LONG_LINE: line over 90 characters
#7438: FILE: test/test/test_link_bonding.c:3993:
+					(struct rte_ether_addr *)dst_mac_0, RTE_ETHER_TYPE_IPv4, 0, 0);

WARNING:LONG_LINE: line over 90 characters
#7564: FILE: test/test/test_link_bonding.c:4767:
+			if (vlan_pkt->eth_proto != rte_cpu_to_be_16(RTE_ETHER_TYPE_VLAN)) {

total: 0 errors, 11 warnings, 6100 lines checked

           reply	other threads:[~2018-10-24  9:13 UTC|newest]

Thread overview: expand[flat|nested]  mbox.gz  Atom feed
 [parent not found: <20181024081833.21432-6-olivier.matz@6wind.com>]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20181024091350.0073D1B127@dpdk.org \
    --to=checkpatch@dpdk.org \
    --cc=olivier.matz@6wind.com \
    --cc=test-report@dpdk.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).