* [dpdk-test-report] |WARNING| pw47328 [4/5] net/softnic: update cli parsing
[not found] <20181024124905.5379-5-roy.fan.zhang@intel.com>
@ 2018-10-24 12:49 ` checkpatch
0 siblings, 0 replies; only message in thread
From: checkpatch @ 2018-10-24 12:49 UTC (permalink / raw)
To: test-report; +Cc: Fan Zhang
Test-Label: checkpatch
Test-Status: WARNING
http://dpdk.org/patch/47328
_coding style issues_
CHECK:BRACES: braces {} should be used on all arms of this statement
#63: FILE: drivers/net/softnic/rte_eth_softnic_cli.c:1116:
+ if (strcmp(tokens[2], "dev") == 0)
[...]
+ else if (strcmp(tokens[2], "dev_id") == 0) {
[...]
+ } else {
[...]
CHECK:BRACES: Blank lines aren't necessary before a close brace '}'
#265: FILE: drivers/net/softnic/rte_eth_softnic_cli.c:4034:
+
+}
CHECK:OPEN_ENDED_LINE: Lines should not end with a '('
#290: FILE: drivers/net/softnic/rte_eth_softnic_cli.c:4059:
+ status = rte_cryptodev_get_cipher_algo_enum(
WARNING:UNNECESSARY_ELSE: else is not generally useful after a break or return
#404: FILE: drivers/net/softnic/rte_eth_softnic_cli.c:4173:
+ return xform_cipher;
+ } else {
CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses around 'n_tokens < 12'
#532: FILE: drivers/net/softnic/rte_eth_softnic_cli.c:4301:
+ if ((n_tokens < 12) ||
+ strcmp(tokens[0], "sym_crypto") ||
+ strcmp(tokens[2], "type"))
total: 0 errors, 1 warnings, 4 checks, 579 lines checked
^ permalink raw reply [flat|nested] only message in thread
only message in thread, other threads:[~2018-10-24 12:49 UTC | newest]
Thread overview: (only message) (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
[not found] <20181024124905.5379-5-roy.fan.zhang@intel.com>
2018-10-24 12:49 ` [dpdk-test-report] |WARNING| pw47328 [4/5] net/softnic: update cli parsing checkpatch
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).