From: checkpatch@dpdk.org
To: test-report@dpdk.org
Cc: Honnappa Nagarahalli <honnappa.nagarahalli@arm.com>
Subject: [dpdk-test-report] |WARNING| pw48240 [RFC, 2/3] tqs: add thread quiescent state library
Date: Thu, 22 Nov 2018 04:33:11 +0100 (CET) [thread overview]
Message-ID: <20181122033311.63E7F1B209@dpdk.org> (raw)
In-Reply-To: <20181122033055.3431-3-honnappa.nagarahalli@arm.com>
Test-Label: checkpatch
Test-Status: WARNING
http://dpdk.org/patch/48240
_coding style issues_
ERROR:POINTER_LOCATION: "foo * bar" should be "foo *bar"
#148: FILE: lib/librte_tqs/rte_tqs.c:32:
+struct rte_tqs * __rte_experimental
WARNING:MACRO_WITH_FLOW_CONTROL: Macros with flow control statements should be avoided
#420: FILE: lib/librte_tqs/rte_tqs.h:49:
+#define TQS_RETURN_IF_TRUE(cond, retval) do { \
+ if ((cond)) \
+ return retval; \
+} while (0)
WARNING:MACRO_WITH_FLOW_CONTROL: Macros with flow control statements should be avoided
#429: FILE: lib/librte_tqs/rte_tqs.h:58:
+#define TQS_ERR_LOG_IF_TRUE(cond) do { \
+ if ((cond)) { \
+ RTE_LOG(ERR, TQS, "Invalid parameters
"); \
+ return; \
+ } \
+} while (0)
total: 1 errors, 2 warnings, 680 lines checked
parent reply other threads:[~2018-11-22 3:33 UTC|newest]
Thread overview: expand[flat|nested] mbox.gz Atom feed
[parent not found: <20181122033055.3431-3-honnappa.nagarahalli@arm.com>]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20181122033311.63E7F1B209@dpdk.org \
--to=checkpatch@dpdk.org \
--cc=honnappa.nagarahalli@arm.com \
--cc=test-report@dpdk.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).