From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <checkpatch@dpdk.org>
Received: by dpdk.org (Postfix, from userid 1017)
 id 63E7F1B209; Thu, 22 Nov 2018 04:33:11 +0100 (CET)
In-Reply-To: <20181122033055.3431-3-honnappa.nagarahalli@arm.com>
References: <20181122033055.3431-3-honnappa.nagarahalli@arm.com>
To: test-report@dpdk.org
Cc: Honnappa Nagarahalli <honnappa.nagarahalli@arm.com>
Message-Id: <20181122033311.63E7F1B209@dpdk.org>
Date: Thu, 22 Nov 2018 04:33:11 +0100 (CET)
From: checkpatch@dpdk.org
Subject: [dpdk-test-report] |WARNING| pw48240 [RFC,
	2/3] tqs: add thread quiescent state library
X-BeenThere: test-report@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: automatic DPDK test reports <test-report.dpdk.org>
List-Unsubscribe: <https://mails.dpdk.org/options/test-report>,
 <mailto:test-report-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://mails.dpdk.org/archives/test-report/>
List-Post: <mailto:test-report@dpdk.org>
List-Help: <mailto:test-report-request@dpdk.org?subject=help>
List-Subscribe: <https://mails.dpdk.org/listinfo/test-report>,
 <mailto:test-report-request@dpdk.org?subject=subscribe>
X-List-Received-Date: Thu, 22 Nov 2018 03:33:11 -0000

Test-Label: checkpatch
Test-Status: WARNING
http://dpdk.org/patch/48240

_coding style issues_


ERROR:POINTER_LOCATION: "foo * bar" should be "foo *bar"
#148: FILE: lib/librte_tqs/rte_tqs.c:32:
+struct rte_tqs * __rte_experimental

WARNING:MACRO_WITH_FLOW_CONTROL: Macros with flow control statements should be avoided
#420: FILE: lib/librte_tqs/rte_tqs.h:49:
+#define TQS_RETURN_IF_TRUE(cond, retval) do { \
+	if ((cond)) \
+		return retval; \
+} while (0)

WARNING:MACRO_WITH_FLOW_CONTROL: Macros with flow control statements should be avoided
#429: FILE: lib/librte_tqs/rte_tqs.h:58:
+#define TQS_ERR_LOG_IF_TRUE(cond) do { \
+	if ((cond)) { \
+		RTE_LOG(ERR, TQS, "Invalid parameters
"); \
+		return; \
+	} \
+} while (0)

total: 1 errors, 2 warnings, 680 lines checked