From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <checkpatch@dpdk.org>
Received: by dpdk.org (Postfix, from userid 1017)
 id 5B5B91B580; Fri, 23 Nov 2018 07:52:48 +0100 (CET)
In-Reply-To: <1542956179-80951-4-git-send-email-wenzhuo.lu@intel.com>
References: <1542956179-80951-4-git-send-email-wenzhuo.lu@intel.com>
To: test-report@dpdk.org
Cc: Wenzhuo Lu <wenzhuo.lu@intel.com>
Message-Id: <20181123065248.5B5B91B580@dpdk.org>
Date: Fri, 23 Nov 2018 07:52:48 +0100 (CET)
From: checkpatch@dpdk.org
Subject: [dpdk-test-report] |WARNING| pw48287 [03/19] net/ice: support
	device and queue ops
X-BeenThere: test-report@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: automatic DPDK test reports <test-report.dpdk.org>
List-Unsubscribe: <https://mails.dpdk.org/options/test-report>,
 <mailto:test-report-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://mails.dpdk.org/archives/test-report/>
List-Post: <mailto:test-report@dpdk.org>
List-Help: <mailto:test-report-request@dpdk.org?subject=help>
List-Subscribe: <https://mails.dpdk.org/listinfo/test-report>,
 <mailto:test-report-request@dpdk.org?subject=subscribe>
X-List-Received-Date: Fri, 23 Nov 2018 06:52:48 -0000

Test-Label: checkpatch
Test-Status: WARNING
http://dpdk.org/patch/48287

_coding style issues_


CHECK:BRACES: Unbalanced braces around else statement
#146: FILE: drivers/net/ice/ice_ethdev.c:693:
+	} else

CHECK:OPEN_ENDED_LINE: Lines should not end with a '('
#559: FILE: drivers/net/ice/ice_lan_rxtx.c:252:
+ice_check_rx_burst_bulk_alloc_preconditions(

WARNING:UNSPECIFIED_INT: Prefer 'unsigned int' to bare use of 'unsigned'
#596: FILE: drivers/net/ice/ice_lan_rxtx.c:289:
+	unsigned i;

WARNING:TYPO_SPELLING: 'disble' may be misspelled - perhaps 'disable'?
#872: FILE: drivers/net/ice/ice_lan_rxtx.c:565:
+		PMD_DRV_LOG(DEBUG, "Failed to disble Lan Tx queue");

CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses around 'tx_rs_thresh > 1'
#1125: FILE: drivers/net/ice/ice_lan_rxtx.c:818:
+	if ((tx_rs_thresh > 1) && (tx_conf->tx_thresh.wthresh != 0)) {

CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses around 'tx_conf->tx_thresh.wthresh != 0'
#1125: FILE: drivers/net/ice/ice_lan_rxtx.c:818:
+	if ((tx_rs_thresh > 1) && (tx_conf->tx_thresh.wthresh != 0)) {

total: 0 errors, 2 warnings, 4 checks, 1216 lines checked