* [dpdk-test-report] |WARNING| pw48307 libs/power: add p-state driver compatibility
[not found] <1542972781-6149-1-git-send-email-liang.j.ma@intel.com>
@ 2018-11-23 11:34 ` checkpatch
0 siblings, 0 replies; only message in thread
From: checkpatch @ 2018-11-23 11:34 UTC (permalink / raw)
To: test-report; +Cc: Liang Ma
Test-Label: checkpatch
Test-Status: WARNING
http://dpdk.org/patch/48307
_coding style issues_
WARNING:SINGLE_STATEMENT_DO_WHILE_MACRO: Single statement macros should not use a do {} while (0) loop
#105: FILE: lib/librte_power/power_pstate_cpufreq.c:24:
+#define POWER_DEBUG_TRACE(fmt, args...) do { \
+ RTE_LOG(ERR, POWER, "%s: " fmt, __func__, ## args); \
+} while (0)
WARNING:MACRO_WITH_FLOW_CONTROL: Macros with flow control statements should be avoided
#112: FILE: lib/librte_power/power_pstate_cpufreq.c:31:
+#define FOPEN_OR_ERR_RET(f, retval) do { \
+ if ((f) == NULL) { \
+ RTE_LOG(ERR, POWER, "File not openned
"); \
+ return retval; \
+ } \
+} while (0)
WARNING:MACRO_WITH_FLOW_CONTROL: Macros with flow control statements should be avoided
#119: FILE: lib/librte_power/power_pstate_cpufreq.c:38:
+#define FOPS_OR_NULL_GOTO(ret, label) do { \
+ if ((ret) == NULL) { \
+ RTE_LOG(ERR, POWER, "fgets returns nothing
"); \
+ goto label; \
+ } \
+} while (0)
WARNING:MACRO_WITH_FLOW_CONTROL: Macros with flow control statements should be avoided
#126: FILE: lib/librte_power/power_pstate_cpufreq.c:45:
+#define FOPS_OR_ERR_GOTO(ret, label) do { \
+ if ((ret) < 0) { \
+ RTE_LOG(ERR, POWER, "File operations failed
"); \
+ goto label; \
+ } \
+} while (0)
total: 0 errors, 4 warnings, 1112 lines checked
^ permalink raw reply [flat|nested] only message in thread