automatic DPDK test reports
 help / color / mirror / Atom feed
From: checkpatch@dpdk.org
To: test-report@dpdk.org
Cc: Nikhil Rao <nikhil.rao@intel.com>
Subject: [dpdk-test-report] |WARNING| pw48400 eventdev: fix eth Tx adapter queue count checks
Date: Thu, 29 Nov 2018 12:13:34 +0100 (CET)	[thread overview]
Message-ID: <20181129111334.D5F6D1B4B6@dpdk.org> (raw)
In-Reply-To: <1543489908-60688-1-git-send-email-nikhil.rao@intel.com>

Test-Label: checkpatch
Test-Status: WARNING
http://dpdk.org/patch/48400

_coding style issues_


WARNING:MACRO_WITH_FLOW_CONTROL: Macros with flow control statements should be avoided
#42: FILE: lib/librte_eventdev/rte_event_eth_tx_adapter.c:62:
+#define TXA_CHECK_TXQ(dev, queue) \
+do {\
+	if ((dev)->data->nb_tx_queues == 0) { \
+		RTE_EDEV_LOG_ERR("No tx queues configured"); \
+		return -EINVAL; \
+	} \
+	if (queue != -1 && (uint16_t)queue >= (dev)->data->nb_tx_queues) { \
+		RTE_EDEV_LOG_ERR("Invalid tx queue_id %" PRIu16, \
+				(uint16_t)queue); \
+		return -EINVAL; \
+	} \
+} while (0)

total: 0 errors, 1 warnings, 84 lines checked

           reply	other threads:[~2018-11-29 11:13 UTC|newest]

Thread overview: expand[flat|nested]  mbox.gz  Atom feed
 [parent not found: <1543489908-60688-1-git-send-email-nikhil.rao@intel.com>]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20181129111334.D5F6D1B4B6@dpdk.org \
    --to=checkpatch@dpdk.org \
    --cc=nikhil.rao@intel.com \
    --cc=test-report@dpdk.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).