From: checkpatch@dpdk.org
To: test-report@dpdk.org
Cc: Pallavi Kadam <pallavi.kadam@intel.com>
Subject: [dpdk-test-report] |WARNING| pw48401 helloworld: Windows DPDK sample application is compiled and built using eal and kvargs libraries in order to add windows support in the
Date: Thu, 29 Nov 2018 12:15:37 +0100 (CET) [thread overview]
Message-ID: <20181129111537.72BF61B4B6@dpdk.org> (raw)
In-Reply-To: <20181129050504.26996-1-pallavi.kadam@intel.com>
Test-Label: checkpatch
Test-Status: WARNING
http://dpdk.org/patch/48401
_coding style issues_
WARNING:COMMIT_MESSAGE: Missing commit description - Add an appropriate one
WARNING:BLOCK_COMMENT_STYLE: Block comments should align the * on each line
#513: FILE: lib/librte_eal/windows/eal/eal.c:2:
+/* SPDX-License-Identifier: BSD-3-Clause
+* Copyright(c) 2017-2018 Intel Corporation
ERROR:INITIALISED_STATIC: do not initialise statics to NULL
#542: FILE: lib/librte_eal/windows/eal/eal.c:31:
+static rte_usage_hook_t rte_application_usage_hook = NULL;
WARNING:BLOCK_COMMENT_STYLE: Block comments use a trailing */ on a separate line
#545: FILE: lib/librte_eal/windows/eal/eal.c:34:
+ * duration of the program, as we hold a write lock on it in the primary proc */
WARNING:BLOCK_COMMENT_STYLE: Block comments use * on subsequent lines
#549: FILE: lib/librte_eal/windows/eal/eal.c:38:
+/*
+static struct flock wr_lock = {
WARNING:AVOID_EXTERNS: externs should be avoided in .c files
#572: FILE: lib/librte_eal/windows/eal/eal.c:61:
+extern void businitfn_pci(void);
WARNING:AVOID_EXTERNS: externs should be avoided in .c files
#573: FILE: lib/librte_eal/windows/eal/eal.c:62:
+extern void businitfn_vdev(void);
WARNING:AVOID_EXTERNS: externs should be avoided in .c files
#576: FILE: lib/librte_eal/windows/eal/eal.c:65:
+extern void mp_hdlr_init_ops_mp_mc(void);
WARNING:AVOID_EXTERNS: externs should be avoided in .c files
#577: FILE: lib/librte_eal/windows/eal/eal.c:66:
+extern void mp_hdlr_init_ops_sp_sc(void);
WARNING:AVOID_EXTERNS: externs should be avoided in .c files
#578: FILE: lib/librte_eal/windows/eal/eal.c:67:
+extern void mp_hdlr_init_ops_mp_sc(void);
WARNING:AVOID_EXTERNS: externs should be avoided in .c files
#579: FILE: lib/librte_eal/windows/eal/eal.c:68:
+extern void mp_hdlr_init_ops_sp_mc(void);
WARNING:AVOID_EXTERNS: externs should be avoided in .c files
#582: FILE: lib/librte_eal/windows/eal/eal.c:71:
+extern void init_rte_mempool_tailq(void);
WARNING:AVOID_EXTERNS: externs should be avoided in .c files
#583: FILE: lib/librte_eal/windows/eal/eal.c:72:
+extern void init_rte_ring_tailq(void);
WARNING:AVOID_EXTERNS: externs should be avoided in .c files
#584: FILE: lib/librte_eal/windows/eal/eal.c:73:
+extern void init_rte_hash_tailq(void);
WARNING:AVOID_EXTERNS: externs should be avoided in .c files
#585: FILE: lib/librte_eal/windows/eal/eal.c:74:
+extern void init_rte_fbk_hash_tailq(void);
WARNING:AVOID_EXTERNS: externs should be avoided in .c files
#586: FILE: lib/librte_eal/windows/eal/eal.c:75:
+extern void init_rte_distributor_tailq(void);
WARNING:AVOID_EXTERNS: externs should be avoided in .c files
#587: FILE: lib/librte_eal/windows/eal/eal.c:76:
+extern void init_rte_dist_burst_tailq(void);
WARNING:AVOID_EXTERNS: externs should be avoided in .c files
#588: FILE: lib/librte_eal/windows/eal/eal.c:77:
+extern void init_rte_uio_tailq(void);
WARNING:AVOID_EXTERNS: externs should be avoided in .c files
#589: FILE: lib/librte_eal/windows/eal/eal.c:78:
+extern void init_rte_lpm_tailq(void);
WARNING:AVOID_EXTERNS: externs should be avoided in .c files
#590: FILE: lib/librte_eal/windows/eal/eal.c:79:
+extern void init_rte_lpm6_tailq(void);
WARNING:AVOID_EXTERNS: externs should be avoided in .c files
#593: FILE: lib/librte_eal/windows/eal/eal.c:82:
+extern void pciinitfn_net_i40e(void);
WARNING:AVOID_EXTERNS: externs should be avoided in .c files
#596: FILE: lib/librte_eal/windows/eal/eal.c:85:
+extern void rte_timer_init(void);
WARNING:AVOID_EXTERNS: externs should be avoided in .c files
#597: FILE: lib/librte_eal/windows/eal/eal.c:86:
+extern void rte_log_init(void);
WARNING:AVOID_EXTERNS: externs should be avoided in .c files
#598: FILE: lib/librte_eal/windows/eal/eal.c:87:
+extern void i40e_init_log(void);
WARNING:BLOCK_COMMENT_STYLE: Block comments use a trailing */ on a separate line
#628: FILE: lib/librte_eal/windows/eal/eal.c:117:
+ * processes. */
WARNING:SUSPECT_CODE_INDENT: suspect code indent for conditional statements (8, 12)
#640: FILE: lib/librte_eal/windows/eal/eal.c:129:
+ if (mem_cfg_fd < 0) {
+ mem_cfg_fd = _open(pathname, _O_CREAT | _O_RDWR | _O_TRUNC, _S_IREAD | _S_IWRITE);
WARNING:LONG_LINE: line over 90 characters
#641: FILE: lib/librte_eal/windows/eal/eal.c:130:
+ mem_cfg_fd = _open(pathname, _O_CREAT | _O_RDWR | _O_TRUNC, _S_IREAD | _S_IWRITE);
WARNING:TABSTOP: Statements should start on a tabstop
#642: FILE: lib/librte_eal/windows/eal/eal.c:131:
+ if (mem_cfg_fd < 0)
WARNING:LONG_LINE: line over 90 characters
#643: FILE: lib/librte_eal/windows/eal/eal.c:132:
+ rte_panic("Cannot open '%s' for rte_mem_config...Error: %d
", pathname, errno);
WARNING:SUSPECT_CODE_INDENT: suspect code indent for conditional statements (8, 12)
#655: FILE: lib/librte_eal/windows/eal/eal.c:144:
+ if (!retval) {
+ _close(mem_cfg_fd);
WARNING:LONG_LINE: line over 90 characters
#657: FILE: lib/librte_eal/windows/eal/eal.c:146:
+ rte_exit(EXIT_FAILURE, "Cannot create lock on '%s'. Is another primary process running?
", pathname);
WARNING:SUSPECT_CODE_INDENT: suspect code indent for conditional statements (8, 12)
#663: FILE: lib/librte_eal/windows/eal/eal.c:152:
+ if (rte_mem_cfg_addr == MAP_FAILED) {
+ _close(mem_cfg_fd);
WARNING:SUSPECT_CODE_INDENT: suspect code indent for conditional statements (8, 12)
#682: FILE: lib/librte_eal/windows/eal/eal.c:171:
+ if (mem_cfg_fd < 0) {
+ mem_cfg_fd = _open(pathname, O_RDWR);
WARNING:TABSTOP: Statements should start on a tabstop
#684: FILE: lib/librte_eal/windows/eal/eal.c:173:
+ if (mem_cfg_fd < 0)
WARNING:LONG_LINE: line over 90 characters
#688: FILE: lib/librte_eal/windows/eal/eal.c:177:
+ rte_mem_cfg_addr = mmap(NULL, sizeof(*rte_config.mem_config), PROT_READ | PROT_WRITE, MAP_SHARED, mem_cfg_fd, 0);
WARNING:BLOCK_COMMENT_STYLE: Block comments use a trailing */ on a separate line
#706: FILE: lib/librte_eal/windows/eal/eal.c:195:
+ * and don't close it to prevent a race condition between multiple opens */
WARNING:SUSPECT_CODE_INDENT: suspect code indent for conditional statements (8, 12)
#707: FILE: lib/librte_eal/windows/eal/eal.c:196:
+ if ((mem_cfg_fd = _open(pathname, O_RDWR)) >= 0) {
+ OVERLAPPED sOverlapped = { 0 };
ERROR:ASSIGN_IN_IF: do not use assignment in if condition
#707: FILE: lib/librte_eal/windows/eal/eal.c:196:
+ if ((mem_cfg_fd = _open(pathname, O_RDWR)) >= 0) {
WARNING:TABSTOP: Statements should start on a tabstop
#708: FILE: lib/librte_eal/windows/eal/eal.c:197:
+ OVERLAPPED sOverlapped = { 0 };
WARNING:TABSTOP: Statements should start on a tabstop
#712: FILE: lib/librte_eal/windows/eal/eal.c:201:
+ HANDLE hWinFileHandle = (HANDLE)_get_osfhandle(mem_cfg_fd);
WARNING:TABSTOP: Statements should start on a tabstop
#714: FILE: lib/librte_eal/windows/eal/eal.c:203:
+ if (!LockFileEx(hWinFileHandle,
ERROR:SPACING: space required before the open brace '{'
#732: FILE: lib/librte_eal/windows/eal/eal.c:221:
+ switch (rte_config.process_type){
ERROR:SPACING: space prohibited after that open parenthesis '('
#753: FILE: lib/librte_eal/windows/eal/eal.c:242:
+ if ( rte_application_usage_hook ) {
ERROR:SPACING: space prohibited before that close parenthesis ')'
#753: FILE: lib/librte_eal/windows/eal/eal.c:242:
+ if ( rte_application_usage_hook ) {
ERROR:SPACING: space prohibited after that open parenthesis '('
#761: FILE: lib/librte_eal/windows/eal/eal.c:250:
+rte_set_application_usage_hook( rte_usage_hook_t usage_func )
ERROR:SPACING: space prohibited before that close parenthesis ')'
#761: FILE: lib/librte_eal/windows/eal/eal.c:250:
+rte_set_application_usage_hook( rte_usage_hook_t usage_func )
ERROR:INLINE_LOCATION: inline keyword should sit between storage class and type
#916: FILE: lib/librte_eal/windows/eal/eal.c:405:
+inline static void
WARNING:SPACING: space prohibited between function name and open parenthesis '('
#1043: FILE: lib/librte_eal/windows/eal/eal.c:532:
+ RTE_LOG (DEBUG, EAL, "Using VMWARE TSC MAP, "
WARNING:SPACING: space prohibited between function name and open parenthesis '('
#1046: FILE: lib/librte_eal/windows/eal/eal.c:535:
+ RTE_LOG (WARNING, EAL, "Ignoring --vmware-tsc-map because "
WARNING:BLOCK_COMMENT_STYLE: Block comments should align the * on each line
#1054: FILE: lib/librte_eal/windows/eal/eal.c:543:
+ /* in secondary processes, memory init may allocate additional fbarrays
+ * not present in primary processes, so to avoid any potential issues,
WARNING:BLOCK_COMMENT_STYLE: Block comments should align the * on each line
#1132: FILE: lib/librte_eal/windows/eal/eal.c:621:
+ /* initialize default service/lcore mappings and start running. Ignore
+ * -ENOTSUP, as it indicates no service coremask passed to EAL.
WARNING:UNSPECIFIED_INT: Prefer 'unsigned int' to bare use of 'unsigned'
#1147: FILE: lib/librte_eal/windows/eal/eal.c:636:
+rte_eal_lcore_role(unsigned lcore_id)
WARNING:BLOCK_COMMENT_STYLE: Block comments should align the * on each line
#1185: FILE: lib/librte_eal/windows/eal/eal.c:674:
+ /* create the path if it doesn't exist. no "mkdir -p" here, so do it
+ * step by step.
WARNING:BLOCK_COMMENT_STYLE: Block comments should align the * on each line
#1216: FILE: lib/librte_eal/windows/eal/eal_alarm.c:2:
+/* SPDX-License-Identifier: BSD-3-Clause
+* Copyright(c) 2017-2018 Intel Corporation
WARNING:BLOCK_COMMENT_STYLE: Block comments should align the * on each line
#1251: FILE: lib/librte_eal/windows/eal/eal_debug.c:2:
+/* SPDX-License-Identifier: BSD-3-Clause
+* Copyright(c) 2017-2018 Intel Corporation
WARNING:LONG_LINE: line over 90 characters
#1271: FILE: lib/librte_eal/windows/eal/eal_debug.c:22:
+ numFrames = RtlCaptureStackBackTrace(0, MAX_TRACE_STACK_FRAMES, pCallingStack, NULL);
WARNING:SUSPECT_CODE_INDENT: suspect code indent for conditional statements (8, 12)
#1273: FILE: lib/librte_eal/windows/eal/eal_debug.c:24:
+ for (int i = 0; i < numFrames; i++) {
+ DWORD64 dwAddress = (DWORD64)(pCallingStack[i]);
WARNING:TABSTOP: Statements should start on a tabstop
#1275: FILE: lib/librte_eal/windows/eal/eal_debug.c:26:
+ DWORD dwDisplacement;
WARNING:TABSTOP: Statements should start on a tabstop
#1284: FILE: lib/librte_eal/windows/eal/eal_debug.c:35:
+ if (SymFromAddr(hProcess, dwAddress, NULL, pSymbol)) {
WARNING:SUSPECT_CODE_INDENT: suspect code indent for conditional statements (16, 20)
#1291: FILE: lib/librte_eal/windows/eal/eal_debug.c:42:
+ if (SymGetLineFromAddr64(hProcess, dwAddress, &dwDisplacement, &line))
+ printf("Currently at %s in %s: line: %lu: address: 0x%0X
", pSymbol->Name, line.FileName, line.LineNumber, pSymbol->Address);
WARNING:LONG_LINE: line over 90 characters
#1292: FILE: lib/librte_eal/windows/eal/eal_debug.c:43:
+ printf("Currently at %s in %s: line: %lu: address: 0x%0X
", pSymbol->Name, line.FileName, line.LineNumber, pSymbol->Address);
WARNING:SUSPECT_CODE_INDENT: suspect code indent for conditional statements (16, 20)
#1293: FILE: lib/librte_eal/windows/eal/eal_debug.c:44:
+ else
+ goto error;
WARNING:TABSTOP: Statements should start on a tabstop
#1294: FILE: lib/librte_eal/windows/eal/eal_debug.c:45:
+ goto error;
WARNING:TABSTOP: Statements should start on a tabstop
#1295: FILE: lib/librte_eal/windows/eal/eal_debug.c:46:
+ }
WARNING:TABSTOP: Statements should start on a tabstop
#1296: FILE: lib/librte_eal/windows/eal/eal_debug.c:47:
+ else
ERROR:ELSE_AFTER_BRACE: else should follow close brace '}'
#1296: FILE: lib/librte_eal/windows/eal/eal_debug.c:47:
+ }
+ else
WARNING:TABSTOP: Statements should start on a tabstop
#1299: FILE: lib/librte_eal/windows/eal/eal_debug.c:50:
+ continue;
WARNING:RETURN_VOID: void function return statements are not generally useful
#1306: FILE: lib/librte_eal/windows/eal/eal_debug.c:57:
+ return;
+}
WARNING:RETURN_VOID: void function return statements are not generally useful
#1312: FILE: lib/librte_eal/windows/eal/eal_debug.c:63:
+ return;
+}
WARNING:BLOCK_COMMENT_STYLE: Block comments should align the * on each line
#2102: FILE: lib/librte_eal/windows/eal/eal_fbarray.c:745:
+ /* take out a non-exclusive lock, so that other processes could
+ * still attach to it, but no other process could reinitialize
ERROR:SPACING: space required after that close brace '}'
#2111: FILE: lib/librte_eal/windows/eal/eal_fbarray.c:754:
+ }else {
ERROR:SPACING: space required before the open brace '{'
#2115: FILE: lib/librte_eal/windows/eal/eal_fbarray.c:758:
+ if(!retval){
ERROR:SPACING: space required before the open parenthesis '('
#2115: FILE: lib/librte_eal/windows/eal/eal_fbarray.c:758:
+ if(!retval){
WARNING:LONG_LINE: line over 90 characters
#2200: FILE: lib/librte_eal/windows/eal/eal_fbarray.c:843:
+ retval = LockFileEx(hWinFileHandle, LOCKFILE_FAIL_IMMEDIATELY, 0, mmap_len, 0, &sOverlapped);
WARNING:LONG_LINE: line over 90 characters
#2279: FILE: lib/librte_eal/windows/eal/eal_fbarray.c:922:
+ retval = LockFileEx(hWinFileHandle, LOCKFILE_EXCLUSIVE_LOCK | LOCKFILE_FAIL_IMMEDIATELY, 0, sizeof(*arr), 0, &sOverLapped);
WARNING:BLOCK_COMMENT_STYLE: Block comments should align the * on each line
#2638: FILE: lib/librte_eal/windows/eal/eal_filesystem.h:2:
+/* SPDX-License-Identifier: BSD-3-Clause
+* Copyright(c) 2017-2018 Intel Corporation
WARNING:LONG_LINE: line over 90 characters
#2675: FILE: lib/librte_eal/windows/eal/eal_filesystem.h:39:
+ snprintf(buffer, sizeof(buffer)-1, RUNTIME_CONFIG_FMT, Directory, internal_config.hugefile_prefix);
WARNING:LONG_LINE: line over 90 characters
#2712: FILE: lib/librte_eal/windows/eal/eal_filesystem.h:76:
+ snprintf(buffer, sizeof(buffer)-1, HUGEPAGE_INFO_FMT, Directory, internal_config.hugefile_prefix);
WARNING:LONG_LINE: line over 90 characters
#2723: FILE: lib/librte_eal/windows/eal/eal_filesystem.h:87:
+ snprintf(buffer, buflen, HUGEFILE_FMT, hugedir, internal_config.hugefile_prefix, f_id);
WARNING:BLOCK_COMMENT_STYLE: Block comments use a trailing */ on a separate line
#2730: FILE: lib/librte_eal/windows/eal/eal_filesystem.h:94:
+ * Used to read information from files on /sys */
WARNING:BLOCK_COMMENT_STYLE: Block comments should align the * on each line
#2741: FILE: lib/librte_eal/windows/eal/eal_hugepage_info.c:2:
+/* SPDX-License-Identifier: BSD-3-Clause
+* Copyright(c) 2017-2018 Intel Corporation
WARNING:BLOCK_COMMENT_STYLE: Block comments should align the * on each line
#2767: FILE: lib/librte_eal/windows/eal/eal_interrupts.c:2:
+/* SPDX-License-Identifier: BSD-3-Clause
+* Copyright(c) 2017-2018 Intel Corporation
WARNING:BLOCK_COMMENT_STYLE: Block comments should align the * on each line
#2863: FILE: lib/librte_eal/windows/eal/eal_lcore.c:2:
+/* SPDX-License-Identifier: BSD-3-Clause
+* Copyright(c) 2017-2018 Intel Corporation
WARNING:UNSPECIFIED_INT: Prefer 'unsigned int' to bare use of 'unsigned'
#2870: FILE: lib/librte_eal/windows/eal/eal_lcore.c:9:
+ unsigned numTotalProcessors;
WARNING:UNSPECIFIED_INT: Prefer 'unsigned int' to bare use of 'unsigned'
#2871: FILE: lib/librte_eal/windows/eal/eal_lcore.c:10:
+ unsigned numProcessorSockets;
WARNING:UNSPECIFIED_INT: Prefer 'unsigned int' to bare use of 'unsigned'
#2872: FILE: lib/librte_eal/windows/eal/eal_lcore.c:11:
+ unsigned numProcessorCores;
WARNING:UNSPECIFIED_INT: Prefer 'unsigned int' to bare use of 'unsigned'
#2873: FILE: lib/librte_eal/windows/eal/eal_lcore.c:12:
+ unsigned reserved;
ERROR:FUNCTION_WITHOUT_ARGS: Bad function definition - void eal_create_cpu_map() should probably be void eal_create_cpu_map(void)
#2881: FILE: lib/librte_eal/windows/eal/eal_lcore.c:20:
+void eal_create_cpu_map()
WARNING:SUSPECT_CODE_INDENT: suspect code indent for conditional statements (8, 12)
#2901: FILE: lib/librte_eal/windows/eal/eal_lcore.c:40:
+ if (win_cpu_map.numTotalProcessors > win_cpu_map.numProcessorCores)
+ bHyperThreadingEnabled = TRUE;
WARNING:LONG_LINE_COMMENT: line over 90 characters
#2905: FILE: lib/librte_eal/windows/eal/eal_lcore.c:44:
+ /* For now, split the cores equally across the sockets - might need to revisit this later */
WARNING:UNSPECIFIED_INT: Prefer 'unsigned int' to bare use of 'unsigned'
#2906: FILE: lib/librte_eal/windows/eal/eal_lcore.c:45:
+ unsigned lcore = 0;
WARNING:SUSPECT_CODE_INDENT: suspect code indent for conditional statements (8, 12)
#2907: FILE: lib/librte_eal/windows/eal/eal_lcore.c:46:
+ for (unsigned socket=0; socket < win_cpu_map.numProcessorSockets; ++socket) {
+ for (unsigned core = 0; core < (win_cpu_map.numProcessorCores / win_cpu_map.numProcessorSockets); ++core) {
WARNING:UNSPECIFIED_INT: Prefer 'unsigned int' to bare use of 'unsigned'
#2907: FILE: lib/librte_eal/windows/eal/eal_lcore.c:46:
+ for (unsigned socket=0; socket < win_cpu_map.numProcessorSockets; ++socket) {
ERROR:SPACING: spaces required around that '=' (ctx:VxV)
#2907: FILE: lib/librte_eal/windows/eal/eal_lcore.c:46:
+ for (unsigned socket=0; socket < win_cpu_map.numProcessorSockets; ++socket) {
^
WARNING:LONG_LINE: line over 90 characters
#2908: FILE: lib/librte_eal/windows/eal/eal_lcore.c:47:
+ for (unsigned core = 0; core < (win_cpu_map.numProcessorCores / win_cpu_map.numProcessorSockets); ++core) {
WARNING:TABSTOP: Statements should start on a tabstop
#2908: FILE: lib/librte_eal/windows/eal/eal_lcore.c:47:
+ for (unsigned core = 0; core < (win_cpu_map.numProcessorCores / win_cpu_map.numProcessorSockets); ++core) {
WARNING:UNSPECIFIED_INT: Prefer 'unsigned int' to bare use of 'unsigned'
#2908: FILE: lib/librte_eal/windows/eal/eal_lcore.c:47:
+ for (unsigned core = 0; core < (win_cpu_map.numProcessorCores / win_cpu_map.numProcessorSockets); ++core) {
WARNING:SUSPECT_CODE_INDENT: suspect code indent for conditional statements (16, 20)
#2914: FILE: lib/librte_eal/windows/eal/eal_lcore.c:53:
+ if (bHyperThreadingEnabled) {
+ win_cpu_map.win_lcore_map[lcore].socketid = socket;
WARNING:TABSTOP: Statements should start on a tabstop
#2919: FILE: lib/librte_eal/windows/eal/eal_lcore.c:58:
+ }
WARNING:RETURN_VOID: void function return statements are not generally useful
#2923: FILE: lib/librte_eal/windows/eal/eal_lcore.c:62:
+ return;
+}
WARNING:UNSPECIFIED_INT: Prefer 'unsigned int' to bare use of 'unsigned'
#2927: FILE: lib/librte_eal/windows/eal/eal_lcore.c:66:
+eal_cpu_detected(unsigned lcore_id)
WARNING:UNSPECIFIED_INT: Prefer 'unsigned int' to bare use of 'unsigned'
#2934: FILE: lib/librte_eal/windows/eal/eal_lcore.c:73:
+eal_cpu_socket_id(unsigned lcore_id)
WARNING:UNSPECIFIED_INT: Prefer 'unsigned int' to bare use of 'unsigned'
#2941: FILE: lib/librte_eal/windows/eal/eal_lcore.c:80:
+eal_cpu_core_id(unsigned lcore_id)
WARNING:BLOCK_COMMENT_STYLE: Block comments should align the * on each line
#2952: FILE: lib/librte_eal/windows/eal/eal_log.c:2:
+/* SPDX-License-Identifier: BSD-3-Clause
+* Copyright(c) 2017-2018 Intel Corporation
WARNING:TYPO_SPELLING: 'informations' may be misspelled - perhaps 'information'?
#2993: FILE: lib/librte_eal/windows/eal/eal_log.c:43:
+* This global structure stores some informations about the message
WARNING:BLOCK_COMMENT_STYLE: Block comments should align the * on each line
#2993: FILE: lib/librte_eal/windows/eal/eal_log.c:43:
+/**
+* This global structure stores some informations about the message
WARNING:BLOCK_COMMENT_STYLE: Block comments should align the * on each line
#3064: FILE: lib/librte_eal/windows/eal/eal_log.c:114:
+/*
+* Save the type string and the loglevel for later dynamic
WARNING:BLOCK_COMMENT_STYLE: Block comments should align the * on each line
#3129: FILE: lib/librte_eal/windows/eal/eal_log.c:179:
+/* register an extended log type, assuming table is large enough, and id
+* is not yet registered.
WARNING:BLOCK_COMMENT_STYLE: Block comments should align the * on each line
#3287: FILE: lib/librte_eal/windows/eal/eal_log.c:337:
+/*
+* Generates a log message The message will be sent in the stream
WARNING:BLOCK_COMMENT_STYLE: Block comments should align the * on each line
#3299: FILE: lib/librte_eal/windows/eal/eal_log.c:349:
+ /*
+ * Grab the current value of stderr here, rather than
WARNING:BLOCK_COMMENT_STYLE: Block comments should align the * on each line
#3326: FILE: lib/librte_eal/windows/eal/eal_log.c:376:
+/*
+* Generates a log message The message will be sent in the stream
WARNING:BLOCK_COMMENT_STYLE: Block comments should align the * on each line
#3343: FILE: lib/librte_eal/windows/eal/eal_log.c:393:
+/*
+* Called by environment-specific initialization functions.
WARNING:BLOCK_COMMENT_STYLE: Block comments should align the * on each line
#3357: FILE: lib/librte_eal/windows/eal/eal_log.c:407:
+/*
+* set the log to default function, called during eal init process,
WARNING:BLOCK_COMMENT_STYLE: Block comments use a trailing */ on a separate line
#3640: FILE: lib/librte_eal/windows/eal/eal_memalloc.c:269:
+ * here */
ERROR:SPACING: space prohibited before that close parenthesis ')'
#3678: FILE: lib/librte_eal/windows/eal/eal_memalloc.c:307:
+ internal_config.in_memory == 0 )
WARNING:BLOCK_COMMENT_STYLE: Block comments should align the * on each line
#3841: FILE: lib/librte_eal/windows/eal/eal_memalloc.c:470:
+ /* TODO dpdk-1808
+ * do not allow any page allocations during the time we're freeing,
ERROR:ELSE_AFTER_BRACE: else should follow close brace '}'
#4331: FILE: lib/librte_eal/windows/eal/eal_memalloc.c:960:
+ }
+ else if (fd_list[list_idx].len == 0) {
ERROR:ELSE_AFTER_BRACE: else should follow close brace '}'
#4335: FILE: lib/librte_eal/windows/eal/eal_memalloc.c:964:
+ }
+ else {
ERROR:ELSE_AFTER_BRACE: else should follow close brace '}'
#4359: FILE: lib/librte_eal/windows/eal/eal_memalloc.c:988:
+ }
+ else {
WARNING:MISSING_EOF_NEWLINE: adding a line without newline at end of file
#4366: FILE: lib/librte_eal/windows/eal/eal_memalloc.c:995:
+}
WARNING:BLOCK_COMMENT_STYLE: Block comments should align the * on each line
#4375: FILE: lib/librte_eal/windows/eal/eal_memory.c:2:
+/* SPDX-License-Identifier: BSD-3-Clause
+* Copyright(c) 2017-2018 Intel Corporation
WARNING:LONG_LINE_COMMENT: line over 90 characters
#4402: FILE: lib/librte_eal/windows/eal/eal_memory.c:29:
+ /* This function is only used by rte_mempool_virt2phy() when hugepages are disabled. */
ERROR:SPACING: space required before the open parenthesis '('
#4409: FILE: lib/librte_eal/windows/eal/eal_memory.c:36:
+ if(ms == NULL)
WARNING:LONG_LINE: line over 90 characters
#4411: FILE: lib/librte_eal/windows/eal/eal_memory.c:38:
+ physaddr = (phys_addr_t)((uintptr_t)ms->phys_addr + RTE_PTR_DIFF(virtaddr, mcfg->memsegs[0].base_va));
ERROR:ELSE_AFTER_BRACE: else should follow close brace '}'
#4414: FILE: lib/librte_eal/windows/eal/eal_memory.c:41:
+ }
+ else
WARNING:BLOCK_COMMENT_STYLE: Block comments should align the * on each line
#4423: FILE: lib/librte_eal/windows/eal/eal_memory.c:50:
+ * rte_pci_scan() call. Simply return here.
+ */
WARNING:BLOCK_COMMENT_STYLE: Block comments should align the * on each line
#4471: FILE: lib/librte_eal/windows/eal/eal_memory.c:98:
+ /*
+ * Primary memory has already been initialized in store_memseg_info()
WARNING:LONG_LINE: line over 90 characters
#4512: FILE: lib/librte_eal/windows/eal/eal_memory.c:139:
+ return rte_eal_process_type() == RTE_PROC_PRIMARY ? memseg_primary_init() : memseg_secondary_init();
WARNING:BLOCK_COMMENT_STYLE: Block comments use * on subsequent lines
#4617: FILE: lib/librte_eal/windows/eal/eal_proc.c:98:
+ .requests = TAILQ_HEAD_INITIALIZER(pending_requests.requests)/*,
+ .lock = NULL*/
WARNING:BLOCK_COMMENT_STYLE: Block comments use a trailing */ on a separate line
#4617: FILE: lib/librte_eal/windows/eal/eal_proc.c:98:
+ .lock = NULL*/
WARNING:TYPO_SPELLING: 'implemention' may be misspelled - perhaps 'implementation'?
#4767: FILE: lib/librte_eal/windows/eal/eal_proc.c:248:
+ /* Multiple process workflow is not supported in windows implemention*/
WARNING:BLOCK_COMMENT_STYLE: Block comments use * on subsequent lines
#4829: FILE: lib/librte_eal/windows/eal/eal_proc.c:310:
+ } /*else if (action(msg, s->sun_path) < 0) {
+ RTE_LOG(ERR, EAL, "Fail to handle message: %s
", msg->name);
WARNING:BLOCK_COMMENT_STYLE: Block comments use a trailing */ on a separate line
#4830: FILE: lib/librte_eal/windows/eal/eal_proc.c:311:
+ }*/
WARNING:LONG_LINE: line over 90 characters
#4978: FILE: lib/librte_eal/windows/eal/eal_proc.c:459:
+ pending_requests.lock = WinCreateAndLockStaticMutex(pending_requests.lock, &initOnce_Lock);
WARNING:TYPO_SPELLING: 'implemention' may be misspelled - perhaps 'implementation'?
#5106: FILE: lib/librte_eal/windows/eal/eal_proc.c:587:
+ /* Multiple process workflow is not supported in windows implemention*/
WARNING:LONG_LINE_COMMENT: line over 90 characters
#5137: FILE: lib/librte_eal/windows/eal/eal_proc.c:618:
+ /* TODO dpdk-1808 lock the directory to prevent processes spinning up while we send */
WARNING:BLOCK_COMMENT_STYLE: Block comments use * on subsequent lines
#5144: FILE: lib/librte_eal/windows/eal/eal_proc.c:625:
+ /*if (fnmatch(mp_filter, ent->d_name, 0) != 0)
+ continue;*/
WARNING:BLOCK_COMMENT_STYLE: Block comments use a trailing */ on a separate line
#5144: FILE: lib/librte_eal/windows/eal/eal_proc.c:625:
+ continue;*/
ERROR:SPACING: spaces required around that '=' (ctx:WxV)
#5347: FILE: lib/librte_eal/windows/eal/eal_proc.c:828:
+ end.tv_nsec =ts->tv_nsec % 1000000000;
^
WARNING:LONG_LINE: line over 90 characters
#5417: FILE: lib/librte_eal/windows/eal/eal_proc.c:898:
+ pending_requests.lock = WinCreateAndLockStaticMutex(pending_requests.lock,&initOnce_Lock);
ERROR:SPACING: space required after that ',' (ctx:VxO)
#5417: FILE: lib/librte_eal/windows/eal/eal_proc.c:898:
+ pending_requests.lock = WinCreateAndLockStaticMutex(pending_requests.lock,&initOnce_Lock);
^
ERROR:SPACING: space required before that '&' (ctx:OxV)
#5417: FILE: lib/librte_eal/windows/eal/eal_proc.c:898:
+ pending_requests.lock = WinCreateAndLockStaticMutex(pending_requests.lock,&initOnce_Lock);
^
WARNING:LONG_LINE_COMMENT: line over 90 characters
#5458: FILE: lib/librte_eal/windows/eal/eal_proc.c:939:
+ /* TODO dpdk-1808 lock the directory to prevent processes spinning up while we send */
WARNING:BLOCK_COMMENT_STYLE: Block comments should align the * on each line
#5530: FILE: lib/librte_eal/windows/eal/eal_thread.c:2:
+/* SPDX-License-Identifier: BSD-3-Clause
+* Copyright(c) 2017-2018 Intel Corporation
WARNING:UNSPECIFIED_INT: Prefer 'unsigned int' to bare use of 'unsigned'
#5544: FILE: lib/librte_eal/windows/eal/eal_thread.c:16:
+RTE_DEFINE_PER_LCORE(unsigned, _lcore_id) = LCORE_ID_ANY;
WARNING:UNSPECIFIED_INT: Prefer 'unsigned int' to bare use of 'unsigned'
#5545: FILE: lib/librte_eal/windows/eal/eal_thread.c:17:
+RTE_DEFINE_PER_LCORE(unsigned, _socket_id) = (unsigned)SOCKET_ID_ANY;
WARNING:UNSPECIFIED_INT: Prefer 'unsigned int' to bare use of 'unsigned'
#5545: FILE: lib/librte_eal/windows/eal/eal_thread.c:17:
+RTE_DEFINE_PER_LCORE(unsigned, _socket_id) = (unsigned)SOCKET_ID_ANY;
WARNING:UNSPECIFIED_INT: Prefer 'unsigned int' to bare use of 'unsigned'
#5554: FILE: lib/librte_eal/windows/eal/eal_thread.c:26:
+rte_eal_remote_launch(int (*f)(void *), void *arg, unsigned slave_id)
WARNING:UNSPECIFIED_INT: Prefer 'unsigned int' to bare use of 'unsigned'
#5589: FILE: lib/librte_eal/windows/eal/eal_thread.c:61:
+ unsigned lcore_id = rte_lcore_id();
WARNING:UNSPECIFIED_INT: Prefer 'unsigned int' to bare use of 'unsigned'
#5598: FILE: lib/librte_eal/windows/eal/eal_thread.c:70:
+void eal_thread_init_master(unsigned lcore_id)
WARNING:UNSPECIFIED_INT: Prefer 'unsigned int' to bare use of 'unsigned'
#5614: FILE: lib/librte_eal/windows/eal/eal_thread.c:86:
+ unsigned lcore_id;
WARNING:MISSING_EOF_NEWLINE: adding a line without newline at end of file
#5695: FILE: lib/librte_eal/windows/eal/eal_thread.c:167:
+}
WARNING:BLOCK_COMMENT_STYLE: Block comments should align the * on each line
#5704: FILE: lib/librte_eal/windows/eal/eal_timer.c:2:
+/* SPDX-License-Identifier: BSD-3-Clause
+* Copyright(c) 2017-2018 Intel Corporation
WARNING:BLOCK_COMMENT_STYLE: Block comments should align the * on each line
#5750: FILE: lib/librte_eal/windows/eal/linux-emu/_rand48.c:2:
+/*
+* Copyright (c) 1993 Martin Birgmeier
WARNING:LONG_LINE: line over 90 characters
#5790: FILE: lib/librte_eal/windows/eal/linux-emu/_rand48.c:42:
+ accu += _rand48_mult[0] * xseed[2] + _rand48_mult[1] * xseed[1] + _rand48_mult[2] * xseed[0];
WARNING:LONG_LINE: line over 90 characters
#5836: FILE: lib/librte_eal/windows/eal/linux-emu/drand48.c:36:
+ accu += _rand48_mult[0] * xseed[2] + _rand48_mult[1] * xseed[1] + _rand48_mult[2] * xseed[0];
ERROR:FUNCTION_WITHOUT_ARGS: Bad function definition - double drand48() should probably be double drand48(void)
#5850: FILE: lib/librte_eal/windows/eal/linux-emu/drand48.c:50:
+double drand48() {
ERROR:OPEN_BRACE: open brace '{' following function definitions go on the next line
#5850: FILE: lib/librte_eal/windows/eal/linux-emu/drand48.c:50:
+double drand48() {
ERROR:OPEN_BRACE: open brace '{' following function definitions go on the next line
#5854: FILE: lib/librte_eal/windows/eal/linux-emu/drand48.c:54:
+void srand48(long seed) {
WARNING:BLOCK_COMMENT_STYLE: Block comments should align the * on each line
#5870: FILE: lib/librte_eal/windows/eal/linux-emu/fork.c:2:
+/*
+* fork.c
WARNING:ENOSYS: ENOSYS means 'invalid syscall nr' and nothing else
#5941: FILE: lib/librte_eal/windows/eal/linux-emu/fork.c:73:
+ return -ENOSYS;
WARNING:ENOSYS: ENOSYS means 'invalid syscall nr' and nothing else
#5945: FILE: lib/librte_eal/windows/eal/linux-emu/fork.c:77:
+ return -ENOSYS;
WARNING:LONG_LINE: line over 90 characters
#5948: FILE: lib/librte_eal/windows/eal/linux-emu/fork.c:80:
+ result = clone_p(RTL_CLONE_PROCESS_FLAGS_CREATE_SUSPENDED | RTL_CLONE_PROCESS_FLAGS_INHERIT_HANDLES, NULL, NULL, NULL, &process_info);
ERROR:OPEN_BRACE: that open brace { should be on the previous line
#5950: FILE: lib/librte_eal/windows/eal/linux-emu/fork.c:82:
+ if (result == RTL_CLONE_PARENT)
+ {
ERROR:OPEN_BRACE: that open brace { should be on the previous line
#5968: FILE: lib/librte_eal/windows/eal/linux-emu/fork.c:100:
+ else if (result == RTL_CLONE_CHILD)
+ {
ERROR:ELSE_AFTER_BRACE: else should follow close brace '}'
#5968: FILE: lib/librte_eal/windows/eal/linux-emu/fork.c:100:
+ }
+ else if (result == RTL_CLONE_CHILD)
ERROR:ELSE_AFTER_BRACE: else should follow close brace '}'
#5974: FILE: lib/librte_eal/windows/eal/linux-emu/fork.c:106:
+ }
+ else
WARNING:LONG_LINE_COMMENT: line over 90 characters
#6000: FILE: lib/librte_eal/windows/eal/linux-emu/getopt.c:15:
+ /* XXX: set optreset to 1 rather than these two */
WARNING:BLOCK_COMMENT_STYLE: Block comments should align the * on each line
#6013: FILE: lib/librte_eal/windows/eal/linux-emu/getopt.c:28:
+/*
+* parse_long_options --
ERROR:ASSIGN_IN_IF: do not use assignment in if condition
#6036: FILE: lib/librte_eal/windows/eal/linux-emu/getopt.c:51:
+ if ((has_equal = strchr(current_argv, '=')) != NULL) {
ERROR:ELSE_AFTER_BRACE: else should follow close brace '}'
#6041: FILE: lib/librte_eal/windows/eal/linux-emu/getopt.c:56:
+ }
+ else
WARNING:BLOCK_COMMENT_STYLE: Block comments should align the * on each line
#6057: FILE: lib/librte_eal/windows/eal/linux-emu/getopt.c:72:
+ /*
+ * If this is a known short option, don't allow
ERROR:RETURN_PARENTHESES: return is not a function, parentheses are not required
#6074: FILE: lib/librte_eal/windows/eal/linux-emu/getopt.c:89:
+ return (BADCH);
WARNING:BLOCK_COMMENT_STYLE: Block comments should align the * on each line
#6083: FILE: lib/librte_eal/windows/eal/linux-emu/getopt.c:98:
+ /*
+ * XXX: GNU sets optopt to val regardless of flag
ERROR:RETURN_PARENTHESES: return is not a function, parentheses are not required
#6089: FILE: lib/librte_eal/windows/eal/linux-emu/getopt.c:104:
+ return (BADARG);
WARNING:BLOCK_COMMENT_STYLE: Block comments should align the * on each line
#6098: FILE: lib/librte_eal/windows/eal/linux-emu/getopt.c:113:
+ /*
+ * optional argument doesn't use next nargv
WARNING:BLOCK_COMMENT_STYLE: Block comments should align the * on each line
#6106: FILE: lib/librte_eal/windows/eal/linux-emu/getopt.c:121:
+ /*
+ * Missing argument; leading ':' indicates no error
WARNING:BLOCK_COMMENT_STYLE: Block comments should align the * on each line
#6113: FILE: lib/librte_eal/windows/eal/linux-emu/getopt.c:128:
+ /*
+ * XXX: GNU sets optopt to val regardless of flag
ERROR:RETURN_PARENTHESES: return is not a function, parentheses are not required
#6120: FILE: lib/librte_eal/windows/eal/linux-emu/getopt.c:135:
+ return (BADARG);
ERROR:ELSE_AFTER_BRACE: else should follow close brace '}'
#6123: FILE: lib/librte_eal/windows/eal/linux-emu/getopt.c:138:
+ }
+ else { /* unknown option */
ERROR:RETURN_PARENTHESES: return is not a function, parentheses are not required
#6131: FILE: lib/librte_eal/windows/eal/linux-emu/getopt.c:146:
+ return (BADCH);
ERROR:RETURN_PARENTHESES: return is not a function, parentheses are not required
#6137: FILE: lib/librte_eal/windows/eal/linux-emu/getopt.c:152:
+ return (0);
ERROR:ELSE_AFTER_BRACE: else should follow close brace '}'
#6139: FILE: lib/librte_eal/windows/eal/linux-emu/getopt.c:154:
+ }
+ else
WARNING:BLOCK_COMMENT_STYLE: Block comments should align the * on each line
#6146: FILE: lib/librte_eal/windows/eal/linux-emu/getopt.c:161:
+/*
+* getopt --
WARNING:BLOCK_COMMENT_STYLE: Block comments should align the * on each line
#6156: FILE: lib/librte_eal/windows/eal/linux-emu/getopt.c:171:
+ /*
+ * We don't pass FLAG_PERMUTE to getopt_internal() since
ERROR:RETURN_PARENTHESES: return is not a function, parentheses are not required
#6163: FILE: lib/librte_eal/windows/eal/linux-emu/getopt.c:178:
+ return (getopt_internal(nargc, nargv, options, NULL, NULL, 0));
WARNING:BLOCK_COMMENT_STYLE: Block comments should align the * on each line
#6168: FILE: lib/librte_eal/windows/eal/linux-emu/getopt.c:183:
+/*
+* getopt_internal --
WARNING:BLOCK_COMMENT_STYLE: Block comments should align the * on each line
#6183: FILE: lib/librte_eal/windows/eal/linux-emu/getopt.c:198:
+ /*
+ * XXX Some GNU programs (like cvs) set optind to 0 instead of
WARNING:BLOCK_COMMENT_STYLE: Block comments should align the * on each line
#6190: FILE: lib/librte_eal/windows/eal/linux-emu/getopt.c:205:
+ /*
+ * Disable GNU extensions if POSIXLY_CORRECT is set or options
ERROR:ELSE_AFTER_BRACE: else should follow close brace '}'
#6219: FILE: lib/librte_eal/windows/eal/linux-emu/getopt.c:234:
+ }
+ else if (nonopt_start != -1) {
WARNING:BLOCK_COMMENT_STYLE: Block comments should align the * on each line
#6221: FILE: lib/librte_eal/windows/eal/linux-emu/getopt.c:236:
+ /*
+ * If we skipped non-options, set optind
ERROR:ASSIGN_IN_IF: do not use assignment in if condition
#6229: FILE: lib/librte_eal/windows/eal/linux-emu/getopt.c:244:
+ if (*(place = nargv[optind]) != '-' ||
WARNING:BLOCK_COMMENT_STYLE: Block comments should align the * on each line
#6234: FILE: lib/librte_eal/windows/eal/linux-emu/getopt.c:249:
+ /*
+ * GNU extension:
ERROR:RETURN_PARENTHESES: return is not a function, parentheses are not required
#6238: FILE: lib/librte_eal/windows/eal/linux-emu/getopt.c:253:
+ return (INORDER);
WARNING:BLOCK_COMMENT_STYLE: Block comments should align the * on each line
#6242: FILE: lib/librte_eal/windows/eal/linux-emu/getopt.c:257:
+ /*
+ * If no permutation wanted, stop parsing
WARNING:BLOCK_COMMENT_STYLE: Block comments should align the * on each line
#6265: FILE: lib/librte_eal/windows/eal/linux-emu/getopt.c:280:
+ /*
+ * If we have "-" do nothing, if "--" we are done.
WARNING:BLOCK_COMMENT_STYLE: Block comments should align the * on each line
#6271: FILE: lib/librte_eal/windows/eal/linux-emu/getopt.c:286:
+ /*
+ * We found an option (--), so if we skipped
WARNING:BLOCK_COMMENT_STYLE: Block comments should align the * on each line
#6285: FILE: lib/librte_eal/windows/eal/linux-emu/getopt.c:300:
+ /*
+ * Check long options if:
ERROR:RETURN_PARENTHESES: return is not a function, parentheses are not required
#6302: FILE: lib/librte_eal/windows/eal/linux-emu/getopt.c:317:
+ return (optchar);
ERROR:ASSIGN_IN_IF: do not use assignment in if condition
#6306: FILE: lib/librte_eal/windows/eal/linux-emu/getopt.c:321:
+ if ((optchar = (int)*place++) == (int)':' ||
ERROR:POINTER_LOCATION: "(foo*)" should be "(foo *)"
#6308: FILE: lib/librte_eal/windows/eal/linux-emu/getopt.c:323:
+ (oli = (char*)strchr(options, optchar)) == NULL) {
WARNING:BLOCK_COMMENT_STYLE: Block comments should align the * on each line
#6310: FILE: lib/librte_eal/windows/eal/linux-emu/getopt.c:325:
+ /*
+ * If the user specified "-" and '-' isn't listed in
ERROR:RETURN_PARENTHESES: return is not a function, parentheses are not required
#6321: FILE: lib/librte_eal/windows/eal/linux-emu/getopt.c:336:
+ return (BADCH);
WARNING:SUSPECT_CODE_INDENT: suspect code indent for conditional statements (16, 37)
#6325: FILE: lib/librte_eal/windows/eal/linux-emu/getopt.c:340:
+ if (*place) /* no space */
+ /* NOTHING */;
ERROR:RETURN_PARENTHESES: return is not a function, parentheses are not required
#6332: FILE: lib/librte_eal/windows/eal/linux-emu/getopt.c:347:
+ return (BADARG);
ERROR:ELSE_AFTER_BRACE: else should follow close brace '}'
#6334: FILE: lib/librte_eal/windows/eal/linux-emu/getopt.c:349:
+ }
+ else /* white space */
ERROR:RETURN_PARENTHESES: return is not a function, parentheses are not required
#6339: FILE: lib/librte_eal/windows/eal/linux-emu/getopt.c:354:
+ return (optchar);
ERROR:ELSE_AFTER_BRACE: else should follow close brace '}'
#6345: FILE: lib/librte_eal/windows/eal/linux-emu/getopt.c:360:
+ }
+ else { /* takes (optional) argument */
ERROR:RETURN_PARENTHESES: return is not a function, parentheses are not required
#6355: FILE: lib/librte_eal/windows/eal/linux-emu/getopt.c:370:
+ return (BADARG);
ERROR:ELSE_AFTER_BRACE: else should follow close brace '}'
#6357: FILE: lib/librte_eal/windows/eal/linux-emu/getopt.c:372:
+ }
+ else
WARNING:BLOCK_COMMENT_STYLE: Block comments should align the * on each line
#6369: FILE: lib/librte_eal/windows/eal/linux-emu/getopt.c:384:
+/*
+* getopt_long --
WARNING:BLOCK_COMMENT_STYLE: Block comments should align the * on each line
#6382: FILE: lib/librte_eal/windows/eal/linux-emu/getopt.c:397:
+/*
+* getopt_long_only --
WARNING:BLOCK_COMMENT_STYLE: Block comments should align the * on each line
#6400: FILE: lib/librte_eal/windows/eal/linux-emu/lrand48.c:2:
+/*
+* Copyright (c) 1993 Martin Birgmeier
ERROR:OPEN_BRACE: that open brace { should be on the previous line
#6453: FILE: lib/librte_eal/windows/eal/linux-emu/mman.c:26:
+ if ((prot & PROT_EXEC) != 0)
+ {
ERROR:OPEN_BRACE: that open brace { should be on the previous line
#6458: FILE: lib/librte_eal/windows/eal/linux-emu/mman.c:31:
+ else
+ {
ERROR:ELSE_AFTER_BRACE: else should follow close brace '}'
#6458: FILE: lib/librte_eal/windows/eal/linux-emu/mman.c:31:
+ }
+ else
ERROR:POINTER_LOCATION: "foo* bar" should be "foo *bar"
#6484: FILE: lib/librte_eal/windows/eal/linux-emu/mman.c:57:
+void* mmap(void *addr, size_t len, int prot, int flags, int fildes, OffsetType off)
ERROR:POINTER_LOCATION: "foo * bar" should be "foo *bar"
#6488: FILE: lib/librte_eal/windows/eal/linux-emu/mman.c:61:
+ void * map = MAP_FAILED;
ERROR:SPACING: spaces required around that ':' (ctx:VxW)
#6492: FILE: lib/librte_eal/windows/eal/linux-emu/mman.c:65:
+#pragma warning(disable: 4293)
^
ERROR:OPEN_BRACE: that open brace { should be on the previous line
#6515: FILE: lib/librte_eal/windows/eal/linux-emu/mman.c:88:
+ if (len == 0
+ /* Unsupported flag combinations */
+ || (flags & MAP_FIXED) != 0
+ /* Usupported protection combinations */
+ || prot == PROT_EXEC)
+ {
ERROR:OPEN_BRACE: that open brace { should be on the previous line
#6528: FILE: lib/librte_eal/windows/eal/linux-emu/mman.c:101:
+ if ((flags & MAP_ANONYMOUS) == 0 && h == INVALID_HANDLE_VALUE)
+ {
ERROR:OPEN_BRACE: that open brace { should be on the previous line
#6536: FILE: lib/librte_eal/windows/eal/linux-emu/mman.c:109:
+ if (fm == NULL)
+ {
ERROR:OPEN_BRACE: that open brace { should be on the previous line
#6546: FILE: lib/librte_eal/windows/eal/linux-emu/mman.c:119:
+ if (map == NULL)
+ {
WARNING:BLOCK_COMMENT_STYLE: Block comments should align the * on each line
#6614: FILE: lib/librte_eal/windows/eal/linux-emu/setenv.c:2:
+/* SPDX-License-Identifier: BSD-3-Clause
+* Copyright(c) 2017-2018 Intel Corporation
ERROR:POINTER_LOCATION: "foo * bar" should be "foo *bar"
#6621: FILE: lib/librte_eal/windows/eal/linux-emu/setenv.c:9:
+ char * curenv;
ERROR:OPEN_BRACE: that open brace { should be on the previous line
#6630: FILE: lib/librte_eal/windows/eal/linux-emu/setenv.c:18:
+ if (err || overwrite)
+ {
WARNING:MISSING_EOF_NEWLINE: adding a line without newline at end of file
#6638: FILE: lib/librte_eal/windows/eal/linux-emu/setenv.c:26:
+}
WARNING:BLOCK_COMMENT_STYLE: Block comments should align the * on each line
#6647: FILE: lib/librte_eal/windows/eal/linux-emu/srand48.c:2:
+/*
+* Copyright (c) 1993 Martin Birgmeier
WARNING:AVOID_EXTERNS: externs should be avoided in .c files
#6662: FILE: lib/librte_eal/windows/eal/linux-emu/srand48.c:17:
+extern unsigned short _rand48_mult[3];
WARNING:AVOID_EXTERNS: externs should be avoided in .c files
#6663: FILE: lib/librte_eal/windows/eal/linux-emu/srand48.c:18:
+extern unsigned short _rand48_add;
WARNING:MISSING_EOF_NEWLINE: adding a line without newline at end of file
#6692: FILE: lib/librte_eal/windows/eal/linux-emu/termios.c:11:
+}
WARNING:BLOCK_COMMENT_STYLE: Block comments should align the * on each line
#6701: FILE: lib/librte_eal/windows/eal/linux-emu/unistd.c:2:
+/* SPDX-License-Identifier: BSD-3-Clause
+* Copyright(c) 2017-2018 Intel Corporation
WARNING:LEADING_SPACE: please, no spaces at the start of a line
#6709: FILE: lib/librte_eal/windows/eal/linux-emu/unistd.c:10:
+ SYSTEM_INFO si;$
WARNING:LEADING_SPACE: please, no spaces at the start of a line
#6711: FILE: lib/librte_eal/windows/eal/linux-emu/unistd.c:12:
+ GetSystemInfo(&si);$
WARNING:LEADING_SPACE: please, no spaces at the start of a line
#6713: FILE: lib/librte_eal/windows/eal/linux-emu/unistd.c:14:
+ return si.dwPageSize;$
WARNING:MISSING_EOF_NEWLINE: adding a line without newline at end of file
#6720: FILE: lib/librte_eal/windows/eal/linux-emu/unistd.c:21:
+}
WARNING:UNSPECIFIED_INT: Prefer 'unsigned int' to bare use of 'unsigned'
#6760: FILE: lib/librte_eal/windows/eal/malloc_heap.c:33:
+check_hugepage_sz(unsigned flags, uint64_t hugepage_sz)
WARNING:UNSPECIFIED_INT: Prefer 'unsigned int' to bare use of 'unsigned'
#6762: FILE: lib/librte_eal/windows/eal/malloc_heap.c:35:
+ unsigned check_flag = 0;
ERROR:OPEN_BRACE: that open brace { should be on the previous line
#7528: FILE: lib/librte_eal/windows/eal/malloc_heap.c:801:
+ for (elem = LIST_FIRST(&heap->free_head[idx]);
+ !!elem; elem = LIST_NEXT(elem, free_list))
+ {
WARNING:LONG_LINE_COMMENT: line over 90 characters
#8060: FILE: lib/librte_eal/windows/eal/malloc_mp.c:259:
+ /* TODO dpdk-1808 send msg across to the other process using rte_mp_sendmsg(&resp_msg) */
WARNING:LONG_LINE_COMMENT: line over 90 characters
#8408: FILE: lib/librte_eal/windows/eal/malloc_mp.c:607:
+ /* TODO dpdk-1808 send msg across to the other process using rte_mp_sendmsg(&resp_msg) */
ERROR:SPACING: space required after that ',' (ctx:VxV)
#8420: FILE: lib/librte_eal/windows/eal/malloc_mp.c:619:
+ &mp_request_list.lock, milliseconds,0);
^
WARNING:BLOCK_COMMENT_STYLE: Block comments should align the * on each line
#8454: FILE: lib/librte_eal/windows/include_override/dirent.h:2:
+/*
+* Dirent interface for Microsoft Visual Studio
WARNING:BLOCK_COMMENT_STYLE: Block comments should align the * on each line
#8466: FILE: lib/librte_eal/windows/include_override/dirent.h:14:
+/*
+* Include windows.h without Windows Sockets 1.1 to prevent conflicts with
WARNING:SYMBOLIC_PERMS: Symbolic permissions 'S_IRUSR' are not preferred. Consider using octal permissions '0400'.
#8556: FILE: lib/librte_eal/windows/include_override/dirent.h:104:
+#if !defined(S_IRUSR)
WARNING:SYMBOLIC_PERMS: Symbolic permissions 'S_IRUSR' are not preferred. Consider using octal permissions '0400'.
#8557: FILE: lib/librte_eal/windows/include_override/dirent.h:105:
+# define S_IRUSR S_IREAD
WARNING:SYMBOLIC_PERMS: Symbolic permissions 'S_IWUSR' are not preferred. Consider using octal permissions '0200'.
#8561: FILE: lib/librte_eal/windows/include_override/dirent.h:109:
+#if !defined(S_IWUSR)
WARNING:SYMBOLIC_PERMS: Symbolic permissions 'S_IWUSR' are not preferred. Consider using octal permissions '0200'.
#8562: FILE: lib/librte_eal/windows/include_override/dirent.h:110:
+# define S_IWUSR S_IWRITE
WARNING:SYMBOLIC_PERMS: Symbolic permissions 'S_IXUSR' are not preferred. Consider using octal permissions '0100'.
#8566: FILE: lib/librte_eal/windows/include_override/dirent.h:114:
+#if !defined(S_IXUSR)
WARNING:SYMBOLIC_PERMS: Symbolic permissions 'S_IXUSR' are not preferred. Consider using octal permissions '0100'.
#8567: FILE: lib/librte_eal/windows/include_override/dirent.h:115:
+# define S_IXUSR 0
WARNING:SYMBOLIC_PERMS: Symbolic permissions 'S_IRGRP' are not preferred. Consider using octal permissions '0040'.
#8571: FILE: lib/librte_eal/windows/include_override/dirent.h:119:
+#if !defined(S_IRGRP)
WARNING:SYMBOLIC_PERMS: Symbolic permissions 'S_IRGRP' are not preferred. Consider using octal permissions '0040'.
#8572: FILE: lib/librte_eal/windows/include_override/dirent.h:120:
+# define S_IRGRP 0
WARNING:SYMBOLIC_PERMS: Symbolic permissions 'S_IWGRP' are not preferred. Consider using octal permissions '0020'.
#8576: FILE: lib/librte_eal/windows/include_override/dirent.h:124:
+#if !defined(S_IWGRP)
WARNING:SYMBOLIC_PERMS: Symbolic permissions 'S_IWGRP' are not preferred. Consider using octal permissions '0020'.
#8577: FILE: lib/librte_eal/windows/include_override/dirent.h:125:
+# define S_IWGRP 0
WARNING:SYMBOLIC_PERMS: Symbolic permissions 'S_IXGRP' are not preferred. Consider using octal permissions '0010'.
#8581: FILE: lib/librte_eal/windows/include_override/dirent.h:129:
+#if !defined(S_IXGRP)
WARNING:SYMBOLIC_PERMS: Symbolic permissions 'S_IXGRP' are not preferred. Consider using octal permissions '0010'.
#8582: FILE: lib/librte_eal/windows/include_override/dirent.h:130:
+# define S_IXGRP 0
WARNING:SYMBOLIC_PERMS: Symbolic permissions 'S_IROTH' are not preferred. Consider using octal permissions '0004'.
#8586: FILE: lib/librte_eal/windows/include_override/dirent.h:134:
+#if !defined(S_IROTH)
WARNING:SYMBOLIC_PERMS: Symbolic permissions 'S_IROTH' are not preferred. Consider using octal permissions '0004'.
#8587: FILE: lib/librte_eal/windows/include_override/dirent.h:135:
+# define S_IROTH 0
WARNING:SYMBOLIC_PERMS: Symbolic permissions 'S_IWOTH' are not preferred. Consider using octal permissions '0002'.
#8591: FILE: lib/librte_eal/windows/include_override/dirent.h:139:
+#if !defined(S_IWOTH)
WARNING:SYMBOLIC_PERMS: Symbolic permissions 'S_IWOTH' are not preferred. Consider using octal permissions '0002'.
#8592: FILE: lib/librte_eal/windows/include_override/dirent.h:140:
+# define S_IWOTH 0
WARNING:SYMBOLIC_PERMS: Symbolic permissions 'S_IXOTH' are not preferred. Consider using octal permissions '0001'.
#8596: FILE: lib/librte_eal/windows/include_override/dirent.h:144:
+#if !defined(S_IXOTH)
WARNING:SYMBOLIC_PERMS: Symbolic permissions 'S_IXOTH' are not preferred. Consider using octal permissions '0001'.
#8597: FILE: lib/librte_eal/windows/include_override/dirent.h:145:
+# define S_IXOTH 0
WARNING:BLOCK_COMMENT_STYLE: Block comments should align the * on each line
#8626: FILE: lib/librte_eal/windows/include_override/dirent.h:174:
+/*
+* File type macros. Note that block devices, sockets and links cannot be
ERROR:POINTER_LOCATION: "foo* bar" should be "foo *bar"
#8705: FILE: lib/librte_eal/windows/include_override/dirent.h:253:
+ static void _wrewinddir(_WDIR* dirp);
ERROR:POINTER_LOCATION: "foo* bar" should be "foo *bar"
#8745: FILE: lib/librte_eal/windows/include_override/dirent.h:293:
+ static void rewinddir(DIR* dirp);
WARNING:BLOCK_COMMENT_STYLE: Block comments should align the * on each line
#8769: FILE: lib/librte_eal/windows/include_override/dirent.h:317:
+ /*
+ * Open directory stream DIRNAME for read and return a pointer to the
ERROR:OPEN_BRACE: open brace '{' following function definitions go on the next line
#8773: FILE: lib/librte_eal/windows/include_override/dirent.h:321:
+ static _WDIR*
+ _wopendir(
+ const wchar_t *dirname)
+ {
ERROR:POINTER_LOCATION: "(foo*)" should be "(foo *)"
#8787: FILE: lib/librte_eal/windows/include_override/dirent.h:335:
+ dirp = (_WDIR*)malloc(sizeof(struct _WDIR));
WARNING:BLOCK_COMMENT_STYLE: Block comments should align the * on each line
#8797: FILE: lib/librte_eal/windows/include_override/dirent.h:345:
+ /* Compute the length of full path plus zero terminator
+ *
ERROR:POINTER_LOCATION: "(foo*)" should be "(foo *)"
#8808: FILE: lib/librte_eal/windows/include_override/dirent.h:356:
+ dirp->patt = (wchar_t*)malloc(sizeof(wchar_t) * n + 16);
WARNING:LONG_LINE_COMMENT: line over 90 characters
#8812: FILE: lib/librte_eal/windows/include_override/dirent.h:360:
+ * Convert relative directory name to an absolute one. This
WARNING:BLOCK_COMMENT_STYLE: Block comments should align the * on each line
#8812: FILE: lib/librte_eal/windows/include_override/dirent.h:360:
+ /*
+ * Convert relative directory name to an absolute one. This
WARNING:LONG_LINE_COMMENT: line over 90 characters
#8813: FILE: lib/librte_eal/windows/include_override/dirent.h:361:
+ * allows rewinddir() to function correctly even when current
WARNING:LONG_LINE_COMMENT: line over 90 characters
#8814: FILE: lib/librte_eal/windows/include_override/dirent.h:362:
+ * working directory is changed between opendir() and rewinddir().
WARNING:LONG_LINE_COMMENT: line over 90 characters
#8816: FILE: lib/librte_eal/windows/include_override/dirent.h:364:
+ * Note that on WinRT there's no way to convert relative paths
WARNING:LONG_LINE_COMMENT: line over 90 characters
#8817: FILE: lib/librte_eal/windows/include_override/dirent.h:365:
+ * into absolute paths, so just assume its an absolute path.
WARNING:LONG_LINE_COMMENT: line over 90 characters
#8827: FILE: lib/librte_eal/windows/include_override/dirent.h:375:
+ /* Append search pattern \* to the directory name */
WARNING:DEEP_INDENTATION: Too many leading tabs - consider code refactoring
#8830: FILE: lib/librte_eal/windows/include_override/dirent.h:378:
+ switch (p[-1]) {
WARNING:LONG_LINE_COMMENT: line over 90 characters
#8834: FILE: lib/librte_eal/windows/include_override/dirent.h:382:
+ /* Directory ends in path separator, e.g. c: emp\ */
WARNING:LONG_LINE_COMMENT: line over 90 characters
#8839: FILE: lib/librte_eal/windows/include_override/dirent.h:387:
+ /* Directory name doesn't end in path separator */
WARNING:LONG_LINE_COMMENT: line over 90 characters
#8846: FILE: lib/librte_eal/windows/include_override/dirent.h:394:
+ /* Open directory stream and retrieve the first entry */
ERROR:ELSE_AFTER_BRACE: else should follow close brace '}'
#8851: FILE: lib/librte_eal/windows/include_override/dirent.h:399:
+ }
+ else {
ERROR:ELSE_AFTER_BRACE: else should follow close brace '}'
#8858: FILE: lib/librte_eal/windows/include_override/dirent.h:406:
+ }
+ else {
ERROR:ELSE_AFTER_BRACE: else should follow close brace '}'
#8865: FILE: lib/librte_eal/windows/include_override/dirent.h:413:
+ }
+ else {
ERROR:ELSE_AFTER_BRACE: else should follow close brace '}'
#8871: FILE: lib/librte_eal/windows/include_override/dirent.h:419:
+ }
+ else {
WARNING:BLOCK_COMMENT_STYLE: Block comments should align the * on each line
#8886: FILE: lib/librte_eal/windows/include_override/dirent.h:434:
+ /*
+ * Read next directory entry. The directory entry is returned in dirent
ERROR:OPEN_BRACE: open brace '{' following function definitions go on the next line
#8891: FILE: lib/librte_eal/windows/include_override/dirent.h:439:
+ static struct _wdirent*
+ _wreaddir(
+ _WDIR *dirp)
+ {
WARNING:LONG_LINE_COMMENT: line over 90 characters
#8908: FILE: lib/librte_eal/windows/include_override/dirent.h:456:
+ * Copy file name as wide-character string. If the file name is too
WARNING:BLOCK_COMMENT_STYLE: Block comments should align the * on each line
#8908: FILE: lib/librte_eal/windows/include_override/dirent.h:456:
+ /*
+ * Copy file name as wide-character string. If the file name is too
WARNING:LONG_LINE_COMMENT: line over 90 characters
#8909: FILE: lib/librte_eal/windows/include_override/dirent.h:457:
+ * long to fit in to the destination buffer, then truncate file name
WARNING:BRACES: braces {} are not necessary for any arm of this statement
#8924: FILE: lib/librte_eal/windows/include_override/dirent.h:472:
+ if ((attr & FILE_ATTRIBUTE_DEVICE) != 0) {
[...]
+ else if ((attr & FILE_ATTRIBUTE_DIRECTORY) != 0) {
[...]
+ else {
[...]
ERROR:ELSE_AFTER_BRACE: else should follow close brace '}'
#8927: FILE: lib/librte_eal/windows/include_override/dirent.h:475:
+ }
+ else if ((attr & FILE_ATTRIBUTE_DIRECTORY) != 0) {
ERROR:ELSE_AFTER_BRACE: else should follow close brace '}'
#8930: FILE: lib/librte_eal/windows/include_override/dirent.h:478:
+ }
+ else {
ERROR:ELSE_AFTER_BRACE: else should follow close brace '}'
#8939: FILE: lib/librte_eal/windows/include_override/dirent.h:487:
+ }
+ else {
WARNING:BLOCK_COMMENT_STYLE: Block comments should align the * on each line
#8950: FILE: lib/librte_eal/windows/include_override/dirent.h:498:
+ /*
+ * Close directory stream opened by opendir() function. This invalidates the
ERROR:OPEN_BRACE: open brace '{' following function definitions go on the next line
#8954: FILE: lib/librte_eal/windows/include_override/dirent.h:502:
+ static int
+ _wclosedir(
+ _WDIR *dirp)
+ {
ERROR:ELSE_AFTER_BRACE: else should follow close brace '}'
#8978: FILE: lib/librte_eal/windows/include_override/dirent.h:526:
+ }
+ else {
WARNING:BLOCK_COMMENT_STYLE: Block comments should align the * on each line
#8987: FILE: lib/librte_eal/windows/include_override/dirent.h:535:
+ /*
+ * Rewind directory stream such that _wreaddir() returns the very first
ERROR:OPEN_BRACE: open brace '{' following function definitions go on the next line
#8990: FILE: lib/librte_eal/windows/include_override/dirent.h:538:
+ static void
+ _wrewinddir(
+ _WDIR* dirp)
+ {
ERROR:POINTER_LOCATION: "foo* bar" should be "foo *bar"
#8992: FILE: lib/librte_eal/windows/include_override/dirent.h:540:
+ _WDIR* dirp)
WARNING:BRACES: braces {} are not necessary for single statement blocks
#8996: FILE: lib/librte_eal/windows/include_override/dirent.h:544:
+ if (dirp->handle != INVALID_HANDLE_VALUE) {
+ FindClose(dirp->handle);
+ }
ERROR:OPEN_BRACE: open brace '{' following function definitions go on the next line
#9006: FILE: lib/librte_eal/windows/include_override/dirent.h:554:
+ static WIN32_FIND_DATAW*
+ dirent_first(
+ _WDIR *dirp)
+ {
ERROR:ELSE_AFTER_BRACE: else should follow close brace '}'
#9023: FILE: lib/librte_eal/windows/include_override/dirent.h:571:
+ }
+ else {
ERROR:OPEN_BRACE: open brace '{' following function definitions go on the next line
#9034: FILE: lib/librte_eal/windows/include_override/dirent.h:582:
+ static WIN32_FIND_DATAW*
+ dirent_next(
+ _WDIR *dirp)
+ {
ERROR:ELSE_AFTER_BRACE: else should follow close brace '}'
#9048: FILE: lib/librte_eal/windows/include_override/dirent.h:596:
+ }
+ else if (dirp->handle != INVALID_HANDLE_VALUE) {
ERROR:ELSE_AFTER_BRACE: else should follow close brace '}'
#9055: FILE: lib/librte_eal/windows/include_override/dirent.h:603:
+ }
+ else {
WARNING:TYPO_SPELLING: 'occured' may be misspelled - perhaps 'occurred'?
#9056: FILE: lib/librte_eal/windows/include_override/dirent.h:604:
+ /* The very last entry has been processed or an error occured */
WARNING:LONG_LINE_COMMENT: line over 90 characters
#9056: FILE: lib/librte_eal/windows/include_override/dirent.h:604:
+ /* The very last entry has been processed or an error occured */
ERROR:ELSE_AFTER_BRACE: else should follow close brace '}'
#9063: FILE: lib/librte_eal/windows/include_override/dirent.h:611:
+ }
+ else {
WARNING:BLOCK_COMMENT_STYLE: Block comments should align the * on each line
#9074: FILE: lib/librte_eal/windows/include_override/dirent.h:622:
+ /*
+ * Open directory stream using plain old C-string.
ERROR:OPEN_BRACE: open brace '{' following function definitions go on the next line
#9076: FILE: lib/librte_eal/windows/include_override/dirent.h:624:
+ static DIR*
+ opendir(
+ const char *dirname)
+ {
ERROR:POINTER_LOCATION: "(foo*)" should be "(foo *)"
#9090: FILE: lib/librte_eal/windows/include_override/dirent.h:638:
+ dirp = (DIR*)malloc(sizeof(struct DIR));
ERROR:ELSE_AFTER_BRACE: else should follow close brace '}'
#9105: FILE: lib/librte_eal/windows/include_override/dirent.h:653:
+ }
+ else {
ERROR:ELSE_AFTER_BRACE: else should follow close brace '}'
#9111: FILE: lib/librte_eal/windows/include_override/dirent.h:659:
+ }
+ else {
WARNING:BLOCK_COMMENT_STYLE: Block comments should align the * on each line
#9113: FILE: lib/librte_eal/windows/include_override/dirent.h:661:
+ /*
+ * Cannot convert file name to wide-character string. This
WARNING:LONG_LINE_COMMENT: line over 90 characters
#9114: FILE: lib/librte_eal/windows/include_override/dirent.h:662:
+ * occurs if the string contains invalid multi-byte sequences or
ERROR:ELSE_AFTER_BRACE: else should follow close brace '}'
#9122: FILE: lib/librte_eal/windows/include_override/dirent.h:670:
+ }
+ else {
WARNING:BLOCK_COMMENT_STYLE: Block comments should align the * on each line
#9137: FILE: lib/librte_eal/windows/include_override/dirent.h:685:
+ /*
+ * Read next directory entry.
ERROR:OPEN_BRACE: open brace '{' following function definitions go on the next line
#9149: FILE: lib/librte_eal/windows/include_override/dirent.h:697:
+ static struct dirent*
+ readdir(
+ DIR *dirp)
+ {
WARNING:LONG_LINE: line over 90 characters
#9164: FILE: lib/librte_eal/windows/include_override/dirent.h:712:
+ &n, dirp->ent.d_name, PATH_MAX, datap->cFileName, PATH_MAX);
WARNING:BLOCK_COMMENT_STYLE: Block comments should align the * on each line
#9167: FILE: lib/librte_eal/windows/include_override/dirent.h:715:
+ /*
+ * If the file name cannot be represented by a multi-byte string,
WARNING:BRACES: braces {} are not necessary for any arm of this statement
#9193: FILE: lib/librte_eal/windows/include_override/dirent.h:741:
+ if ((attr & FILE_ATTRIBUTE_DEVICE) != 0) {
[...]
+ else if ((attr & FILE_ATTRIBUTE_DIRECTORY) != 0) {
[...]
+ else {
[...]
ERROR:ELSE_AFTER_BRACE: else should follow close brace '}'
#9196: FILE: lib/librte_eal/windows/include_override/dirent.h:744:
+ }
+ else if ((attr & FILE_ATTRIBUTE_DIRECTORY) != 0) {
ERROR:ELSE_AFTER_BRACE: else should follow close brace '}'
#9199: FILE: lib/librte_eal/windows/include_override/dirent.h:747:
+ }
+ else {
ERROR:ELSE_AFTER_BRACE: else should follow close brace '}'
#9208: FILE: lib/librte_eal/windows/include_override/dirent.h:756:
+ }
+ else {
WARNING:LONG_LINE_COMMENT: line over 90 characters
#9210: FILE: lib/librte_eal/windows/include_override/dirent.h:758:
+ * Cannot convert file name to multi-byte string so construct
WARNING:BLOCK_COMMENT_STYLE: Block comments should align the * on each line
#9210: FILE: lib/librte_eal/windows/include_override/dirent.h:758:
+ /*
+ * Cannot convert file name to multi-byte string so construct
ERROR:ELSE_AFTER_BRACE: else should follow close brace '}'
#9225: FILE: lib/librte_eal/windows/include_override/dirent.h:773:
+ }
+ else {
WARNING:BLOCK_COMMENT_STYLE: Block comments should align the * on each line
#9234: FILE: lib/librte_eal/windows/include_override/dirent.h:782:
+ /*
+ * Close directory stream.
ERROR:OPEN_BRACE: open brace '{' following function definitions go on the next line
#9236: FILE: lib/librte_eal/windows/include_override/dirent.h:784:
+ static int
+ closedir(
+ DIR *dirp)
+ {
ERROR:ELSE_AFTER_BRACE: else should follow close brace '}'
#9251: FILE: lib/librte_eal/windows/include_override/dirent.h:799:
+ }
+ else {
WARNING:BLOCK_COMMENT_STYLE: Block comments should align the * on each line
#9262: FILE: lib/librte_eal/windows/include_override/dirent.h:810:
+ /*
+ * Rewind directory stream to beginning.
ERROR:OPEN_BRACE: open brace '{' following function definitions go on the next line
#9264: FILE: lib/librte_eal/windows/include_override/dirent.h:812:
+ static void
+ rewinddir(
+ DIR* dirp)
+ {
ERROR:POINTER_LOCATION: "foo* bar" should be "foo *bar"
#9266: FILE: lib/librte_eal/windows/include_override/dirent.h:814:
+ DIR* dirp)
ERROR:OPEN_BRACE: open brace '{' following function definitions go on the next line
#9273: FILE: lib/librte_eal/windows/include_override/dirent.h:821:
+ static int
+ dirent_mbstowcs_s(
+ size_t *pReturnValue,
+ wchar_t *wcstr,
+ size_t sizeInWords,
+ const char *mbstr,
+ size_t count)
+ {
WARNING:BRACES: braces {} are not necessary for single statement blocks
#9299: FILE: lib/librte_eal/windows/include_override/dirent.h:847:
+ if (n >= sizeInWords) {
+ n = sizeInWords - 1;
+ }
WARNING:BRACES: braces {} are not necessary for single statement blocks
#9306: FILE: lib/librte_eal/windows/include_override/dirent.h:854:
+ if (pReturnValue) {
+ *pReturnValue = n + 1;
+ }
ERROR:ELSE_AFTER_BRACE: else should follow close brace '}'
#9314: FILE: lib/librte_eal/windows/include_override/dirent.h:862:
+ }
+ else {
ERROR:OPEN_BRACE: open brace '{' following function definitions go on the next line
#9327: FILE: lib/librte_eal/windows/include_override/dirent.h:875:
+ static int
+ dirent_wcstombs_s(
+ size_t *pReturnValue,
+ char *mbstr,
+ size_t sizeInBytes, /* max size of mbstr */
+ const wchar_t *wcstr,
+ size_t count)
+ {
WARNING:BRACES: braces {} are not necessary for single statement blocks
#9353: FILE: lib/librte_eal/windows/include_override/dirent.h:901:
+ if (n >= sizeInBytes) {
+ n = sizeInBytes - 1;
+ }
WARNING:BRACES: braces {} are not necessary for single statement blocks
#9360: FILE: lib/librte_eal/windows/include_override/dirent.h:908:
+ if (pReturnValue) {
+ *pReturnValue = n + 1;
+ }
ERROR:ELSE_AFTER_BRACE: else should follow close brace '}'
#9368: FILE: lib/librte_eal/windows/include_override/dirent.h:916:
+ }
+ else {
ERROR:OPEN_BRACE: open brace '{' following function definitions go on the next line
#9381: FILE: lib/librte_eal/windows/include_override/dirent.h:929:
+ static void
+ dirent_set_errno(
+ int error)
+ {
WARNING:BLOCK_COMMENT_STYLE: Block comments should align the * on each line
#9420: FILE: lib/librte_eal/windows/include_override/getopt.h:12:
+/*
+* Copyright (c) 2002 Todd C. Miller <Todd.Miller@courtesan.com>
WARNING:BLOCK_COMMENT_STYLE: Block comments should align the * on each line
#9439: FILE: lib/librte_eal/windows/include_override/getopt.h:31:
+/*-
+* Copyright (c) 2000 The NetBSD Foundation, Inc.
ERROR:COMPLEX_MACRO: Macros with complex values should be enclosed in parentheses
#9494: FILE: lib/librte_eal/windows/include_override/getopt.h:86:
+#define BADCH (int)'?'
WARNING:SPACE_BEFORE_TAB: please, no space before tabs
#9496: FILE: lib/librte_eal/windows/include_override/getopt.h:88:
+#define^IINORDER ^I(int)1$
WARNING:TYPECAST_INT_CONSTANT: Unnecessary typecast of c90 int constant
#9496: FILE: lib/librte_eal/windows/include_override/getopt.h:88:
+#define INORDER (int)1
ERROR:SPACING: need consistent spacing around '*' (ctx:WxV)
#9501: FILE: lib/librte_eal/windows/include_override/getopt.h:93:
+ extern char __declspec(dllimport) *__progname;
^
WARNING:STATIC_CONST_CHAR_ARRAY: static char array declaration should probably be static const char
#9505: FILE: lib/librte_eal/windows/include_override/getopt.h:97:
+ static char EMSG[] = "";
WARNING:FUNCTION_ARGUMENTS: function definition argument 'char * const' should also have an identifier name
#9516: FILE: lib/librte_eal/windows/include_override/getopt.h:108:
+extern int getopt(int nargc, char * const *nargv, const char *options);
ERROR:CODE_INDENT: code indent should use tabs where possible
#9519: FILE: lib/librte_eal/windows/include_override/getopt.h:111:
+ const struct option *, int *, int);$
WARNING:LEADING_SPACE: please, no spaces at the start of a line
#9519: FILE: lib/librte_eal/windows/include_override/getopt.h:111:
+ const struct option *, int *, int);$
WARNING:LEADING_SPACE: please, no spaces at the start of a line
#9526: FILE: lib/librte_eal/windows/include_override/getopt.h:118:
+ (void)fprintf(stderr, "%s: ", __progname);$
WARNING:LEADING_SPACE: please, no spaces at the start of a line
#9527: FILE: lib/librte_eal/windows/include_override/getopt.h:119:
+ if (fmt != NULL)$
WARNING:LEADING_SPACE: please, no spaces at the start of a line
#9529: FILE: lib/librte_eal/windows/include_override/getopt.h:121:
+ (void)fprintf(stderr, "
");$
WARNING:LEADING_SPACE: please, no spaces at the start of a line
#9535: FILE: lib/librte_eal/windows/include_override/getopt.h:127:
+ va_list ap;$
WARNING:LEADING_SPACE: please, no spaces at the start of a line
#9536: FILE: lib/librte_eal/windows/include_override/getopt.h:128:
+ va_start(ap, fmt);$
WARNING:LEADING_SPACE: please, no spaces at the start of a line
#9537: FILE: lib/librte_eal/windows/include_override/getopt.h:129:
+ _vwarnx(fmt, ap);$
WARNING:LEADING_SPACE: please, no spaces at the start of a line
#9538: FILE: lib/librte_eal/windows/include_override/getopt.h:130:
+ va_end(ap);$
WARNING:BLOCK_COMMENT_STYLE: Block comments should align the * on each line
#9542: FILE: lib/librte_eal/windows/include_override/getopt.h:134:
+/*
+* Compute the greatest common divisor of a and b.
WARNING:LEADING_SPACE: please, no spaces at the start of a line
#9547: FILE: lib/librte_eal/windows/include_override/getopt.h:139:
+ int c;$
WARNING:LEADING_SPACE: please, no spaces at the start of a line
#9549: FILE: lib/librte_eal/windows/include_override/getopt.h:141:
+ c = a % b;$
WARNING:LEADING_SPACE: please, no spaces at the start of a line
#9550: FILE: lib/librte_eal/windows/include_override/getopt.h:142:
+ while (c != 0) {$
WARNING:SUSPECT_CODE_INDENT: suspect code indent for conditional statements (4, 12)
#9550: FILE: lib/librte_eal/windows/include_override/getopt.h:142:
+ while (c != 0) {
+ a = b;
WARNING:LEADING_SPACE: please, no spaces at the start of a line
#9554: FILE: lib/librte_eal/windows/include_override/getopt.h:146:
+ }$
WARNING:LEADING_SPACE: please, no spaces at the start of a line
#9556: FILE: lib/librte_eal/windows/include_override/getopt.h:148:
+ return (b);$
WARNING:BLOCK_COMMENT_STYLE: Block comments should align the * on each line
#9560: FILE: lib/librte_eal/windows/include_override/getopt.h:152:
+/*
+* Exchange the block from nonopt_start to nonopt_end with the block
WARNING:LEADING_SPACE: please, no spaces at the start of a line
#9567: FILE: lib/librte_eal/windows/include_override/getopt.h:159:
+ int cstart, cyclelen, i, j, ncycle, nnonopts, nopts, pos;$
WARNING:LEADING_SPACE: please, no spaces at the start of a line
#9568: FILE: lib/librte_eal/windows/include_override/getopt.h:160:
+ char *swap;$
WARNING:BLOCK_COMMENT_STYLE: Block comments should align the * on each line
#9571: FILE: lib/librte_eal/windows/include_override/getopt.h:163:
+ /*
+ * compute lengths of blocks and number and size of cycles
WARNING:LEADING_SPACE: please, no spaces at the start of a line
#9573: FILE: lib/librte_eal/windows/include_override/getopt.h:165:
+ nnonopts = panonopt_end - panonopt_start;$
WARNING:LEADING_SPACE: please, no spaces at the start of a line
#9574: FILE: lib/librte_eal/windows/include_override/getopt.h:166:
+ nopts = opt_end - panonopt_end;$
WARNING:LEADING_SPACE: please, no spaces at the start of a line
#9575: FILE: lib/librte_eal/windows/include_override/getopt.h:167:
+ ncycle = gcd(nnonopts, nopts);$
WARNING:LEADING_SPACE: please, no spaces at the start of a line
#9576: FILE: lib/librte_eal/windows/include_override/getopt.h:168:
+ cyclelen = (opt_end - panonopt_start) / ncycle;$
WARNING:LEADING_SPACE: please, no spaces at the start of a line
#9578: FILE: lib/librte_eal/windows/include_override/getopt.h:170:
+ for (i = 0; i < ncycle; i++) {$
WARNING:SUSPECT_CODE_INDENT: suspect code indent for conditional statements (8, 12)
#9581: FILE: lib/librte_eal/windows/include_override/getopt.h:173:
+ for (j = 0; j < cyclelen; j++) {
+ if (pos >= panonopt_end)
WARNING:TABSTOP: Statements should start on a tabstop
#9582: FILE: lib/librte_eal/windows/include_override/getopt.h:174:
+ if (pos >= panonopt_end)
WARNING:TABSTOP: Statements should start on a tabstop
#9584: FILE: lib/librte_eal/windows/include_override/getopt.h:176:
+ else
WARNING:LEADING_SPACE: please, no spaces at the start of a line
#9592: FILE: lib/librte_eal/windows/include_override/getopt.h:184:
+ }$
WARNING:LEADING_SPACE: please, no spaces at the start of a line
#9629: FILE: lib/librte_eal/windows/include_override/getopt.h:221:
+ const char *name;^I^I/* option name, without leading hyphens */$
WARNING:LEADING_SPACE: please, no spaces at the start of a line
#9630: FILE: lib/librte_eal/windows/include_override/getopt.h:222:
+ int has_arg;^I^I/* does it take an argument?^I^I*/$
WARNING:LEADING_SPACE: please, no spaces at the start of a line
#9631: FILE: lib/librte_eal/windows/include_override/getopt.h:223:
+ int *flag;^I^I/* where to save its status, or NULL^I*/$
WARNING:LEADING_SPACE: please, no spaces at the start of a line
#9632: FILE: lib/librte_eal/windows/include_override/getopt.h:224:
+ int val;^I^I/* its associated status value^I^I*/$
WARNING:SPACE_BEFORE_TAB: please, no space before tabs
#9635: FILE: lib/librte_eal/windows/include_override/getopt.h:227:
+enum ^I^I/* permitted values for its `has_arg' field...^I*/$
WARNING:SPACE_BEFORE_TAB: please, no space before tabs
#9637: FILE: lib/librte_eal/windows/include_override/getopt.h:229:
+ no_argument = 0, ^I/* option never takes an argument^I*/$
WARNING:LEADING_SPACE: please, no spaces at the start of a line
#9637: FILE: lib/librte_eal/windows/include_override/getopt.h:229:
+ no_argument = 0, ^I/* option never takes an argument^I*/$
WARNING:LEADING_SPACE: please, no spaces at the start of a line
#9638: FILE: lib/librte_eal/windows/include_override/getopt.h:230:
+ required_argument,^I^I/* option always requires an argument^I*/$
WARNING:LEADING_SPACE: please, no spaces at the start of a line
#9639: FILE: lib/librte_eal/windows/include_override/getopt.h:231:
+ optional_argument^I^I/* option may take an argument^I^I*/$
WARNING:FUNCTION_ARGUMENTS: function definition argument 'char * const' should also have an identifier name
#9642: FILE: lib/librte_eal/windows/include_override/getopt.h:234:
+extern int getopt_long(int nargc, char * const *nargv, const char *options,
WARNING:LEADING_SPACE: please, no spaces at the start of a line
#9643: FILE: lib/librte_eal/windows/include_override/getopt.h:235:
+ const struct option *long_options, int *idx);$
WARNING:FUNCTION_ARGUMENTS: function definition argument 'char * const' should also have an identifier name
#9644: FILE: lib/librte_eal/windows/include_override/getopt.h:236:
+extern int getopt_long_only(int nargc, char * const *nargv, const char *options,
WARNING:LEADING_SPACE: please, no spaces at the start of a line
#9645: FILE: lib/librte_eal/windows/include_override/getopt.h:237:
+ const struct option *long_options, int *idx);$
WARNING:SPACE_BEFORE_TAB: please, no space before tabs
#9754: FILE: lib/librte_eal/windows/include_override/net/ethernet.h:88:
+#define^IETHERTYPE_DLOG1 ^I0x0660^I/* DLOG (?) */$
WARNING:SPACE_BEFORE_TAB: please, no space before tabs
#9755: FILE: lib/librte_eal/windows/include_override/net/ethernet.h:89:
+#define^IETHERTYPE_DLOG2 ^I0x0661^I/* DLOG (?) */$
WARNING:SPACE_BEFORE_TAB: please, no space before tabs
#9760: FILE: lib/librte_eal/windows/include_override/net/ethernet.h:94:
+#define^IETHERTYPE_CHAOS ^I0x0804^I/* CHAOSnet */$
WARNING:SPACE_BEFORE_TAB: please, no space before tabs
#9764: FILE: lib/librte_eal/windows/include_override/net/ethernet.h:98:
+#define^IETHERTYPE_FRARP ^I0x0808^I/* Frame Relay ARP (RFC1701) */$
WARNING:SPACE_BEFORE_TAB: please, no space before tabs
#9770: FILE: lib/librte_eal/windows/include_override/net/ethernet.h:104:
+#define^IETHERTYPE_VINES ^I0x0BAD^I/* Banyan VINES */$
WARNING:SPACE_BEFORE_TAB: please, no space before tabs
#9784: FILE: lib/librte_eal/windows/include_override/net/ethernet.h:118:
+#define^IETHERTYPE_VALID ^I0x1600^I/* VALID system protocol */$
WARNING:LONG_LINE_COMMENT: line over 90 characters
#9785: FILE: lib/librte_eal/windows/include_override/net/ethernet.h:119:
+#define ETHERTYPE_DOGFIGHT 0x1989 /* Artificial Horizons ("Aviator" dogfight simulator [on Sun]) */
WARNING:BLOCK_COMMENT_STYLE: Block comments use * on subsequent lines
#9789: FILE: lib/librte_eal/windows/include_override/net/ethernet.h:123:
+ /* The following 3C0x types
+ are unregistered: */
WARNING:BLOCK_COMMENT_STYLE: Block comments use a trailing */ on a separate line
#9789: FILE: lib/librte_eal/windows/include_override/net/ethernet.h:123:
+ are unregistered: */
WARNING:LONG_LINE_COMMENT: line over 90 characters
#9790: FILE: lib/librte_eal/windows/include_override/net/ethernet.h:124:
+#define ETHERTYPE_NBPVCD 0x3C00 /* 3Com NBP virtual circuit datagram (like XNS SPP) not registered */
WARNING:LONG_LINE_COMMENT: line over 90 characters
#9791: FILE: lib/librte_eal/windows/include_override/net/ethernet.h:125:
+#define ETHERTYPE_NBPSCD 0x3C01 /* 3Com NBP System control datagram not registered */
WARNING:LONG_LINE_COMMENT: line over 90 characters
#9792: FILE: lib/librte_eal/windows/include_override/net/ethernet.h:126:
+#define ETHERTYPE_NBPCREQ 0x3C02 /* 3Com NBP Connect request (virtual cct) not registered */
WARNING:LONG_LINE_COMMENT: line over 90 characters
#9795: FILE: lib/librte_eal/windows/include_override/net/ethernet.h:129:
+#define ETHERTYPE_NBPCLREQ 0x3C05 /* 3Com NBP Close request (virtual cct) not registered */
WARNING:LONG_LINE_COMMENT: line over 90 characters
#9797: FILE: lib/librte_eal/windows/include_override/net/ethernet.h:131:
+#define ETHERTYPE_NBPDG 0x3C07 /* 3Com NBP Datagram (like XNS IDP) not registered */
WARNING:LONG_LINE_COMMENT: line over 90 characters
#9801: FILE: lib/librte_eal/windows/include_override/net/ethernet.h:135:
+#define ETHERTYPE_NBPRAS 0x3C0B /* 3Com NBP Remote adaptor status request not registered */
WARNING:LONG_LINE_COMMENT: line over 90 characters
#9802: FILE: lib/librte_eal/windows/include_override/net/ethernet.h:136:
+#define ETHERTYPE_NBPRAR 0x3C0C /* 3Com NBP Remote adaptor response not registered */
WARNING:LONG_LINE_COMMENT: line over 90 characters
#9816: FILE: lib/librte_eal/windows/include_override/net/ethernet.h:150:
+#define ETHERTYPE_DECDIAG 0x6005 /* DEC diagnostic protocol (at interface initialization?) */
WARNING:LONG_LINE_COMMENT: line over 90 characters
#9864: FILE: lib/librte_eal/windows/include_override/net/ethernet.h:198:
+#define ETHERTYPE_DECAM 0x8048 /* DEC Availability Manager for Distributed Systems DECamds (but someone at DEC says not) */
WARNING:LONG_LINE_COMMENT: line over 90 characters
#9893: FILE: lib/librte_eal/windows/include_override/net/ethernet.h:227:
+ /* 0x80C0 - 0x80C3 DCA (Digital Comm. Assoc.) Data Exchange Cluster */
WARNING:LONG_LINE_COMMENT: line over 90 characters
#9903: FILE: lib/librte_eal/windows/include_override/net/ethernet.h:237:
+ /* 0x80DE - 0x80DF TRFS (Integrated Solutions Transparent Remote File System) */
WARNING:LONG_LINE_COMMENT: line over 90 characters
#9912: FILE: lib/librte_eal/windows/include_override/net/ethernet.h:246:
+#define ETHERTYPE_BOFL 0x8102 /* Wellfleet; BOFL (Breath OF Life) pkts [every 5-10 secs.] */
WARNING:LONG_LINE_COMMENT: line over 90 characters
#9924: FILE: lib/librte_eal/windows/include_override/net/ethernet.h:258:
+#define ETHERTYPE_AMOEBA 0x8145 /* Vrije Universiteit (NL) Amoeba 4 RPC (obsolete) */
WARNING:LONG_LINE_COMMENT: line over 90 characters
#9925: FILE: lib/librte_eal/windows/include_override/net/ethernet.h:259:
+#define ETHERTYPE_FLIP 0x8146 /* Vrije Universiteit (NL) FLIP (Fast Local Internet Protocol) */
WARNING:LONG_LINE_COMMENT: line over 90 characters
#9974: FILE: lib/librte_eal/windows/include_override/net/ethernet.h:308:
+#define ETHERTYPE_MICP 0x873A /* Control Technology Inc. Mcast Industrial Ctrl Proto. */
WARNING:LONG_LINE_COMMENT: line over 90 characters
#9982: FILE: lib/librte_eal/windows/include_override/net/ethernet.h:316:
+#define ETHERTYPE_HITACHI 0x8820 /* Hitachi Cable (Optoelectronic Systems Laboratory) */
WARNING:LONG_LINE_COMMENT: line over 90 characters
#9985: FILE: lib/librte_eal/windows/include_override/net/ethernet.h:319:
+#define ETHERTYPE_AXIS 0x8856 /* Axis Communications AB proprietary bootstrap/config */
WARNING:LONG_LINE_COMMENT: line over 90 characters
#9992: FILE: lib/librte_eal/windows/include_override/net/ethernet.h:326:
+#define ETHERTYPE_XNSSM 0x9001 /* 3Com (Formerly Bridge Communications), XNS Systems Management */
WARNING:LONG_LINE_COMMENT: line over 90 characters
#9993: FILE: lib/librte_eal/windows/include_override/net/ethernet.h:327:
+#define ETHERTYPE_TCPSM 0x9002 /* 3Com (Formerly Bridge Communications), TCP/IP Systems Management */
WARNING:LONG_LINE_COMMENT: line over 90 characters
#9994: FILE: lib/librte_eal/windows/include_override/net/ethernet.h:328:
+#define ETHERTYPE_BCLOOP 0x9003 /* 3Com (Formerly Bridge Communications), loopback detection */
WARNING:FUNCTION_ARGUMENTS: function definition argument 'const uint8_t *' should also have an identifier name
#10038: FILE: lib/librte_eal/windows/include_override/net/ethernet.h:372:
+extern uint32_t ether_crc32_le(const uint8_t *, size_t);
WARNING:FUNCTION_ARGUMENTS: function definition argument 'size_t' should also have an identifier name
#10038: FILE: lib/librte_eal/windows/include_override/net/ethernet.h:372:
+extern uint32_t ether_crc32_le(const uint8_t *, size_t);
WARNING:FUNCTION_ARGUMENTS: function definition argument 'const uint8_t *' should also have an identifier name
#10039: FILE: lib/librte_eal/windows/include_override/net/ethernet.h:373:
+extern uint32_t ether_crc32_be(const uint8_t *, size_t);
WARNING:FUNCTION_ARGUMENTS: function definition argument 'size_t' should also have an identifier name
#10039: FILE: lib/librte_eal/windows/include_override/net/ethernet.h:373:
+extern uint32_t ether_crc32_be(const uint8_t *, size_t);
WARNING:FUNCTION_ARGUMENTS: function definition argument 'struct ifnet *' should also have an identifier name
#10040: FILE: lib/librte_eal/windows/include_override/net/ethernet.h:374:
+extern void ether_demux(struct ifnet *, struct mbuf *);
WARNING:FUNCTION_ARGUMENTS: function definition argument 'struct mbuf *' should also have an identifier name
#10040: FILE: lib/librte_eal/windows/include_override/net/ethernet.h:374:
+extern void ether_demux(struct ifnet *, struct mbuf *);
WARNING:FUNCTION_ARGUMENTS: function definition argument 'struct ifnet *' should also have an identifier name
#10041: FILE: lib/librte_eal/windows/include_override/net/ethernet.h:375:
+extern void ether_ifattach(struct ifnet *, const u_int8_t *);
WARNING:FUNCTION_ARGUMENTS: function definition argument 'const u_int8_t *' should also have an identifier name
#10041: FILE: lib/librte_eal/windows/include_override/net/ethernet.h:375:
+extern void ether_ifattach(struct ifnet *, const u_int8_t *);
WARNING:FUNCTION_ARGUMENTS: function definition argument 'struct ifnet *' should also have an identifier name
#10042: FILE: lib/librte_eal/windows/include_override/net/ethernet.h:376:
+extern void ether_ifdetach(struct ifnet *);
WARNING:FUNCTION_ARGUMENTS: function definition argument 'struct ifnet *' should also have an identifier name
#10043: FILE: lib/librte_eal/windows/include_override/net/ethernet.h:377:
+extern int ether_ioctl(struct ifnet *, u_long, caddr_t);
WARNING:FUNCTION_ARGUMENTS: function definition argument 'u_long' should also have an identifier name
#10043: FILE: lib/librte_eal/windows/include_override/net/ethernet.h:377:
+extern int ether_ioctl(struct ifnet *, u_long, caddr_t);
WARNING:FUNCTION_ARGUMENTS: function definition argument 'caddr_t' should also have an identifier name
#10043: FILE: lib/librte_eal/windows/include_override/net/ethernet.h:377:
+extern int ether_ioctl(struct ifnet *, u_long, caddr_t);
WARNING:FUNCTION_ARGUMENTS: function definition argument 'struct ifnet *' should also have an identifier name
#10044: FILE: lib/librte_eal/windows/include_override/net/ethernet.h:378:
+extern int ether_output(struct ifnet *,
WARNING:FUNCTION_ARGUMENTS: function definition argument 'struct mbuf *' should also have an identifier name
#10044: FILE: lib/librte_eal/windows/include_override/net/ethernet.h:378:
+extern int ether_output(struct ifnet *,
WARNING:FUNCTION_ARGUMENTS: function definition argument 'struct sockaddr *' should also have an identifier name
#10044: FILE: lib/librte_eal/windows/include_override/net/ethernet.h:378:
+extern int ether_output(struct ifnet *,
WARNING:FUNCTION_ARGUMENTS: function definition argument 'struct route *' should also have an identifier name
#10044: FILE: lib/librte_eal/windows/include_override/net/ethernet.h:378:
+extern int ether_output(struct ifnet *,
WARNING:FUNCTION_ARGUMENTS: function definition argument 'struct ifnet *' should also have an identifier name
#10046: FILE: lib/librte_eal/windows/include_override/net/ethernet.h:380:
+extern int ether_output_frame(struct ifnet *, struct mbuf *);
WARNING:FUNCTION_ARGUMENTS: function definition argument 'struct mbuf *' should also have an identifier name
#10046: FILE: lib/librte_eal/windows/include_override/net/ethernet.h:380:
+extern int ether_output_frame(struct ifnet *, struct mbuf *);
WARNING:FUNCTION_ARGUMENTS: function definition argument 'const u_int8_t *' should also have an identifier name
#10047: FILE: lib/librte_eal/windows/include_override/net/ethernet.h:381:
+extern char *ether_sprintf(const u_int8_t *);
WARNING:FUNCTION_ARGUMENTS: function definition argument 'struct bpf_if *' should also have an identifier name
#10048: FILE: lib/librte_eal/windows/include_override/net/ethernet.h:382:
+void ether_vlan_mtap(struct bpf_if *, struct mbuf *,
WARNING:FUNCTION_ARGUMENTS: function definition argument 'struct mbuf *' should also have an identifier name
#10048: FILE: lib/librte_eal/windows/include_override/net/ethernet.h:382:
+void ether_vlan_mtap(struct bpf_if *, struct mbuf *,
WARNING:FUNCTION_ARGUMENTS: function definition argument 'void *' should also have an identifier name
#10048: FILE: lib/librte_eal/windows/include_override/net/ethernet.h:382:
+void ether_vlan_mtap(struct bpf_if *, struct mbuf *,
WARNING:FUNCTION_ARGUMENTS: function definition argument 'u_int' should also have an identifier name
#10048: FILE: lib/librte_eal/windows/include_override/net/ethernet.h:382:
+void ether_vlan_mtap(struct bpf_if *, struct mbuf *,
WARNING:FUNCTION_ARGUMENTS: function definition argument 'struct mbuf *' should also have an identifier name
#10050: FILE: lib/librte_eal/windows/include_override/net/ethernet.h:384:
+struct mbuf *ether_vlanencap(struct mbuf *, uint16_t);
WARNING:FUNCTION_ARGUMENTS: function definition argument 'uint16_t' should also have an identifier name
#10050: FILE: lib/librte_eal/windows/include_override/net/ethernet.h:384:
+struct mbuf *ether_vlanencap(struct mbuf *, uint16_t);
WARNING:FUNCTION_ARGUMENTS: function definition argument 'const char *' should also have an identifier name
#10061: FILE: lib/librte_eal/windows/include_override/net/ethernet.h:395:
+struct ether_addr *ether_aton_r(const char *, struct ether_addr *);
WARNING:FUNCTION_ARGUMENTS: function definition argument 'struct ether_addr *' should also have an identifier name
#10061: FILE: lib/librte_eal/windows/include_override/net/ethernet.h:395:
+struct ether_addr *ether_aton_r(const char *, struct ether_addr *);
WARNING:FUNCTION_ARGUMENTS: function definition argument 'const char *' should also have an identifier name
#10062: FILE: lib/librte_eal/windows/include_override/net/ethernet.h:396:
+int ether_hostton(const char *, struct ether_addr *);
WARNING:FUNCTION_ARGUMENTS: function definition argument 'struct ether_addr *' should also have an identifier name
#10062: FILE: lib/librte_eal/windows/include_override/net/ethernet.h:396:
+int ether_hostton(const char *, struct ether_addr *);
WARNING:FUNCTION_ARGUMENTS: function definition argument 'const char *' should also have an identifier name
#10063: FILE: lib/librte_eal/windows/include_override/net/ethernet.h:397:
+int ether_line(const char *, struct ether_addr *, char *);
WARNING:FUNCTION_ARGUMENTS: function definition argument 'struct ether_addr *' should also have an identifier name
#10063: FILE: lib/librte_eal/windows/include_override/net/ethernet.h:397:
+int ether_line(const char *, struct ether_addr *, char *);
WARNING:FUNCTION_ARGUMENTS: function definition argument 'char *' should also have an identifier name
#10063: FILE: lib/librte_eal/windows/include_override/net/ethernet.h:397:
+int ether_line(const char *, struct ether_addr *, char *);
WARNING:SPACE_BEFORE_TAB: please, no space before tabs
#10064: FILE: lib/librte_eal/windows/include_override/net/ethernet.h:398:
+char ^I*ether_ntoa(const struct ether_addr *);$
WARNING:FUNCTION_ARGUMENTS: function definition argument 'const struct ether_addr *' should also have an identifier name
#10064: FILE: lib/librte_eal/windows/include_override/net/ethernet.h:398:
+char *ether_ntoa(const struct ether_addr *);
WARNING:SPACE_BEFORE_TAB: please, no space before tabs
#10065: FILE: lib/librte_eal/windows/include_override/net/ethernet.h:399:
+char ^I*ether_ntoa_r(const struct ether_addr *, char *);$
WARNING:FUNCTION_ARGUMENTS: function definition argument 'const struct ether_addr *' should also have an identifier name
#10065: FILE: lib/librte_eal/windows/include_override/net/ethernet.h:399:
+char *ether_ntoa_r(const struct ether_addr *, char *);
WARNING:FUNCTION_ARGUMENTS: function definition argument 'char *' should also have an identifier name
#10065: FILE: lib/librte_eal/windows/include_override/net/ethernet.h:399:
+char *ether_ntoa_r(const struct ether_addr *, char *);
WARNING:FUNCTION_ARGUMENTS: function definition argument 'char *' should also have an identifier name
#10066: FILE: lib/librte_eal/windows/include_override/net/ethernet.h:400:
+int ether_ntohost(char *, const struct ether_addr *);
WARNING:FUNCTION_ARGUMENTS: function definition argument 'const struct ether_addr *' should also have an identifier name
#10066: FILE: lib/librte_eal/windows/include_override/net/ethernet.h:400:
+int ether_ntohost(char *, const struct ether_addr *);
WARNING:BLOCK_COMMENT_STYLE: Block comments should align the * on each line
#10143: FILE: lib/librte_eal/windows/include_override/pthread.h:2:
+/* SPDX-License-Identifier: BSD-3-Clause
+* Copyright(c) 2017-2018 Intel Corporation
ERROR:POINTER_LOCATION: "foo* bar" should be "foo *bar"
#10151: FILE: lib/librte_eal/windows/include_override/pthread.h:10:
+typedef void* pthread_t;
WARNING:LONG_LINE: line over 90 characters
#10156: FILE: lib/librte_eal/windows/include_override/pthread.h:15:
+#define pthread_barrier_init(barrier,attr,count) InitializeSynchronizationBarrier(barrier,count,-1)
ERROR:SPACING: space required after that ',' (ctx:VxV)
#10156: FILE: lib/librte_eal/windows/include_override/pthread.h:15:
+#define pthread_barrier_init(barrier,attr,count) InitializeSynchronizationBarrier(barrier,count,-1)
^
ERROR:SPACING: space required after that ',' (ctx:VxV)
#10156: FILE: lib/librte_eal/windows/include_override/pthread.h:15:
+#define pthread_barrier_init(barrier,attr,count) InitializeSynchronizationBarrier(barrier,count,-1)
^
ERROR:SPACING: space required after that ',' (ctx:VxV)
#10156: FILE: lib/librte_eal/windows/include_override/pthread.h:15:
+#define pthread_barrier_init(barrier,attr,count) InitializeSynchronizationBarrier(barrier,count,-1)
^
ERROR:SPACING: space required after that ',' (ctx:VxO)
#10156: FILE: lib/librte_eal/windows/include_override/pthread.h:15:
+#define pthread_barrier_init(barrier,attr,count) InitializeSynchronizationBarrier(barrier,count,-1)
^
ERROR:SPACING: space required before that '-' (ctx:OxV)
#10156: FILE: lib/librte_eal/windows/include_override/pthread.h:15:
+#define pthread_barrier_init(barrier,attr,count) InitializeSynchronizationBarrier(barrier,count,-1)
^
WARNING:LONG_LINE: line over 90 characters
#10157: FILE: lib/librte_eal/windows/include_override/pthread.h:16:
+#define pthread_barrier_wait(barrier) EnterSynchronizationBarrier(barrier,SYNCHRONIZATION_BARRIER_FLAGS_BLOCK_ONLY)
ERROR:SPACING: space required after that ',' (ctx:VxV)
#10157: FILE: lib/librte_eal/windows/include_override/pthread.h:16:
+#define pthread_barrier_wait(barrier) EnterSynchronizationBarrier(barrier,SYNCHRONIZATION_BARRIER_FLAGS_BLOCK_ONLY)
^
ERROR:SPACING: space required after that ',' (ctx:VxV)
#10159: FILE: lib/librte_eal/windows/include_override/pthread.h:18:
+#define pthread_cancel(thread) TerminateThread(thread,0)
^
ERROR:SPACING: space required after that ',' (ctx:VxV)
#10160: FILE: lib/librte_eal/windows/include_override/pthread.h:19:
+#define pthread_mutex_lock(mutex) WaitForSingleObject(mutex,INFINITE)
^
WARNING:LONG_LINE: line over 90 characters
#10166: FILE: lib/librte_eal/windows/include_override/pthread.h:25:
+#define pthread_self() ((pthread_t)GetCurrentThreadId())
WARNING:LONG_LINE: line over 90 characters
#10167: FILE: lib/librte_eal/windows/include_override/pthread.h:26:
+#define pthread_setaffinity_np(thread,size,cpuset) WinSetThreadAffinityMask(thread, cpuset)
ERROR:SPACING: space required after that ',' (ctx:VxV)
#10167: FILE: lib/librte_eal/windows/include_override/pthread.h:26:
+#define pthread_setaffinity_np(thread,size,cpuset) WinSetThreadAffinityMask(thread, cpuset)
^
ERROR:SPACING: space required after that ',' (ctx:VxV)
#10167: FILE: lib/librte_eal/windows/include_override/pthread.h:26:
+#define pthread_setaffinity_np(thread,size,cpuset) WinSetThreadAffinityMask(thread, cpuset)
^
WARNING:LONG_LINE: line over 90 characters
#10168: FILE: lib/librte_eal/windows/include_override/pthread.h:27:
+#define pthread_getaffinity_np(thread,size,cpuset) WinGetThreadAffinityMask(thread, cpuset)
ERROR:SPACING: space required after that ',' (ctx:VxV)
#10168: FILE: lib/librte_eal/windows/include_override/pthread.h:27:
+#define pthread_getaffinity_np(thread,size,cpuset) WinGetThreadAffinityMask(thread, cpuset)
^
ERROR:SPACING: space required after that ',' (ctx:VxV)
#10168: FILE: lib/librte_eal/windows/include_override/pthread.h:27:
+#define pthread_getaffinity_np(thread,size,cpuset) WinGetThreadAffinityMask(thread, cpuset)
^
WARNING:LONG_LINE: line over 90 characters
#10169: FILE: lib/librte_eal/windows/include_override/pthread.h:28:
+#define pthread_create(threadID, threadattr, threadfunc, args) WinCreateThreadOverride(threadID, threadattr, threadfunc, args)
ERROR:POINTER_LOCATION: "foo* bar" should be "foo *bar"
#10174: FILE: lib/librte_eal/windows/include_override/pthread.h:33:
+static inline int WinSetThreadAffinityMask(void* threadID, unsigned long *cpuset)
ERROR:POINTER_LOCATION: "foo* bar" should be "foo *bar"
#10180: FILE: lib/librte_eal/windows/include_override/pthread.h:39:
+static inline int WinGetThreadAffinityMask(void* threadID, unsigned long *cpuset)
WARNING:LONG_LINE_COMMENT: line over 90 characters
#10183: FILE: lib/librte_eal/windows/include_override/pthread.h:42:
+ DWORD dwPrevAffinityMask = SetThreadAffinityMask(threadID, 0x1); /* obtain previous mask by setting dummy mask */
WARNING:LONG_LINE: line over 90 characters
#10189: FILE: lib/librte_eal/windows/include_override/pthread.h:48:
+static inline int WinCreateThreadOverride(void* threadID, const void* threadattr, void* threadfunc, void* args)
ERROR:POINTER_LOCATION: "foo* bar" should be "foo *bar"
#10189: FILE: lib/librte_eal/windows/include_override/pthread.h:48:
+static inline int WinCreateThreadOverride(void* threadID, const void* threadattr, void* threadfunc, void* args)
ERROR:POINTER_LOCATION: "foo* bar" should be "foo *bar"
#10189: FILE: lib/librte_eal/windows/include_override/pthread.h:48:
+static inline int WinCreateThreadOverride(void* threadID, const void* threadattr, void* threadfunc, void* args)
ERROR:POINTER_LOCATION: "foo* bar" should be "foo *bar"
#10189: FILE: lib/librte_eal/windows/include_override/pthread.h:48:
+static inline int WinCreateThreadOverride(void* threadID, const void* threadattr, void* threadfunc, void* args)
ERROR:POINTER_LOCATION: "foo* bar" should be "foo *bar"
#10189: FILE: lib/librte_eal/windows/include_override/pthread.h:48:
+static inline int WinCreateThreadOverride(void* threadID, const void* threadattr, void* threadfunc, void* args)
WARNING:LONG_LINE: line over 90 characters
#10192: FILE: lib/librte_eal/windows/include_override/pthread.h:51:
+ hThread = CreateThread(NULL, 0, (LPTHREAD_START_ROUTINE)threadfunc, args, 0, (LPDWORD)threadID);
ERROR:OPEN_BRACE: that open brace { should be on the previous line
#10193: FILE: lib/librte_eal/windows/include_override/pthread.h:52:
+ if (hThread)
+ {
ERROR:POINTER_LOCATION: "foo* bar" should be "foo *bar"
#10201: FILE: lib/librte_eal/windows/include_override/pthread.h:60:
+static inline int pthread_join(void* thread, void **value_ptr)
WARNING:BLOCK_COMMENT_STYLE: Block comments should align the * on each line
#10214: FILE: lib/librte_eal/windows/include_override/rand48.h:2:
+/*
+* Copyright (c) 1993 Martin Birgmeier
WARNING:FUNCTION_ARGUMENTS: function definition argument 'unsigned short' should also have an identifier name
#10232: FILE: lib/librte_eal/windows/include_override/rand48.h:20:
+void _dorand48(unsigned short[3]);
WARNING:BLOCK_COMMENT_STYLE: Block comments should align the * on each line
#10252: FILE: lib/librte_eal/windows/include_override/sched.h:2:
+/* SPDX-License-Identifier: BSD-3-Clause
+* Copyright(c) 2017-2018 Intel Corporation
WARNING:SPACE_BEFORE_TAB: please, no space before tabs
#10441: FILE: lib/librte_eal/windows/include_override/sys/_termios.h:50:
+#define^IVWERASE ^I4^I/* ICANON together with IEXTEN */$
WARNING:SPACE_BEFORE_TAB: please, no space before tabs
#10445: FILE: lib/librte_eal/windows/include_override/sys/_termios.h:54:
+#define^IVREPRINT ^I6^I/* ICANON together with IEXTEN */$
WARNING:SPACE_BEFORE_TAB: please, no space before tabs
#10446: FILE: lib/librte_eal/windows/include_override/sys/_termios.h:55:
+#define^IVERASE2 ^I7^I/* ICANON */$
WARNING:SPACE_BEFORE_TAB: please, no space before tabs
#10549: FILE: lib/librte_eal/windows/include_override/sys/_termios.h:158:
+#define^IECHOCTL ^I0x00000040^I/* echo control chars as ^(Char) */$
WARNING:BLOCK_COMMENT_STYLE: Block comments should align the * on each line
#10741: FILE: lib/librte_eal/windows/include_override/sys/mman.h:2:
+/*
+* sys/mman.h
WARNING:LONG_LINE_COMMENT: line over 90 characters
#10749: FILE: lib/librte_eal/windows/include_override/sys/mman.h:10:
+#define _WIN32_WINNT 0x0501 // Change this to the appropriate value to target other versions of Windows.
WARNING:LONG_LINE: line over 90 characters
#10791: FILE: lib/librte_eal/windows/include_override/sys/mman.h:52:
+ void* mmap(void *addr, size_t len, int prot, int flags, int fildes, OffsetType off);
ERROR:POINTER_LOCATION: "foo* bar" should be "foo *bar"
#10791: FILE: lib/librte_eal/windows/include_override/sys/mman.h:52:
+ void* mmap(void *addr, size_t len, int prot, int flags, int fildes, OffsetType off);
ERROR:SPACING: space required before the open parenthesis '('
#10936: FILE: lib/librte_eal/windows/include_override/sys/netbsd/queue.h:128:
+ for((var) = (head)->slh_first; \
WARNING:SINGLE_STATEMENT_DO_WHILE_MACRO: Single statement macros should not use a do {} while (0) loop
#10949: FILE: lib/librte_eal/windows/include_override/sys/netbsd/queue.h:141:
+#define SLIST_INIT(head) do { \
+ (head)->slh_first = SLIST_END(head); \
+} while (/*CONSTCOND*/0)
WARNING:SINGLE_STATEMENT_DO_WHILE_MACRO: Single statement macros should not use a do {} while (0) loop
#10963: FILE: lib/librte_eal/windows/include_override/sys/netbsd/queue.h:155:
+#define SLIST_REMOVE_AFTER(slistelm, field) do { \
+ (slistelm)->field.sle_next = \
+ SLIST_NEXT(SLIST_NEXT((slistelm), field), field); \
+} while (/*CONSTCOND*/0)
WARNING:SINGLE_STATEMENT_DO_WHILE_MACRO: Single statement macros should not use a do {} while (0) loop
#10968: FILE: lib/librte_eal/windows/include_override/sys/netbsd/queue.h:160:
+#define SLIST_REMOVE_HEAD(head, field) do { \
+ (head)->slh_first = (head)->slh_first->field.sle_next; \
+} while (/*CONSTCOND*/0)
ERROR:SPACING: space required before the open parenthesis '('
#10978: FILE: lib/librte_eal/windows/include_override/sys/netbsd/queue.h:170:
+ while(curelm->field.sle_next != (elm)) \
ERROR:MULTISTATEMENT_MACRO_USE_DO_WHILE: Macros starting with if should be enclosed by a do - while loop to avoid possible if/else logic defects
#11034: FILE: lib/librte_eal/windows/include_override/sys/netbsd/queue.h:226:
+#define QUEUEDEBUG_LIST_INSERT_HEAD(head, elm, field) \
+ if ((head)->lh_first && \
+ (head)->lh_first->field.le_prev != &(head)->lh_first) \
+ QUEUEDEBUG_ABORT("LIST_INSERT_HEAD %p %s:%d", (head), \
+ __FILE__, __LINE__);
WARNING:TRAILING_SEMICOLON: macros should not use a trailing semicolon
#11034: FILE: lib/librte_eal/windows/include_override/sys/netbsd/queue.h:226:
+#define QUEUEDEBUG_LIST_INSERT_HEAD(head, elm, field) \
+ if ((head)->lh_first && \
+ (head)->lh_first->field.le_prev != &(head)->lh_first) \
+ QUEUEDEBUG_ABORT("LIST_INSERT_HEAD %p %s:%d", (head), \
+ __FILE__, __LINE__);
ERROR:MULTISTATEMENT_MACRO_USE_DO_WHILE: Macros starting with if should be enclosed by a do - while loop to avoid possible if/else logic defects
#11039: FILE: lib/librte_eal/windows/include_override/sys/netbsd/queue.h:231:
+#define QUEUEDEBUG_LIST_OP(elm, field) \
+ if ((elm)->field.le_next && \
+ (elm)->field.le_next->field.le_prev != \
+ &(elm)->field.le_next) \
+ QUEUEDEBUG_ABORT("LIST_* forw %p %s:%d", (elm), \
+ __FILE__, __LINE__); \
+ if (*(elm)->field.le_prev != (elm)) \
+ QUEUEDEBUG_ABORT("LIST_* back %p %s:%d", (elm), \
+ __FILE__, __LINE__);
WARNING:TRAILING_SEMICOLON: macros should not use a trailing semicolon
#11039: FILE: lib/librte_eal/windows/include_override/sys/netbsd/queue.h:231:
+#define QUEUEDEBUG_LIST_OP(elm, field) \
+ if ((elm)->field.le_next && \
+ (elm)->field.le_next->field.le_prev != \
+ &(elm)->field.le_next) \
+ QUEUEDEBUG_ABORT("LIST_* forw %p %s:%d", (elm), \
+ __FILE__, __LINE__); \
+ if (*(elm)->field.le_prev != (elm)) \
+ QUEUEDEBUG_ABORT("LIST_* back %p %s:%d", (elm), \
+ __FILE__, __LINE__);
WARNING:TRAILING_SEMICOLON: macros should not use a trailing semicolon
#11048: FILE: lib/librte_eal/windows/include_override/sys/netbsd/queue.h:240:
+#define QUEUEDEBUG_LIST_POSTREMOVE(elm, field) \
+ (elm)->field.le_next = (void *)1L; \
+ (elm)->field.le_prev = (void *)1L;
WARNING:SINGLE_STATEMENT_DO_WHILE_MACRO: Single statement macros should not use a do {} while (0) loop
#11057: FILE: lib/librte_eal/windows/include_override/sys/netbsd/queue.h:249:
+#define LIST_INIT(head) do { \
+ (head)->lh_first = LIST_END(head); \
+} while (/*CONSTCOND*/0)
WARNING:SPACE_BEFORE_TAB: please, no space before tabs
#11063: FILE: lib/librte_eal/windows/include_override/sys/netbsd/queue.h:255:
+^Iif (((elm)->field.le_next = (listelm)->field.le_next) != ^I\$
ERROR:ASSIGN_IN_IF: do not use assignment in if condition
#11063: FILE: lib/librte_eal/windows/include_override/sys/netbsd/queue.h:255:
+ if (((elm)->field.le_next = (listelm)->field.le_next) != \
ERROR:ASSIGN_IN_IF: do not use assignment in if condition
#11081: FILE: lib/librte_eal/windows/include_override/sys/netbsd/queue.h:273:
+ if (((elm)->field.le_next = (head)->lh_first) != LIST_END(head))\
WARNING:SPACE_BEFORE_TAB: please, no space before tabs
#11090: FILE: lib/librte_eal/windows/include_override/sys/netbsd/queue.h:282:
+^I^I(elm)->field.le_next->field.le_prev = ^I^I^I\$
ERROR:ASSIGN_IN_IF: do not use assignment in if condition
#11097: FILE: lib/librte_eal/windows/include_override/sys/netbsd/queue.h:289:
+ if (((elm2)->field.le_next = (elm)->field.le_next) != NULL) \
ERROR:ASSIGN_IN_IF: do not use assignment in if condition
#11150: FILE: lib/librte_eal/windows/include_override/sys/netbsd/queue.h:342:
+ if (((elm)->field.sqe_next = (head)->sqh_first) == NULL) \
ERROR:ASSIGN_IN_IF: do not use assignment in if condition
#11162: FILE: lib/librte_eal/windows/include_override/sys/netbsd/queue.h:354:
+ if (((elm)->field.sqe_next = (listelm)->field.sqe_next) == NULL)\
ERROR:ASSIGN_IN_IF: do not use assignment in if condition
#11168: FILE: lib/librte_eal/windows/include_override/sys/netbsd/queue.h:360:
+ if (((head)->sqh_first = (head)->sqh_first->field.sqe_next) == NULL) \
ERROR:ASSIGN_IN_IF: do not use assignment in if condition
#11173: FILE: lib/librte_eal/windows/include_override/sys/netbsd/queue.h:365:
+ if (((elm)->field.sqe_next = (elm)->field.sqe_next->field.sqe_next) \
WARNING:SUSPECT_CODE_INDENT: suspect code indent for conditional statements (16, 28)
#11185: FILE: lib/librte_eal/windows/include_override/sys/netbsd/queue.h:377:
+ if ((curelm->field.sqe_next = \
[...]
+ (head)->sqh_last = &(curelm)->field.sqe_next; \
ERROR:ASSIGN_IN_IF: do not use assignment in if condition
#11185: FILE: lib/librte_eal/windows/include_override/sys/netbsd/queue.h:377:
+ if ((curelm->field.sqe_next = \
ERROR:CODE_INDENT: code indent should use tabs where possible
#11202: FILE: lib/librte_eal/windows/include_override/sys/netbsd/queue.h:394:
+^I ((struct type *)(void *)^I^I^I^I\$
ERROR:SPACING: space required after that ',' (ctx:VxB)
#11213: FILE: lib/librte_eal/windows/include_override/sys/netbsd/queue.h:405:
+#define TAILQ_HEAD(name, type) _TAILQ_HEAD(name, struct type,)
^
ERROR:SPACING: space required after that ',' (ctx:VxB)
#11223: FILE: lib/librte_eal/windows/include_override/sys/netbsd/queue.h:415:
+#define TAILQ_ENTRY(type) _TAILQ_ENTRY(struct type,)
^
WARNING:SPACE_BEFORE_TAB: please, no space before tabs
#11255: FILE: lib/librte_eal/windows/include_override/sys/netbsd/queue.h:447:
+^I (var) != TAILQ_END(head) && ^I^I^I^I\$
ERROR:MULTISTATEMENT_MACRO_USE_DO_WHILE: Macros starting with if should be enclosed by a do - while loop to avoid possible if/else logic defects
#11262: FILE: lib/librte_eal/windows/include_override/sys/netbsd/queue.h:454:
+#define QUEUEDEBUG_TAILQ_INSERT_HEAD(head, elm, field) \
+ if ((head)->tqh_first && \
+ (head)->tqh_first->field.tqe_prev != &(head)->tqh_first) \
+ QUEUEDEBUG_ABORT("TAILQ_INSERT_HEAD %p %s:%d", (head), \
+ __FILE__, __LINE__);
WARNING:TRAILING_SEMICOLON: macros should not use a trailing semicolon
#11262: FILE: lib/librte_eal/windows/include_override/sys/netbsd/queue.h:454:
+#define QUEUEDEBUG_TAILQ_INSERT_HEAD(head, elm, field) \
+ if ((head)->tqh_first && \
+ (head)->tqh_first->field.tqe_prev != &(head)->tqh_first) \
+ QUEUEDEBUG_ABORT("TAILQ_INSERT_HEAD %p %s:%d", (head), \
+ __FILE__, __LINE__);
ERROR:MULTISTATEMENT_MACRO_USE_DO_WHILE: Macros starting with if should be enclosed by a do - while loop to avoid possible if/else logic defects
#11267: FILE: lib/librte_eal/windows/include_override/sys/netbsd/queue.h:459:
+#define QUEUEDEBUG_TAILQ_INSERT_TAIL(head, elm, field) \
+ if (*(head)->tqh_last != NULL) \
+ QUEUEDEBUG_ABORT("TAILQ_INSERT_TAIL %p %s:%d", (head), \
+ __FILE__, __LINE__);
WARNING:TRAILING_SEMICOLON: macros should not use a trailing semicolon
#11267: FILE: lib/librte_eal/windows/include_override/sys/netbsd/queue.h:459:
+#define QUEUEDEBUG_TAILQ_INSERT_TAIL(head, elm, field) \
+ if (*(head)->tqh_last != NULL) \
+ QUEUEDEBUG_ABORT("TAILQ_INSERT_TAIL %p %s:%d", (head), \
+ __FILE__, __LINE__);
ERROR:MULTISTATEMENT_MACRO_USE_DO_WHILE: Macros starting with if should be enclosed by a do - while loop to avoid possible if/else logic defects
#11271: FILE: lib/librte_eal/windows/include_override/sys/netbsd/queue.h:463:
+#define QUEUEDEBUG_TAILQ_OP(elm, field) \
+ if ((elm)->field.tqe_next && \
+ (elm)->field.tqe_next->field.tqe_prev != \
+ &(elm)->field.tqe_next) \
+ QUEUEDEBUG_ABORT("TAILQ_* forw %p %s:%d", (elm), \
+ __FILE__, __LINE__); \
+ if (*(elm)->field.tqe_prev != (elm)) \
+ QUEUEDEBUG_ABORT("TAILQ_* back %p %s:%d", (elm), \
+ __FILE__, __LINE__);
WARNING:TRAILING_SEMICOLON: macros should not use a trailing semicolon
#11271: FILE: lib/librte_eal/windows/include_override/sys/netbsd/queue.h:463:
+#define QUEUEDEBUG_TAILQ_OP(elm, field) \
+ if ((elm)->field.tqe_next && \
+ (elm)->field.tqe_next->field.tqe_prev != \
+ &(elm)->field.tqe_next) \
+ QUEUEDEBUG_ABORT("TAILQ_* forw %p %s:%d", (elm), \
+ __FILE__, __LINE__); \
+ if (*(elm)->field.tqe_prev != (elm)) \
+ QUEUEDEBUG_ABORT("TAILQ_* back %p %s:%d", (elm), \
+ __FILE__, __LINE__);
ERROR:MULTISTATEMENT_MACRO_USE_DO_WHILE: Macros starting with if should be enclosed by a do - while loop to avoid possible if/else logic defects
#11280: FILE: lib/librte_eal/windows/include_override/sys/netbsd/queue.h:472:
+#define QUEUEDEBUG_TAILQ_PREREMOVE(head, elm, field) \
+ if ((elm)->field.tqe_next == NULL && \
+ (head)->tqh_last != &(elm)->field.tqe_next) \
+ QUEUEDEBUG_ABORT("TAILQ_PREREMOVE head %p elm %p %s:%d",\
+ (head), (elm), __FILE__, __LINE__);
WARNING:TRAILING_SEMICOLON: macros should not use a trailing semicolon
#11280: FILE: lib/librte_eal/windows/include_override/sys/netbsd/queue.h:472:
+#define QUEUEDEBUG_TAILQ_PREREMOVE(head, elm, field) \
+ if ((elm)->field.tqe_next == NULL && \
+ (head)->tqh_last != &(elm)->field.tqe_next) \
+ QUEUEDEBUG_ABORT("TAILQ_PREREMOVE head %p elm %p %s:%d",\
+ (head), (elm), __FILE__, __LINE__);
WARNING:TRAILING_SEMICOLON: macros should not use a trailing semicolon
#11285: FILE: lib/librte_eal/windows/include_override/sys/netbsd/queue.h:477:
+#define QUEUEDEBUG_TAILQ_POSTREMOVE(elm, field) \
+ (elm)->field.tqe_next = (void *)1L; \
+ (elm)->field.tqe_prev = (void *)1L;
ERROR:ASSIGN_IN_IF: do not use assignment in if condition
#11303: FILE: lib/librte_eal/windows/include_override/sys/netbsd/queue.h:495:
+ if (((elm)->field.tqe_next = (head)->tqh_first) != TAILQ_END(head))\
WARNING:SPACE_BEFORE_TAB: please, no space before tabs
#11322: FILE: lib/librte_eal/windows/include_override/sys/netbsd/queue.h:514:
+^Iif (((elm)->field.tqe_next = (listelm)->field.tqe_next) != ^I\$
ERROR:ASSIGN_IN_IF: do not use assignment in if condition
#11322: FILE: lib/librte_eal/windows/include_override/sys/netbsd/queue.h:514:
+ if (((elm)->field.tqe_next = (listelm)->field.tqe_next) != \
WARNING:SPACE_BEFORE_TAB: please, no space before tabs
#11324: FILE: lib/librte_eal/windows/include_override/sys/netbsd/queue.h:516:
+^I^I(elm)->field.tqe_next->field.tqe_prev = ^I^I\$
WARNING:SPACE_BEFORE_TAB: please, no space before tabs
#11344: FILE: lib/librte_eal/windows/include_override/sys/netbsd/queue.h:536:
+^I^I(elm)->field.tqe_next->field.tqe_prev = ^I^I\$
ERROR:CODE_INDENT: code indent should use tabs where possible
#11353: FILE: lib/librte_eal/windows/include_override/sys/netbsd/queue.h:545:
+ if (((elm2)->field.tqe_next = (elm)->field.tqe_next) != ^I\$
WARNING:SPACE_BEFORE_TAB: please, no space before tabs
#11353: FILE: lib/librte_eal/windows/include_override/sys/netbsd/queue.h:545:
+ if (((elm2)->field.tqe_next = (elm)->field.tqe_next) != ^I\$
WARNING:LEADING_SPACE: please, no spaces at the start of a line
#11353: FILE: lib/librte_eal/windows/include_override/sys/netbsd/queue.h:545:
+ if (((elm2)->field.tqe_next = (elm)->field.tqe_next) != ^I\$
ERROR:ASSIGN_IN_IF: do not use assignment in if condition
#11353: FILE: lib/librte_eal/windows/include_override/sys/netbsd/queue.h:545:
+ if (((elm2)->field.tqe_next = (elm)->field.tqe_next) != \
WARNING:SPACE_BEFORE_TAB: please, no space before tabs
#11354: FILE: lib/librte_eal/windows/include_override/sys/netbsd/queue.h:546:
+^I TAILQ_END(head)) ^I^I^I^I^I^I\$
ERROR:CODE_INDENT: code indent should use tabs where possible
#11355: FILE: lib/librte_eal/windows/include_override/sys/netbsd/queue.h:547:
+ (elm2)->field.tqe_next->field.tqe_prev =^I^I\$
WARNING:LEADING_SPACE: please, no spaces at the start of a line
#11355: FILE: lib/librte_eal/windows/include_override/sys/netbsd/queue.h:547:
+ (elm2)->field.tqe_next->field.tqe_prev =^I^I\$
ERROR:CODE_INDENT: code indent should use tabs where possible
#11356: FILE: lib/librte_eal/windows/include_override/sys/netbsd/queue.h:548:
+ &(elm2)->field.tqe_next;^I^I^I^I\$
WARNING:LEADING_SPACE: please, no spaces at the start of a line
#11356: FILE: lib/librte_eal/windows/include_override/sys/netbsd/queue.h:548:
+ &(elm2)->field.tqe_next;^I^I^I^I\$
ERROR:CODE_INDENT: code indent should use tabs where possible
#11357: FILE: lib/librte_eal/windows/include_override/sys/netbsd/queue.h:549:
+ else^I^I^I^I^I^I^I^I\$
WARNING:LEADING_SPACE: please, no spaces at the start of a line
#11357: FILE: lib/librte_eal/windows/include_override/sys/netbsd/queue.h:549:
+ else^I^I^I^I^I^I^I^I\$
ERROR:CODE_INDENT: code indent should use tabs where possible
#11358: FILE: lib/librte_eal/windows/include_override/sys/netbsd/queue.h:550:
+ (head)->tqh_last = &(elm2)->field.tqe_next;^I^I\$
WARNING:LEADING_SPACE: please, no spaces at the start of a line
#11358: FILE: lib/librte_eal/windows/include_override/sys/netbsd/queue.h:550:
+ (head)->tqh_last = &(elm2)->field.tqe_next;^I^I\$
ERROR:CODE_INDENT: code indent should use tabs where possible
#11359: FILE: lib/librte_eal/windows/include_override/sys/netbsd/queue.h:551:
+ (elm2)->field.tqe_prev = (elm)->field.tqe_prev;^I^I^I\$
WARNING:LEADING_SPACE: please, no spaces at the start of a line
#11359: FILE: lib/librte_eal/windows/include_override/sys/netbsd/queue.h:551:
+ (elm2)->field.tqe_prev = (elm)->field.tqe_prev;^I^I^I\$
ERROR:CODE_INDENT: code indent should use tabs where possible
#11360: FILE: lib/librte_eal/windows/include_override/sys/netbsd/queue.h:552:
+ *(elm2)->field.tqe_prev = (elm2);^I^I^I^I\$
WARNING:LEADING_SPACE: please, no spaces at the start of a line
#11360: FILE: lib/librte_eal/windows/include_override/sys/netbsd/queue.h:552:
+ *(elm2)->field.tqe_prev = (elm2);^I^I^I^I\$
ERROR:ASSIGN_IN_IF: do not use assignment in if condition
#11407: FILE: lib/librte_eal/windows/include_override/sys/netbsd/queue.h:599:
+ if (((elm)->field.stqe_next = (head)->stqh_first) == NULL) \
ERROR:ASSIGN_IN_IF: do not use assignment in if condition
#11419: FILE: lib/librte_eal/windows/include_override/sys/netbsd/queue.h:611:
+ if (((elm)->field.stqe_next = (listelm)->field.stqe_next) == NULL)\
ERROR:ASSIGN_IN_IF: do not use assignment in if condition
#11425: FILE: lib/librte_eal/windows/include_override/sys/netbsd/queue.h:617:
+ if (((head)->stqh_first = (head)->stqh_first->field.stqe_next) == NULL) \
WARNING:SUSPECT_CODE_INDENT: suspect code indent for conditional statements (16, 28)
#11436: FILE: lib/librte_eal/windows/include_override/sys/netbsd/queue.h:628:
+ if ((curelm->field.stqe_next = \
[...]
+ (head)->stqh_last = &(curelm)->field.stqe_next; \
ERROR:ASSIGN_IN_IF: do not use assignment in if condition
#11436: FILE: lib/librte_eal/windows/include_override/sys/netbsd/queue.h:628:
+ if ((curelm->field.stqe_next = \
ERROR:CODE_INDENT: code indent should use tabs where possible
#11463: FILE: lib/librte_eal/windows/include_override/sys/netbsd/queue.h:655:
+^I ((struct type *)(void *)^I^I^I^I\$
ERROR:POINTER_LOCATION: "foo * bar" should be "foo *bar"
#11489: FILE: lib/librte_eal/windows/include_override/sys/netbsd/queue.h:681:
+static __inline const void * __launder_type(const void *);
WARNING:INLINE: plain inline is preferred over __inline
#11489: FILE: lib/librte_eal/windows/include_override/sys/netbsd/queue.h:681:
+static __inline const void * __launder_type(const void *);
WARNING:INLINE: plain inline is preferred over __inline
#11490: FILE: lib/librte_eal/windows/include_override/sys/netbsd/queue.h:682:
+static __inline const void *
ERROR:MULTISTATEMENT_MACRO_USE_DO_WHILE: Macros starting with if should be enclosed by a do - while loop to avoid possible if/else logic defects
#11498: FILE: lib/librte_eal/windows/include_override/sys/netbsd/queue.h:690:
+#define QUEUEDEBUG_CIRCLEQ_HEAD(head, field) \
+ if ((head)->cqh_first != CIRCLEQ_ENDC(head) && \
+ (head)->cqh_first->field.cqe_prev != CIRCLEQ_ENDC(head)) \
+ QUEUEDEBUG_ABORT("CIRCLEQ head forw %p %s:%d", (head), \
+ __FILE__, __LINE__); \
+ if ((head)->cqh_last != CIRCLEQ_ENDC(head) && \
+ (head)->cqh_last->field.cqe_next != CIRCLEQ_ENDC(head)) \
+ QUEUEDEBUG_ABORT("CIRCLEQ head back %p %s:%d", (head), \
+ __FILE__, __LINE__);
WARNING:TRAILING_SEMICOLON: macros should not use a trailing semicolon
#11498: FILE: lib/librte_eal/windows/include_override/sys/netbsd/queue.h:690:
+#define QUEUEDEBUG_CIRCLEQ_HEAD(head, field) \
+ if ((head)->cqh_first != CIRCLEQ_ENDC(head) && \
+ (head)->cqh_first->field.cqe_prev != CIRCLEQ_ENDC(head)) \
+ QUEUEDEBUG_ABORT("CIRCLEQ head forw %p %s:%d", (head), \
+ __FILE__, __LINE__); \
+ if ((head)->cqh_last != CIRCLEQ_ENDC(head) && \
+ (head)->cqh_last->field.cqe_next != CIRCLEQ_ENDC(head)) \
+ QUEUEDEBUG_ABORT("CIRCLEQ head back %p %s:%d", (head), \
+ __FILE__, __LINE__);
ERROR:MULTISTATEMENT_MACRO_USE_DO_WHILE: Macros starting with if should be enclosed by a do - while loop to avoid possible if/else logic defects
#11507: FILE: lib/librte_eal/windows/include_override/sys/netbsd/queue.h:699:
+#define QUEUEDEBUG_CIRCLEQ_ELM(head, elm, field) \
+ if ((elm)->field.cqe_next == CIRCLEQ_ENDC(head)) { \
+ if ((head)->cqh_last != (elm)) \
+ QUEUEDEBUG_ABORT("CIRCLEQ elm last %p %s:%d", \
+ (elm), __FILE__, __LINE__); \
+ } else { \
+ if ((elm)->field.cqe_next->field.cqe_prev != (elm)) \
+ QUEUEDEBUG_ABORT("CIRCLEQ elm forw %p %s:%d", \
+ (elm), __FILE__, __LINE__); \
+ } \
+ if ((elm)->field.cqe_prev == CIRCLEQ_ENDC(head)) { \
+ if ((head)->cqh_first != (elm)) \
+ QUEUEDEBUG_ABORT("CIRCLEQ elm first %p %s:%d", \
+ (elm), __FILE__, __LINE__); \
+ } else { \
+ if ((elm)->field.cqe_prev->field.cqe_next != (elm)) \
+ QUEUEDEBUG_ABORT("CIRCLEQ elm prev %p %s:%d", \
+ (elm), __FILE__, __LINE__); \
+ }
WARNING:TRAILING_SEMICOLON: macros should not use a trailing semicolon
#11526: FILE: lib/librte_eal/windows/include_override/sys/netbsd/queue.h:718:
+#define QUEUEDEBUG_CIRCLEQ_POSTREMOVE(elm, field) \
+ (elm)->field.cqe_next = (void *)1L; \
+ (elm)->field.cqe_prev = (void *)1L;
WARNING:LEADING_SPACE: please, no spaces at the start of a line
#11642: FILE: lib/librte_eal/windows/include_override/sys/netbsd/queue.h:834:
+ (CIRCLEQ_FIRST(head) == CIRCLEQ_ENDC(head))$
WARNING:BLOCK_COMMENT_STYLE: Block comments should align the * on each line
#11679: FILE: lib/librte_eal/windows/include_override/syslog.h:2:
+/*
+* Copyright (c) 1982, 1986, 1988, 1993
WARNING:BLOCK_COMMENT_STYLE: Block comments should align the * on each line
#11715: FILE: lib/librte_eal/windows/include_override/syslog.h:38:
+/*
+* priorities/facilities are encoded into a single 32-bit quantity, where the
ERROR:OPEN_BRACE: that open brace { should be on the previous line
#11747: FILE: lib/librte_eal/windows/include_override/syslog.h:70:
+CODE prioritynames[] =
+{
ERROR:OPEN_BRACE: that open brace { should be on the previous line
#11795: FILE: lib/librte_eal/windows/include_override/syslog.h:118:
+CODE facilitynames[] =
+{
WARNING:BLOCK_COMMENT_STYLE: Block comments should align the * on each line
#11823: FILE: lib/librte_eal/windows/include_override/syslog.h:146:
+/*
+* arguments to setlogmask.
WARNING:BLOCK_COMMENT_STYLE: Block comments should align the * on each line
#11829: FILE: lib/librte_eal/windows/include_override/syslog.h:152:
+/*
+* Option flags for openlog.
WARNING:TYPO_SPELLING: 'desriptor' may be misspelled - perhaps 'descriptor'?
#11847: FILE: lib/librte_eal/windows/include_override/syslog.h:170:
+ /* Close desriptor used to write to system logger. */
WARNING:BLOCK_COMMENT_STYLE: Block comments use * on subsequent lines
#11864: FILE: lib/librte_eal/windows/include_override/syslog.h:187:
+ /* Windows specific.
+
WARNING:BLOCK_COMMENT_STYLE: Block comments use * on subsequent lines
#11877: FILE: lib/librte_eal/windows/include_override/syslog.h:200:
+ /* Initializes the syslog library and sets the syslog host. The
+ hostname parameter is of the form "<hostname>[:<port>]". The
ERROR:POINTER_LOCATION: "foo * bar" should be "foo *bar"
#11885: FILE: lib/librte_eal/windows/include_override/syslog.h:208:
+ extern void init_syslog(const char * hostname);
WARNING:BLOCK_COMMENT_STYLE: Block comments should align the * on each line
#11909: FILE: lib/librte_eal/windows/include_override/unistd.h:2:
+/* SPDX-License-Identifier: BSD-3-Clause
+* Copyright(c) 2017-2018 Intel Corporation
WARNING:MISSING_EOF_NEWLINE: adding a line without newline at end of file
#11944: FILE: lib/librte_eal/windows/include_override/x86intrin.h:1:
+#include <intrin.h>
WARNING:BLOCK_COMMENT_STYLE: Block comments should align the * on each line
#11975: FILE: lib/librte_eal/windows/rte_override/rte_atomic.h:2:
+/* SPDX-License-Identifier: BSD-3-Clause
+* Copyright(c) 2017-2018 Intel Corporation
WARNING:LONG_LINE_COMMENT: line over 90 characters
#11983: FILE: lib/librte_eal/windows/rte_override/rte_atomic.h:10:
+/* Do not include any of the core rte_atomic.h includes. They cause compilation problems on Windows */
WARNING:LONG_LINE_COMMENT: line over 90 characters
#11984: FILE: lib/librte_eal/windows/rte_override/rte_atomic.h:11:
+/* Instead, duplicate some of the required definitions here - this is sub-optimal, but... */
WARNING:BLOCK_COMMENT_STYLE: Block comments should align the * on each line
#12000: FILE: lib/librte_eal/windows/rte_override/rte_atomic.h:27:
+/**
+* Compiler barrier.
WARNING:SINGLE_STATEMENT_DO_WHILE_MACRO: Single statement macros should not use a do {} while (0) loop
#12005: FILE: lib/librte_eal/windows/rte_override/rte_atomic.h:32:
+#define rte_compiler_barrier() do { \
+ asm volatile ("" : : : "memory"); \
+} while(0)
ERROR:SPACING: space required before the open parenthesis '('
#12007: FILE: lib/librte_eal/windows/rte_override/rte_atomic.h:34:
+} while(0)
WARNING:BLOCK_COMMENT_STYLE: Block comments should align the * on each line
#12015: FILE: lib/librte_eal/windows/rte_override/rte_atomic.h:42:
+/**
+* Atomic compare and set.
WARNING:LEADING_SPACE: please, no spaces at the start of a line
#12033: FILE: lib/librte_eal/windows/rte_override/rte_atomic.h:60:
+ return (_InterlockedCompareExchange16((SHORT *)dst, src, exp) != src);$
WARNING:BLOCK_COMMENT_STYLE: Block comments should align the * on each line
#12037: FILE: lib/librte_eal/windows/rte_override/rte_atomic.h:64:
+/**
+* The atomic counter structure.
WARNING:LEADING_SPACE: please, no spaces at the start of a line
#12040: FILE: lib/librte_eal/windows/rte_override/rte_atomic.h:67:
+ volatile int16_t cnt; /**< An internal counter value. */$
WARNING:BLOCK_COMMENT_STYLE: Block comments should align the * on each line
#12044: FILE: lib/librte_eal/windows/rte_override/rte_atomic.h:71:
+/**
+* Static initializer for an atomic counter.
WARNING:BLOCK_COMMENT_STYLE: Block comments should align the * on each line
#12049: FILE: lib/librte_eal/windows/rte_override/rte_atomic.h:76:
+/**
+* Initialize an atomic counter.
WARNING:LEADING_SPACE: please, no spaces at the start of a line
#12057: FILE: lib/librte_eal/windows/rte_override/rte_atomic.h:84:
+ v->cnt = 0;$
WARNING:BLOCK_COMMENT_STYLE: Block comments should align the * on each line
#12061: FILE: lib/librte_eal/windows/rte_override/rte_atomic.h:88:
+/**
+* Atomically read a 16-bit value from a counter.
WARNING:LEADING_SPACE: please, no spaces at the start of a line
#12071: FILE: lib/librte_eal/windows/rte_override/rte_atomic.h:98:
+ return v->cnt;$
WARNING:BLOCK_COMMENT_STYLE: Block comments should align the * on each line
#12075: FILE: lib/librte_eal/windows/rte_override/rte_atomic.h:102:
+/**
+* Atomically set a counter to a 16-bit value.
WARNING:LEADING_SPACE: please, no spaces at the start of a line
#12085: FILE: lib/librte_eal/windows/rte_override/rte_atomic.h:112:
+ _InterlockedExchange16(&v->cnt, new_value);$
WARNING:BLOCK_COMMENT_STYLE: Block comments should align the * on each line
#12089: FILE: lib/librte_eal/windows/rte_override/rte_atomic.h:116:
+/**
+* Atomically add a 16-bit value to an atomic counter.
WARNING:LEADING_SPACE: please, no spaces at the start of a line
#12099: FILE: lib/librte_eal/windows/rte_override/rte_atomic.h:126:
+ _InterlockedExchangeAdd16(&v->cnt, inc);$
WARNING:BLOCK_COMMENT_STYLE: Block comments should align the * on each line
#12103: FILE: lib/librte_eal/windows/rte_override/rte_atomic.h:130:
+/**
+* Atomically subtract a 16-bit value from an atomic counter.
WARNING:LEADING_SPACE: please, no spaces at the start of a line
#12113: FILE: lib/librte_eal/windows/rte_override/rte_atomic.h:140:
+ _InterlockedExchangeAdd16(&v->cnt, (-dec));$
WARNING:BLOCK_COMMENT_STYLE: Block comments should align the * on each line
#12117: FILE: lib/librte_eal/windows/rte_override/rte_atomic.h:144:
+/**
+* Atomically increment a counter by one.
WARNING:LEADING_SPACE: please, no spaces at the start of a line
#12125: FILE: lib/librte_eal/windows/rte_override/rte_atomic.h:152:
+ rte_atomic16_add(v, 1);$
WARNING:BLOCK_COMMENT_STYLE: Block comments should align the * on each line
#12129: FILE: lib/librte_eal/windows/rte_override/rte_atomic.h:156:
+/**
+* Atomically decrement a counter by one.
WARNING:LEADING_SPACE: please, no spaces at the start of a line
#12137: FILE: lib/librte_eal/windows/rte_override/rte_atomic.h:164:
+ rte_atomic16_sub(v, 1);$
WARNING:BLOCK_COMMENT_STYLE: Block comments should align the * on each line
#12141: FILE: lib/librte_eal/windows/rte_override/rte_atomic.h:168:
+/**
+* Atomically add a 16-bit value to a counter and return the result.
WARNING:LEADING_SPACE: please, no spaces at the start of a line
#12156: FILE: lib/librte_eal/windows/rte_override/rte_atomic.h:183:
+ _InterlockedExchangeAdd16(&v->cnt, inc);$
WARNING:LEADING_SPACE: please, no spaces at the start of a line
#12157: FILE: lib/librte_eal/windows/rte_override/rte_atomic.h:184:
+ return v->cnt;$
WARNING:BLOCK_COMMENT_STYLE: Block comments should align the * on each line
#12161: FILE: lib/librte_eal/windows/rte_override/rte_atomic.h:188:
+/**
+* Atomically subtract a 16-bit value from a counter and return
WARNING:LEADING_SPACE: please, no spaces at the start of a line
#12177: FILE: lib/librte_eal/windows/rte_override/rte_atomic.h:204:
+ _InterlockedExchangeAdd16(&v->cnt, (-dec));$
WARNING:LEADING_SPACE: please, no spaces at the start of a line
#12178: FILE: lib/librte_eal/windows/rte_override/rte_atomic.h:205:
+ return v->cnt;$
WARNING:BLOCK_COMMENT_STYLE: Block comments should align the * on each line
#12182: FILE: lib/librte_eal/windows/rte_override/rte_atomic.h:209:
+/**
+* Atomically increment a 16-bit counter by one and test.
WARNING:LEADING_SPACE: please, no spaces at the start of a line
#12194: FILE: lib/librte_eal/windows/rte_override/rte_atomic.h:221:
+ return ((rte_atomic16_add_return(v, 1) == 0));$
WARNING:BLOCK_COMMENT_STYLE: Block comments should align the * on each line
#12198: FILE: lib/librte_eal/windows/rte_override/rte_atomic.h:225:
+/**
+* Atomically decrement a 16-bit counter by one and test.
WARNING:LEADING_SPACE: please, no spaces at the start of a line
#12210: FILE: lib/librte_eal/windows/rte_override/rte_atomic.h:237:
+ return ((rte_atomic16_sub_return(v, 1) == 0));$
WARNING:BLOCK_COMMENT_STYLE: Block comments should align the * on each line
#12214: FILE: lib/librte_eal/windows/rte_override/rte_atomic.h:241:
+/**
+* Atomically test and set a 16-bit atomic counter.
WARNING:LEADING_SPACE: please, no spaces at the start of a line
#12226: FILE: lib/librte_eal/windows/rte_override/rte_atomic.h:253:
+ return rte_atomic16_cmpset((volatile uint16_t *)&v->cnt, 0, 1);$
WARNING:BLOCK_COMMENT_STYLE: Block comments should align the * on each line
#12230: FILE: lib/librte_eal/windows/rte_override/rte_atomic.h:257:
+/**
+* Atomically set a 16-bit counter to 0.
WARNING:LEADING_SPACE: please, no spaces at the start of a line
#12237: FILE: lib/librte_eal/windows/rte_override/rte_atomic.h:264:
+ rte_atomic16_set(v, 0);$
WARNING:BLOCK_COMMENT_STYLE: Block comments should align the * on each line
#12243: FILE: lib/librte_eal/windows/rte_override/rte_atomic.h:270:
+/**
+* Atomic compare and set.
WARNING:LEADING_SPACE: please, no spaces at the start of a line
#12261: FILE: lib/librte_eal/windows/rte_override/rte_atomic.h:288:
+ return (_InterlockedCompareExchange(dst, src, exp) != src);$
WARNING:BLOCK_COMMENT_STYLE: Block comments should align the * on each line
#12265: FILE: lib/librte_eal/windows/rte_override/rte_atomic.h:292:
+/**
+* The atomic counter structure.
WARNING:LEADING_SPACE: please, no spaces at the start of a line
#12268: FILE: lib/librte_eal/windows/rte_override/rte_atomic.h:295:
+ volatile int32_t cnt; /**< An internal counter value. */$
WARNING:BLOCK_COMMENT_STYLE: Block comments should align the * on each line
#12272: FILE: lib/librte_eal/windows/rte_override/rte_atomic.h:299:
+/**
+* Static initializer for an atomic counter.
WARNING:BLOCK_COMMENT_STYLE: Block comments should align the * on each line
#12277: FILE: lib/librte_eal/windows/rte_override/rte_atomic.h:304:
+/**
+* Initialize an atomic counter.
WARNING:LEADING_SPACE: please, no spaces at the start of a line
#12285: FILE: lib/librte_eal/windows/rte_override/rte_atomic.h:312:
+ v->cnt = 0;$
WARNING:BLOCK_COMMENT_STYLE: Block comments should align the * on each line
#12289: FILE: lib/librte_eal/windows/rte_override/rte_atomic.h:316:
+/**
+* Atomically read a 32-bit value from a counter.
WARNING:LEADING_SPACE: please, no spaces at the start of a line
#12299: FILE: lib/librte_eal/windows/rte_override/rte_atomic.h:326:
+ return v->cnt;$
WARNING:BLOCK_COMMENT_STYLE: Block comments should align the * on each line
#12303: FILE: lib/librte_eal/windows/rte_override/rte_atomic.h:330:
+/**
+* Atomically set a counter to a 32-bit value.
WARNING:LEADING_SPACE: please, no spaces at the start of a line
#12313: FILE: lib/librte_eal/windows/rte_override/rte_atomic.h:340:
+ _InterlockedExchange((LONG volatile *)&v->cnt, new_value);$
WARNING:BLOCK_COMMENT_STYLE: Block comments should align the * on each line
#12317: FILE: lib/librte_eal/windows/rte_override/rte_atomic.h:344:
+/**
+* Atomically add a 32-bit value to an atomic counter.
WARNING:LEADING_SPACE: please, no spaces at the start of a line
#12327: FILE: lib/librte_eal/windows/rte_override/rte_atomic.h:354:
+ _InterlockedExchangeAdd((LONG volatile *)&v->cnt, inc);$
WARNING:BLOCK_COMMENT_STYLE: Block comments should align the * on each line
#12331: FILE: lib/librte_eal/windows/rte_override/rte_atomic.h:358:
+/**
+* Atomically subtract a 32-bit value from an atomic counter.
WARNING:LEADING_SPACE: please, no spaces at the start of a line
#12341: FILE: lib/librte_eal/windows/rte_override/rte_atomic.h:368:
+ _InterlockedExchangeAdd((LONG volatile *)&v->cnt, (-dec));$
WARNING:BLOCK_COMMENT_STYLE: Block comments should align the * on each line
#12345: FILE: lib/librte_eal/windows/rte_override/rte_atomic.h:372:
+/**
+* Atomically increment a counter by one.
WARNING:LEADING_SPACE: please, no spaces at the start of a line
#12353: FILE: lib/librte_eal/windows/rte_override/rte_atomic.h:380:
+ rte_atomic32_add(v, 1);$
WARNING:BLOCK_COMMENT_STYLE: Block comments should align the * on each line
#12357: FILE: lib/librte_eal/windows/rte_override/rte_atomic.h:384:
+/**
+* Atomically decrement a counter by one.
WARNING:LEADING_SPACE: please, no spaces at the start of a line
#12365: FILE: lib/librte_eal/windows/rte_override/rte_atomic.h:392:
+ rte_atomic32_sub(v, 1);$
WARNING:BLOCK_COMMENT_STYLE: Block comments should align the * on each line
#12369: FILE: lib/librte_eal/windows/rte_override/rte_atomic.h:396:
+/**
+* Atomically add a 32-bit value to a counter and return the result.
WARNING:LEADING_SPACE: please, no spaces at the start of a line
#12384: FILE: lib/librte_eal/windows/rte_override/rte_atomic.h:411:
+ _InterlockedExchangeAdd((LONG volatile *)&v->cnt, inc);$
WARNING:LEADING_SPACE: please, no spaces at the start of a line
#12385: FILE: lib/librte_eal/windows/rte_override/rte_atomic.h:412:
+ return v->cnt;$
WARNING:BLOCK_COMMENT_STYLE: Block comments should align the * on each line
#12389: FILE: lib/librte_eal/windows/rte_override/rte_atomic.h:416:
+/**
+* Atomically subtract a 32-bit value from a counter and return
WARNING:LEADING_SPACE: please, no spaces at the start of a line
#12405: FILE: lib/librte_eal/windows/rte_override/rte_atomic.h:432:
+ _InterlockedExchangeAdd((LONG volatile *)&v->cnt, (-dec));$
WARNING:LEADING_SPACE: please, no spaces at the start of a line
#12406: FILE: lib/librte_eal/windows/rte_override/rte_atomic.h:433:
+ return v->cnt;$
WARNING:BLOCK_COMMENT_STYLE: Block comments should align the * on each line
#12410: FILE: lib/librte_eal/windows/rte_override/rte_atomic.h:437:
+/**
+* Atomically increment a 32-bit counter by one and test.
WARNING:LEADING_SPACE: please, no spaces at the start of a line
#12422: FILE: lib/librte_eal/windows/rte_override/rte_atomic.h:449:
+ return ((rte_atomic32_add_return(v, 1) == 0));$
WARNING:BLOCK_COMMENT_STYLE: Block comments should align the * on each line
#12426: FILE: lib/librte_eal/windows/rte_override/rte_atomic.h:453:
+/**
+* Atomically decrement a 32-bit counter by one and test.
WARNING:LEADING_SPACE: please, no spaces at the start of a line
#12438: FILE: lib/librte_eal/windows/rte_override/rte_atomic.h:465:
+ return ((rte_atomic32_sub_return(v, 1) == 0));$
WARNING:BLOCK_COMMENT_STYLE: Block comments should align the * on each line
#12442: FILE: lib/librte_eal/windows/rte_override/rte_atomic.h:469:
+/**
+* Atomically test and set a 32-bit atomic counter.
WARNING:LEADING_SPACE: please, no spaces at the start of a line
#12454: FILE: lib/librte_eal/windows/rte_override/rte_atomic.h:481:
+ return rte_atomic32_cmpset((volatile uint32_t *)&v->cnt, 0, 1);$
WARNING:BLOCK_COMMENT_STYLE: Block comments should align the * on each line
#12458: FILE: lib/librte_eal/windows/rte_override/rte_atomic.h:485:
+/**
+* Atomically set a 32-bit counter to 0.
WARNING:LEADING_SPACE: please, no spaces at the start of a line
#12465: FILE: lib/librte_eal/windows/rte_override/rte_atomic.h:492:
+ rte_atomic32_set(v, 0);$
WARNING:BLOCK_COMMENT_STYLE: Block comments should align the * on each line
#12471: FILE: lib/librte_eal/windows/rte_override/rte_atomic.h:498:
+/**
+* An atomic compare and set function used by the mutex functions.
WARNING:LEADING_SPACE: please, no spaces at the start of a line
#12488: FILE: lib/librte_eal/windows/rte_override/rte_atomic.h:515:
+ return (_InterlockedCompareExchange64((volatile LONG64 *)dst, src, exp) != src);$
WARNING:BLOCK_COMMENT_STYLE: Block comments should align the * on each line
#12492: FILE: lib/librte_eal/windows/rte_override/rte_atomic.h:519:
+/**
+* Atomic exchange.
ERROR:SPACING: space required before the open brace '{'
#12507: FILE: lib/librte_eal/windows/rte_override/rte_atomic.h:534:
+rte_atomic64_exchange(volatile uint64_t *dst, uint64_t val){
WARNING:BLOCK_COMMENT_STYLE: Block comments should align the * on each line
#12512: FILE: lib/librte_eal/windows/rte_override/rte_atomic.h:539:
+/**
+* The atomic counter structure.
WARNING:LEADING_SPACE: please, no spaces at the start of a line
#12515: FILE: lib/librte_eal/windows/rte_override/rte_atomic.h:542:
+ volatile int64_t cnt; /**< Internal counter value. */$
WARNING:BLOCK_COMMENT_STYLE: Block comments should align the * on each line
#12519: FILE: lib/librte_eal/windows/rte_override/rte_atomic.h:546:
+/**
+* Static initializer for an atomic counter.
WARNING:BLOCK_COMMENT_STYLE: Block comments should align the * on each line
#12524: FILE: lib/librte_eal/windows/rte_override/rte_atomic.h:551:
+/**
+* Initialize the atomic counter.
WARNING:LEADING_SPACE: please, no spaces at the start of a line
#12532: FILE: lib/librte_eal/windows/rte_override/rte_atomic.h:559:
+ v->cnt = 0;$
WARNING:BLOCK_COMMENT_STYLE: Block comments should align the * on each line
#12536: FILE: lib/librte_eal/windows/rte_override/rte_atomic.h:563:
+/**
+* Atomically read a 64-bit counter.
WARNING:LEADING_SPACE: please, no spaces at the start of a line
#12546: FILE: lib/librte_eal/windows/rte_override/rte_atomic.h:573:
+ return v->cnt;$
WARNING:BLOCK_COMMENT_STYLE: Block comments should align the * on each line
#12550: FILE: lib/librte_eal/windows/rte_override/rte_atomic.h:577:
+/**
+* Atomically set a 64-bit counter.
WARNING:LEADING_SPACE: please, no spaces at the start of a line
#12560: FILE: lib/librte_eal/windows/rte_override/rte_atomic.h:587:
+ _InterlockedExchange64(&v->cnt, new_value);$
WARNING:BLOCK_COMMENT_STYLE: Block comments should align the * on each line
#12564: FILE: lib/librte_eal/windows/rte_override/rte_atomic.h:591:
+/**
+* Atomically add a 64-bit value to a counter.
WARNING:LEADING_SPACE: please, no spaces at the start of a line
#12574: FILE: lib/librte_eal/windows/rte_override/rte_atomic.h:601:
+ _InterlockedExchangeAdd64(&v->cnt, inc);$
WARNING:BLOCK_COMMENT_STYLE: Block comments should align the * on each line
#12578: FILE: lib/librte_eal/windows/rte_override/rte_atomic.h:605:
+/**
+* Atomically subtract a 64-bit value from a counter.
WARNING:LEADING_SPACE: please, no spaces at the start of a line
#12588: FILE: lib/librte_eal/windows/rte_override/rte_atomic.h:615:
+ _InterlockedExchangeAdd64(&v->cnt, (-dec));$
WARNING:BLOCK_COMMENT_STYLE: Block comments should align the * on each line
#12592: FILE: lib/librte_eal/windows/rte_override/rte_atomic.h:619:
+/**
+* Atomically increment a 64-bit counter by one and test.
WARNING:LEADING_SPACE: please, no spaces at the start of a line
#12600: FILE: lib/librte_eal/windows/rte_override/rte_atomic.h:627:
+ _InterlockedIncrement64(&v->cnt);$
WARNING:BLOCK_COMMENT_STYLE: Block comments should align the * on each line
#12604: FILE: lib/librte_eal/windows/rte_override/rte_atomic.h:631:
+/**
+* Atomically decrement a 64-bit counter by one and test.
WARNING:LEADING_SPACE: please, no spaces at the start of a line
#12612: FILE: lib/librte_eal/windows/rte_override/rte_atomic.h:639:
+ _InterlockedDecrement64(&v->cnt);$
WARNING:BLOCK_COMMENT_STYLE: Block comments should align the * on each line
#12616: FILE: lib/librte_eal/windows/rte_override/rte_atomic.h:643:
+/**
+* Add a 64-bit value to an atomic counter and return the result.
WARNING:LEADING_SPACE: please, no spaces at the start of a line
#12631: FILE: lib/librte_eal/windows/rte_override/rte_atomic.h:658:
+ _InterlockedExchangeAdd64(&v->cnt, inc);$
WARNING:LEADING_SPACE: please, no spaces at the start of a line
#12632: FILE: lib/librte_eal/windows/rte_override/rte_atomic.h:659:
+ return v->cnt;$
WARNING:BLOCK_COMMENT_STYLE: Block comments should align the * on each line
#12636: FILE: lib/librte_eal/windows/rte_override/rte_atomic.h:663:
+/**
+* Subtract a 64-bit value from an atomic counter and return the result.
WARNING:LEADING_SPACE: please, no spaces at the start of a line
#12651: FILE: lib/librte_eal/windows/rte_override/rte_atomic.h:678:
+ _InterlockedExchangeAdd64(&v->cnt, (-dec));$
WARNING:LEADING_SPACE: please, no spaces at the start of a line
#12652: FILE: lib/librte_eal/windows/rte_override/rte_atomic.h:679:
+ return v->cnt;$
WARNING:BLOCK_COMMENT_STYLE: Block comments should align the * on each line
#12656: FILE: lib/librte_eal/windows/rte_override/rte_atomic.h:683:
+/**
+* Atomically increment a 64-bit counter by one and test.
WARNING:LEADING_SPACE: please, no spaces at the start of a line
#12668: FILE: lib/librte_eal/windows/rte_override/rte_atomic.h:695:
+ return ((rte_atomic64_add_return(v, 1) == 0));$
WARNING:BLOCK_COMMENT_STYLE: Block comments should align the * on each line
#12672: FILE: lib/librte_eal/windows/rte_override/rte_atomic.h:699:
+/**
+* Atomically decrement a 64-bit counter by one and test.
WARNING:LEADING_SPACE: please, no spaces at the start of a line
#12684: FILE: lib/librte_eal/windows/rte_override/rte_atomic.h:711:
+ return ((rte_atomic64_sub_return(v, 1) == 0));$
WARNING:BLOCK_COMMENT_STYLE: Block comments should align the * on each line
#12688: FILE: lib/librte_eal/windows/rte_override/rte_atomic.h:715:
+/**
+* Atomically test and set a 64-bit atomic counter.
WARNING:LEADING_SPACE: please, no spaces at the start of a line
#12700: FILE: lib/librte_eal/windows/rte_override/rte_atomic.h:727:
+ return rte_atomic64_cmpset((volatile uint64_t *)&v->cnt, 0, 1);$
WARNING:BLOCK_COMMENT_STYLE: Block comments should align the * on each line
#12704: FILE: lib/librte_eal/windows/rte_override/rte_atomic.h:731:
+/**
+* Atomically set a 64-bit counter to 0.
WARNING:LEADING_SPACE: please, no spaces at the start of a line
#12711: FILE: lib/librte_eal/windows/rte_override/rte_atomic.h:738:
+ rte_atomic64_set(v, 0);$
WARNING:BLOCK_COMMENT_STYLE: Block comments should align the * on each line
#12725: FILE: lib/librte_eal/windows/rte_override/rte_bus_pci.h:2:
+/* SPDX-License-Identifier: BSD-3-Clause
+* Copyright(c) 2017-2018 Intel Corporation
WARNING:BLOCK_COMMENT_STYLE: Block comments should align the * on each line
#12739: FILE: lib/librte_eal/windows/rte_override/rte_bus_pci.h:16:
+/*
+* Definition for registering PMDs
WARNING:BLOCK_COMMENT_STYLE: Block comments should align the * on each line
#12756: FILE: lib/librte_eal/windows/rte_override/rte_byteorder.h:2:
+/* SPDX-License-Identifier: BSD-3-Clause
+* Copyright(c) 2017-2018 Intel Corporation
WARNING:MISSING_EOF_NEWLINE: adding a line without newline at end of file
#12764: FILE: lib/librte_eal/windows/rte_override/rte_byteorder.h:10:
+#include "..\..
parent reply other threads:[~2018-11-29 11:15 UTC|newest]
Thread overview: expand[flat|nested] mbox.gz Atom feed
[parent not found: <20181129050504.26996-1-pallavi.kadam@intel.com>]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20181129111537.72BF61B4B6@dpdk.org \
--to=checkpatch@dpdk.org \
--cc=pallavi.kadam@intel.com \
--cc=test-report@dpdk.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).