From: checkpatch@dpdk.org
To: test-report@dpdk.org
Cc: Wenzhuo Lu <wenzhuo.lu@intel.com>
Subject: [dpdk-test-report] |WARNING| pw48471 [v2, 02/20] net/ice: support device initialization
Date: Thu, 6 Dec 2018 18:40:51 +0100 (CET) [thread overview]
Message-ID: <20181206174051.7E8966833@dpdk.org> (raw)
In-Reply-To: <1543820821-108122-3-git-send-email-wenzhuo.lu@intel.com>
Test-Label: checkpatch
Test-Status: WARNING
http://dpdk.org/patch/48471
_coding style issues_
WARNING:COMMIT_MESSAGE: Missing commit description - Add an appropriate one
CHECK:BOOL_MEMBER: Avoid using bool structure members because of possible alignment issues - see: https://lkml.org/lkml/2017/11/21/384
#1032: FILE: drivers/net/ice/ice_ethdev.h:225:
+ bool offset_loaded;
CHECK:BOOL_MEMBER: Avoid using bool structure members because of possible alignment issues - see: https://lkml.org/lkml/2017/11/21/384
#1058: FILE: drivers/net/ice/ice_ethdev.h:251:
+ bool offset_loaded;
CHECK:BOOL_MEMBER: Avoid using bool structure members because of possible alignment issues - see: https://lkml.org/lkml/2017/11/21/384
#1059: FILE: drivers/net/ice/ice_ethdev.h:252:
+ bool adapter_stopped;
CHECK:BOOL_MEMBER: Avoid using bool structure members because of possible alignment issues - see: https://lkml.org/lkml/2017/11/21/384
#1070: FILE: drivers/net/ice/ice_ethdev.h:263:
+ bool rx_bulk_alloc_allowed;
CHECK:BOOL_MEMBER: Avoid using bool structure members because of possible alignment issues - see: https://lkml.org/lkml/2017/11/21/384
#1071: FILE: drivers/net/ice/ice_ethdev.h:264:
+ bool tx_simple_allowed;
WARNING:MACRO_WITH_FLOW_CONTROL: Macros with flow control statements should be avoided
#1118: FILE: drivers/net/ice/ice_ethdev.h:311:
+#define ICE_PROC_SECONDARY_CHECK \
+ do { \
+ if (rte_eal_process_type() == RTE_PROC_SECONDARY) { \
+ PMD_DRV_LOG(ERR, \
+ "Control plane functions not " \
+ "supported by secondary process."); \
+ return -E_RTE_SECONDARY; \
+ } \
+ } while (0)
WARNING:MACRO_WITH_FLOW_CONTROL: Macros with flow control statements should be avoided
#1128: FILE: drivers/net/ice/ice_ethdev.h:321:
+#define ICE_PROC_SECONDARY_CHECK_RET_0 \
+ do { \
+ if (rte_eal_process_type() == RTE_PROC_SECONDARY) { \
+ PMD_DRV_LOG(ERR, \
+ "Control plane functions not " \
+ "supported by secondary process."); \
+ return 0; \
+ } \
+ } while (0)
WARNING:MACRO_WITH_FLOW_CONTROL: Macros with flow control statements should be avoided
#1138: FILE: drivers/net/ice/ice_ethdev.h:331:
+#define ICE_PROC_SECONDARY_CHECK_NO_ERR \
+ do { \
+ if (rte_eal_process_type() == RTE_PROC_SECONDARY) { \
+ PMD_DRV_LOG(ERR, \
+ "Control plane functions not " \
+ "supported by secondary process."); \
+ return; \
+ } \
+ } while (0)
CHECK:BOOL_MEMBER: Avoid using bool structure members because of possible alignment issues - see: https://lkml.org/lkml/2017/11/21/384
#1274: FILE: drivers/net/ice/ice_rxtx.h:62:
+ bool q_set; /* indicate if rx queue has been configured */
CHECK:BOOL_MEMBER: Avoid using bool structure members because of possible alignment issues - see: https://lkml.org/lkml/2017/11/21/384
#1275: FILE: drivers/net/ice/ice_rxtx.h:63:
+ bool rx_deferred_start; /* don't start this queue in dev start */
CHECK:BOOL_MEMBER: Avoid using bool structure members because of possible alignment issues - see: https://lkml.org/lkml/2017/11/21/384
#1313: FILE: drivers/net/ice/ice_rxtx.h:101:
+ bool tx_deferred_start; /* don't start this queue in dev start */
CHECK:BOOL_MEMBER: Avoid using bool structure members because of possible alignment issues - see: https://lkml.org/lkml/2017/11/21/384
#1314: FILE: drivers/net/ice/ice_rxtx.h:102:
+ bool q_set; /* indicate if tx queue has been configured */
total: 0 errors, 4 warnings, 1261 lines checked
parent reply other threads:[~2018-12-06 17:40 UTC|newest]
Thread overview: expand[flat|nested] mbox.gz Atom feed
[parent not found: <1543820821-108122-3-git-send-email-wenzhuo.lu@intel.com>]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20181206174051.7E8966833@dpdk.org \
--to=checkpatch@dpdk.org \
--cc=test-report@dpdk.org \
--cc=wenzhuo.lu@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).