* [dpdk-test-report] |WARNING| pw48550 net-i40e-Match-on-outer-and-inner-headers-for-tunnel
[not found] <1544008393-72281-1-git-send-email-subarna.kar@intel.com>
@ 2018-12-06 17:42 ` checkpatch
0 siblings, 0 replies; only message in thread
From: checkpatch @ 2018-12-06 17:42 UTC (permalink / raw)
To: test-report; +Cc: subarna.kar
Test-Label: checkpatch
Test-Status: WARNING
http://dpdk.org/patch/48550
_coding style issues_
CHECK:BOOL_MEMBER: Avoid using bool structure members because of possible alignment issues - see: https://lkml.org/lkml/2017/11/21/384
#213: FILE: drivers/net/i40e/i40e_ethdev.h:636:
+ bool tunnel; /*if its tunnel pkts, then allow inner headers. */
CHECK:CAMELCASE: Avoid CamelCase: <I40E_TUNNEL_TYPE_MPLSoUDP>
#224: FILE: drivers/net/i40e/i40e_ethdev.h:859:
+ I40E_TUNNEL_TYPE_MPLSoUDP,
CHECK:CAMELCASE: Avoid CamelCase: <ETHER_TYPE_IPv4>
#281: FILE: drivers/net/i40e/i40e_fdir.c:976:
+ *ether_type = rte_cpu_to_be_16(ETHER_TYPE_IPv4);
CHECK:CAMELCASE: Avoid CamelCase: <ETHER_TYPE_IPv6>
#300: FILE: drivers/net/i40e/i40e_fdir.c:995:
+ *ether_type = rte_cpu_to_be_16(ETHER_TYPE_IPv6);
CHECK:CAMELCASE: Avoid CamelCase: <I40E_FDIR_IPv6_DEFAULT_VTC_FLOW>
#302: FILE: drivers/net/i40e/i40e_fdir.c:997:
+ rte_cpu_to_be_32(I40E_FDIR_IPv6_DEFAULT_VTC_FLOW);
CHECK:CAMELCASE: Avoid CamelCase: <I40E_FDIR_IPv6_PAYLOAD_LEN>
#304: FILE: drivers/net/i40e/i40e_fdir.c:999:
+ rte_cpu_to_be_16(I40E_FDIR_IPv6_PAYLOAD_LEN);
CHECK:CAMELCASE: Avoid CamelCase: <I40E_FDIR_IPv6_DEFAULT_HOP_LIMITS>
#306: FILE: drivers/net/i40e/i40e_fdir.c:1001:
+ I40E_FDIR_IPv6_DEFAULT_HOP_LIMITS;
CHECK:CAMELCASE: Avoid CamelCase: <I40E_FDIR_IPv6_TC_OFFSET>
#568: FILE: drivers/net/i40e/i40e_fdir.c:1291:
+ I40E_FDIR_IPv6_TC_OFFSET));
WARNING:LONG_LINE: line over 90 characters
#1081: FILE: drivers/net/i40e/i40e_flow.c:2701:
+ filter->input.flow.mplsudp4_flow.inner_udp.ip.dst_ip =
WARNING:LONG_LINE: line over 90 characters
#1083: FILE: drivers/net/i40e/i40e_flow.c:2703:
+ filter->input.flow.mplsudp4_flow.inner_udp.ip.src_ip =
WARNING:LONG_LINE: line over 90 characters
#1085: FILE: drivers/net/i40e/i40e_flow.c:2705:
+ filter->input.flow.mplsudp4_flow.inner_udp.ip.proto =
WARNING:LONG_LINE: line over 90 characters
#1091: FILE: drivers/net/i40e/i40e_flow.c:2711:
+ filter->input.flow.mpls6udp4_flow.inner_udp.ip.dst_ip =
WARNING:LONG_LINE: line over 90 characters
#1093: FILE: drivers/net/i40e/i40e_flow.c:2713:
+ filter->input.flow.mpls6udp4_flow.inner_udp.ip.src_ip =
WARNING:LONG_LINE: line over 90 characters
#1095: FILE: drivers/net/i40e/i40e_flow.c:2715:
+ filter->input.flow.mpls6udp4_flow.inner_udp.ip.proto =
WARNING:LONG_LINE: line over 90 characters
#1101: FILE: drivers/net/i40e/i40e_flow.c:2721:
+ filter->input.flow.vxlanudp4_flow.inner_udp.ip.dst_ip =
WARNING:LONG_LINE: line over 90 characters
#1103: FILE: drivers/net/i40e/i40e_flow.c:2723:
+ filter->input.flow.vxlanudp4_flow.inner_udp.ip.src_ip =
WARNING:LONG_LINE: line over 90 characters
#1105: FILE: drivers/net/i40e/i40e_flow.c:2725:
+ filter->input.flow.vxlanudp4_flow.inner_udp.ip.proto =
WARNING:LONG_LINE: line over 90 characters
#1109: FILE: drivers/net/i40e/i40e_flow.c:2729:
+ filter->input.flow.vxlan6udp4_flow.inner_udp.ip.dst_ip =
WARNING:LONG_LINE: line over 90 characters
#1111: FILE: drivers/net/i40e/i40e_flow.c:2731:
+ filter->input.flow.vxlan6udp4_flow.inner_udp.ip.src_ip =
WARNING:LONG_LINE: line over 90 characters
#1113: FILE: drivers/net/i40e/i40e_flow.c:2733:
+ filter->input.flow.vxlan6udp4_flow.inner_udp.ip.proto =
WARNING:LONG_LINE: line over 90 characters
#1146: FILE: drivers/net/i40e/i40e_flow.c:2766:
+ rte_memcpy(filter->input.flow.mpls6udp4_flow.outer6_udp.ip.dst_ip,
WARNING:LONG_LINE: line over 90 characters
#1191: FILE: drivers/net/i40e/i40e_flow.c:2811:
+ filter->input.flow.mplsudp6_flow.inner6_udp.ip.proto =
WARNING:LONG_LINE: line over 90 characters
#1193: FILE: drivers/net/i40e/i40e_flow.c:2813:
+ rte_memcpy(filter->input.flow.mplsudp6_flow.inner6_udp.ip.src_ip,
WARNING:LONG_LINE: line over 90 characters
#1195: FILE: drivers/net/i40e/i40e_flow.c:2815:
+ rte_memcpy(filter->input.flow.mplsudp6_flow.inner6_udp.ip.dst_ip,
WARNING:LONG_LINE: line over 90 characters
#1201: FILE: drivers/net/i40e/i40e_flow.c:2821:
+ filter->input.flow.mpls6udp6_flow.inner6_udp.ip.proto =
WARNING:LONG_LINE: line over 90 characters
#1203: FILE: drivers/net/i40e/i40e_flow.c:2823:
+ rte_memcpy(filter->input.flow.mpls6udp6_flow.inner6_udp.ip.src_ip,
WARNING:LONG_LINE: line over 90 characters
#1205: FILE: drivers/net/i40e/i40e_flow.c:2825:
+ rte_memcpy(filter->input.flow.mpls6udp6_flow.inner6_udp.ip.dst_ip,
WARNING:LONG_LINE: line over 90 characters
#1211: FILE: drivers/net/i40e/i40e_flow.c:2831:
+ filter->input.flow.vxlanudp6_flow.inner6_udp.ip.proto =
WARNING:LONG_LINE: line over 90 characters
#1213: FILE: drivers/net/i40e/i40e_flow.c:2833:
+ rte_memcpy(filter->input.flow.vxlanudp6_flow.inner6_udp.ip.src_ip,
WARNING:LONG_LINE: line over 90 characters
#1215: FILE: drivers/net/i40e/i40e_flow.c:2835:
+ rte_memcpy(filter->input.flow.vxlanudp6_flow.inner6_udp.ip.dst_ip,
WARNING:LONG_LINE: line over 90 characters
#1219: FILE: drivers/net/i40e/i40e_flow.c:2839:
+ filter->input.flow.vxlan6udp6_flow.inner6_udp.ip.proto =
WARNING:LONG_LINE: line over 90 characters
#1221: FILE: drivers/net/i40e/i40e_flow.c:2841:
+ rte_memcpy(filter->input.flow.vxlan6udp6_flow.inner6_udp.ip.src_ip,
WARNING:LONG_LINE: line over 90 characters
#1223: FILE: drivers/net/i40e/i40e_flow.c:2843:
+ rte_memcpy(filter->input.flow.vxlan6udp6_flow.inner6_udp.ip.dst_ip,
WARNING:LONG_LINE: line over 90 characters
#1254: FILE: drivers/net/i40e/i40e_flow.c:2874:
+ filter->input.flow.mplsgre4_flow.outer_gre.gre.protocol =
WARNING:LONG_LINE: line over 90 characters
#1257: FILE: drivers/net/i40e/i40e_flow.c:2877:
+ filter->input.flow.mpls6gre4_flow.outer6_gre.gre.protocol =
WARNING:LONG_LINE: line over 90 characters
#1293: FILE: drivers/net/i40e/i40e_flow.c:2913:
+ filter->input.flow.mplsudp4_flow.outer_udp.dst_port =
WARNING:LONG_LINE: line over 90 characters
#1296: FILE: drivers/net/i40e/i40e_flow.c:2916:
+ filter->input.flow.mpls6udp4_flow.outer6_udp.dst_port =
WARNING:LONG_LINE: line over 90 characters
#1334: FILE: drivers/net/i40e/i40e_flow.c:2954:
+ filter->input.flow.mplsudp4_flow.inner_udp.dst_port =
WARNING:LONG_LINE: line over 90 characters
#1336: FILE: drivers/net/i40e/i40e_flow.c:2956:
+ filter->input.flow.mplsudp4_flow.inner_udp.src_port =
WARNING:LONG_LINE: line over 90 characters
#1341: FILE: drivers/net/i40e/i40e_flow.c:2961:
+ filter->input.flow.mpls6udp4_flow.inner_udp.dst_port =
WARNING:LONG_LINE: line over 90 characters
#1343: FILE: drivers/net/i40e/i40e_flow.c:2963:
+ filter->input.flow.mpls6udp4_flow.inner_udp.src_port =
WARNING:LONG_LINE: line over 90 characters
#1348: FILE: drivers/net/i40e/i40e_flow.c:2968:
+ filter->input.flow.mplsudp6_flow.inner6_udp.dst_port =
WARNING:LONG_LINE: line over 90 characters
#1350: FILE: drivers/net/i40e/i40e_flow.c:2970:
+ filter->input.flow.mplsudp6_flow.inner6_udp.src_port =
WARNING:LONG_LINE: line over 90 characters
#1353: FILE: drivers/net/i40e/i40e_flow.c:2973:
+ filter->input.flow.mpls6udp6_flow.inner6_udp.dst_port =
WARNING:LONG_LINE: line over 90 characters
#1355: FILE: drivers/net/i40e/i40e_flow.c:2975:
+ filter->input.flow.mpls6udp6_flow.inner6_udp.src_port =
WARNING:LONG_LINE: line over 90 characters
#1362: FILE: drivers/net/i40e/i40e_flow.c:2982:
+ filter->input.flow.vxlanudp4_flow.inner_udp.dst_port =
WARNING:LONG_LINE: line over 90 characters
#1364: FILE: drivers/net/i40e/i40e_flow.c:2984:
+ filter->input.flow.vxlanudp4_flow.inner_udp.src_port =
WARNING:LONG_LINE: line over 90 characters
#1369: FILE: drivers/net/i40e/i40e_flow.c:2989:
+ filter->input.flow.vxlan6udp4_flow.inner_udp.dst_port =
WARNING:LONG_LINE: line over 90 characters
#1371: FILE: drivers/net/i40e/i40e_flow.c:2991:
+ filter->input.flow.vxlan6udp4_flow.inner_udp.src_port =
WARNING:LONG_LINE: line over 90 characters
#1376: FILE: drivers/net/i40e/i40e_flow.c:2996:
+ filter->input.flow.vxlanudp6_flow.inner6_udp.dst_port =
WARNING:LONG_LINE: line over 90 characters
#1378: FILE: drivers/net/i40e/i40e_flow.c:2998:
+ filter->input.flow.vxlanudp6_flow.inner6_udp.src_port =
WARNING:LONG_LINE: line over 90 characters
#1381: FILE: drivers/net/i40e/i40e_flow.c:3001:
+ filter->input.flow.vxlan6udp6_flow.inner6_udp.dst_port =
WARNING:LONG_LINE: line over 90 characters
#1383: FILE: drivers/net/i40e/i40e_flow.c:3003:
+ filter->input.flow.vxlan6udp6_flow.inner6_udp.src_port =
WARNING:UNNECESSARY_ELSE: else is not generally useful after a break or return
#1402: FILE: drivers/net/i40e/i40e_flow.c:3022:
+ return -rte_errno;
+ } else {
WARNING:LONG_LINE: line over 90 characters
#1407: FILE: drivers/net/i40e/i40e_flow.c:3027:
+ filter->input.flow.mplsudp4_flow.mpls.label_tc_s[0] =
WARNING:LONG_LINE: line over 90 characters
#1409: FILE: drivers/net/i40e/i40e_flow.c:3029:
+ filter->input.flow.mplsudp4_flow.mpls.label_tc_s[1] =
WARNING:LONG_LINE: line over 90 characters
#1411: FILE: drivers/net/i40e/i40e_flow.c:3031:
+ filter->input.flow.mplsudp4_flow.mpls.label_tc_s[2] =
WARNING:LONG_LINE: line over 90 characters
#1415: FILE: drivers/net/i40e/i40e_flow.c:3035:
+ filter->input.flow.mpls6udp4_flow.mpls.label_tc_s[0] =
WARNING:LONG_LINE: line over 90 characters
#1417: FILE: drivers/net/i40e/i40e_flow.c:3037:
+ filter->input.flow.mpls6udp4_flow.mpls.label_tc_s[1] =
WARNING:LONG_LINE: line over 90 characters
#1419: FILE: drivers/net/i40e/i40e_flow.c:3039:
+ filter->input.flow.mpls6udp4_flow.mpls.label_tc_s[2] =
WARNING:UNNECESSARY_ELSE: else is not generally useful after a break or return
#1451: FILE: drivers/net/i40e/i40e_flow.c:3071:
+ return -rte_errno;
+ } else {
CHECK:BOOL_COMPARISON: Using comparison to true is error prone
#1606: FILE: drivers/net/i40e/i40e_flow.c:5387:
+ rss == true) {
WARNING:UNNECESSARY_ELSE: else is not generally useful after a break or return
#1610: FILE: drivers/net/i40e/i40e_flow.c:5391:
+ return ret;
+ } else {
ERROR:MISSING_SIGN_OFF: Missing Signed-off-by: line(s)
total: 1 errors, 54 warnings, 9 checks, 1539 lines checked
^ permalink raw reply [flat|nested] only message in thread
only message in thread, other threads:[~2018-12-06 17:42 UTC | newest]
Thread overview: (only message) (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
[not found] <1544008393-72281-1-git-send-email-subarna.kar@intel.com>
2018-12-06 17:42 ` [dpdk-test-report] |WARNING| pw48550 net-i40e-Match-on-outer-and-inner-headers-for-tunnel checkpatch
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).