automatic DPDK test reports
 help / color / mirror / Atom feed
From: checkpatch@dpdk.org
To: test-report@dpdk.org
Cc: Zhirun Yan <zhirun.yan@intel.com>
Subject: [dpdk-test-report] |WARNING| pw48610 [v3] net/i40e: fix VF/PF port close
Date: Mon, 10 Dec 2018 07:12:23 +0100 (CET)	[thread overview]
Message-ID: <20181210061223.C82D14F9A@dpdk.org> (raw)
In-Reply-To: <20181210134802.70759-1-zhirun.yan@intel.com>

Test-Label: checkpatch
Test-Status: WARNING
http://dpdk.org/patch/48610

_coding style issues_


WARNING:TYPO_SPELLING: 'stoped' may be misspelled - perhaps 'stopped'?
#21: 
close. So it will never call i40evf_dev_close() after stoped the port.

CHECK:BOOL_MEMBER: Avoid using bool structure members because of possible alignment issues - see: https://lkml.org/lkml/2017/11/21/384
#44: FILE: drivers/net/i40e/base/i40e_type.h:673:
+	bool adapter_closed;

WARNING:LEADING_SPACE: please, no spaces at the start of a line
#74: FILE: drivers/net/i40e/i40e_ethdev.c:2528:
+    hw->adapter_closed = 1;$

WARNING:LEADING_SPACE: please, no spaces at the start of a line
#103: FILE: drivers/net/i40e/i40e_ethdev_vf.c:2264:
+    hw->adapter_closed = 1;$

total: 0 errors, 3 warnings, 1 checks, 52 lines checked

           reply	other threads:[~2018-12-10  6:12 UTC|newest]

Thread overview: expand[flat|nested]  mbox.gz  Atom feed
 [parent not found: <20181210134802.70759-1-zhirun.yan@intel.com>]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20181210061223.C82D14F9A@dpdk.org \
    --to=checkpatch@dpdk.org \
    --cc=test-report@dpdk.org \
    --cc=zhirun.yan@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).