From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: by dpdk.org (Postfix, from userid 1017) id 6F0261B4B7; Thu, 13 Dec 2018 09:24:51 +0100 (CET) In-Reply-To: <1544689402-175655-1-git-send-email-nikhil.rao@intel.com> References: <1544689402-175655-1-git-send-email-nikhil.rao@intel.com> To: test-report@dpdk.org Cc: Nikhil Rao Message-Id: <20181213082451.6F0261B4B7@dpdk.org> Date: Thu, 13 Dec 2018 09:24:51 +0100 (CET) From: checkpatch@dpdk.org Subject: [dpdk-test-report] |WARNING| pw48746 [v2] eventdev: fix eth Tx adapter queue count checks X-BeenThere: test-report@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: automatic DPDK test reports List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 13 Dec 2018 08:24:51 -0000 Test-Label: checkpatch Test-Status: WARNING http://dpdk.org/patch/48746 _coding style issues_ WARNING:MACRO_WITH_FLOW_CONTROL: Macros with flow control statements should be avoided #44: FILE: lib/librte_eventdev/rte_event_eth_tx_adapter.c:62: +#define TXA_CHECK_TXQ(dev, queue) \ +do {\ + if ((dev)->data->nb_tx_queues == 0) { \ + RTE_EDEV_LOG_ERR("No tx queues configured"); \ + return -EINVAL; \ + } \ + if (queue != -1 && (uint16_t)queue >= (dev)->data->nb_tx_queues) { \ + RTE_EDEV_LOG_ERR("Invalid tx queue_id %" PRIu16, \ + (uint16_t)queue); \ + return -EINVAL; \ + } \ +} while (0) total: 0 errors, 1 warnings, 84 lines checked