* [dpdk-test-report] |WARNING| pw48860 [01/20] net/ena: update ena_com for the ENAv2
[not found] <20181214131846.22439-2-mk@semihalf.com>
@ 2018-12-14 13:19 ` checkpatch
0 siblings, 0 replies; only message in thread
From: checkpatch @ 2018-12-14 13:19 UTC (permalink / raw)
To: test-report; +Cc: Michal Krawczyk
Test-Label: checkpatch
Test-Status: WARNING
http://dpdk.org/patch/48860
_coding style issues_
WARNING:LONG_LINE: line over 90 characters
#124: FILE: drivers/net/ena/base/ena_com.c:373:
+ io_sq->bounce_buf_ctrl.buffer_size = ena_dev->llq_info.desc_list_entry_size;
WARNING:LONG_LINE: line over 90 characters
#128: FILE: drivers/net/ena/base/ena_com.c:377:
+ size = io_sq->bounce_buf_ctrl.buffer_size * io_sq->bounce_buf_ctrl.buffers_num;
WARNING:LONG_LINE: line over 90 characters
#140: FILE: drivers/net/ena/base/ena_com.c:385:
+ io_sq->bounce_buf_ctrl.base_buffer = ENA_MEM_ALLOC(ena_dev->dmadev, size);
WARNING:LONG_LINE: line over 90 characters
#259: FILE: drivers/net/ena/base/ena_com.c:661:
+ llq_info->desc_stride_ctrl = ENA_ADMIN_MULTIPLE_DESCS_PER_ENTRY;
WARNING:LONG_LINE: line over 90 characters
#261: FILE: drivers/net/ena/base/ena_com.c:663:
+ llq_info->desc_stride_ctrl = ENA_ADMIN_SINGLE_DESC_PER_ENTRY;
WARNING:LONG_LINE: line over 90 characters
#281: FILE: drivers/net/ena/base/ena_com.c:683:
+ llq_info->desc_list_entry_size_ctrl = llq_default_cfg->llq_ring_entry_size;
WARNING:LONG_LINE: line over 90 characters
#282: FILE: drivers/net/ena/base/ena_com.c:684:
+ llq_info->desc_list_entry_size = llq_default_cfg->llq_ring_entry_size_value;
WARNING:LONG_LINE: line over 90 characters
#285: FILE: drivers/net/ena/base/ena_com.c:687:
+ llq_info->desc_list_entry_size_ctrl = ENA_ADMIN_LIST_ENTRY_SIZE_128B;
WARNING:LONG_LINE: line over 90 characters
#288: FILE: drivers/net/ena/base/ena_com.c:690:
+ llq_info->desc_list_entry_size_ctrl = ENA_ADMIN_LIST_ENTRY_SIZE_192B;
WARNING:LONG_LINE: line over 90 characters
#291: FILE: drivers/net/ena/base/ena_com.c:693:
+ llq_info->desc_list_entry_size_ctrl = ENA_ADMIN_LIST_ENTRY_SIZE_256B;
WARNING:LONG_LINE: line over 90 characters
#294: FILE: drivers/net/ena/base/ena_com.c:696:
+ ena_trc_err("Invalid entry_size_ctrl, supported: 0x%x
", supported_feat);
WARNING:LONG_LINE: line over 90 characters
#321: FILE: drivers/net/ena/base/ena_com.c:723:
+ llq_info->descs_num_before_header = llq_default_cfg->llq_num_decs_before_header;
WARNING:LONG_LINE: line over 90 characters
#324: FILE: drivers/net/ena/base/ena_com.c:726:
+ llq_info->descs_num_before_header = ENA_ADMIN_LLQ_NUM_DESCS_BEFORE_HEADER_2;
WARNING:LONG_LINE: line over 90 characters
#326: FILE: drivers/net/ena/base/ena_com.c:728:
+ llq_info->descs_num_before_header = ENA_ADMIN_LLQ_NUM_DESCS_BEFORE_HEADER_1;
WARNING:LONG_LINE: line over 90 characters
#328: FILE: drivers/net/ena/base/ena_com.c:730:
+ llq_info->descs_num_before_header = ENA_ADMIN_LLQ_NUM_DESCS_BEFORE_HEADER_4;
WARNING:LONG_LINE: line over 90 characters
#330: FILE: drivers/net/ena/base/ena_com.c:732:
+ llq_info->descs_num_before_header = ENA_ADMIN_LLQ_NUM_DESCS_BEFORE_HEADER_8;
WARNING:LONG_LINE: line over 90 characters
#345: FILE: drivers/net/ena/base/ena_com.c:747:
+ (u16)(llq_features->max_tx_burst_size / llq_default_cfg->llq_ring_entry_size_value);
WARNING:LONG_LINE: line over 90 characters
#400: FILE: drivers/net/ena/base/ena_com.c:943:
+ size = io_sq->llq_info.desc_list_entry_size * ENA_COM_BOUNCE_BUFFER_CNTRL_CNT;
CHECK:BOOL_MEMBER: Avoid using bool structure members because of possible alignment issues - see: https://lkml.org/lkml/2017/11/21/384
#902: FILE: drivers/net/ena/base/ena_com.h:143:
+ bool inline_header;
WARNING:LONG_LINE: line over 90 characters
#1066: FILE: drivers/net/ena/base/ena_com.h:1135:
+static inline u8 *ena_com_get_next_bounce_buffer(struct ena_com_io_bounce_buffer_control *bounce_buf_ctrl)
WARNING:SPACING: space prohibited before semicolon
#1626: FILE: drivers/net/ena/base/ena_defs/ena_admin_defs.h:903:
+ } ;
WARNING:LONG_LINE: line over 90 characters
#1650: FILE: drivers/net/ena/base/ena_defs/ena_admin_defs.h:936:
+ struct ena_admin_get_extra_properties_strings_desc extra_properties_strings;
WARNING:LONG_LINE: line over 90 characters
#1853: FILE: drivers/net/ena/base/ena_defs/ena_admin_defs.h:1516:
+static inline uint32_t get_ena_admin_host_info_module_type(const struct ena_admin_host_info *p)
WARNING:LONG_LINE: line over 90 characters
#1855: FILE: drivers/net/ena/base/ena_defs/ena_admin_defs.h:1518:
+ return (p->driver_version & ENA_ADMIN_HOST_INFO_MODULE_TYPE_MASK) >> ENA_ADMIN_HOST_INFO_MODULE_TYPE_SHIFT;
WARNING:LONG_LINE: line over 90 characters
#1858: FILE: drivers/net/ena/base/ena_defs/ena_admin_defs.h:1521:
+static inline void set_ena_admin_host_info_module_type(struct ena_admin_host_info *p, uint32_t val)
WARNING:LONG_LINE: line over 90 characters
#1860: FILE: drivers/net/ena/base/ena_defs/ena_admin_defs.h:1523:
+ p->driver_version |= (val << ENA_ADMIN_HOST_INFO_MODULE_TYPE_SHIFT) & ENA_ADMIN_HOST_INFO_MODULE_TYPE_MASK;
WARNING:LONG_LINE: line over 90 characters
#1863: FILE: drivers/net/ena/base/ena_defs/ena_admin_defs.h:1526:
+static inline uint16_t get_ena_admin_host_info_function(const struct ena_admin_host_info *p)
WARNING:LONG_LINE: line over 90 characters
#1868: FILE: drivers/net/ena/base/ena_defs/ena_admin_defs.h:1531:
+static inline void set_ena_admin_host_info_function(struct ena_admin_host_info *p, uint16_t val)
WARNING:LONG_LINE: line over 90 characters
#1875: FILE: drivers/net/ena/base/ena_defs/ena_admin_defs.h:1538:
+ return (p->bdf & ENA_ADMIN_HOST_INFO_DEVICE_MASK) >> ENA_ADMIN_HOST_INFO_DEVICE_SHIFT;
WARNING:LONG_LINE: line over 90 characters
#1878: FILE: drivers/net/ena/base/ena_defs/ena_admin_defs.h:1541:
+static inline void set_ena_admin_host_info_device(struct ena_admin_host_info *p, uint16_t val)
WARNING:LONG_LINE: line over 90 characters
#1880: FILE: drivers/net/ena/base/ena_defs/ena_admin_defs.h:1543:
+ p->bdf |= (val << ENA_ADMIN_HOST_INFO_DEVICE_SHIFT) & ENA_ADMIN_HOST_INFO_DEVICE_MASK;
WARNING:LONG_LINE: line over 90 characters
#1888: FILE: drivers/net/ena/base/ena_defs/ena_admin_defs.h:1551:
+static inline void set_ena_admin_host_info_bus(struct ena_admin_host_info *p, uint16_t val)
WARNING:LONG_LINE: line over 90 characters
#1893: FILE: drivers/net/ena/base/ena_defs/ena_admin_defs.h:1556:
+static inline uint8_t get_ena_admin_feature_rss_ind_table_one_entry_update(const struct ena_admin_feature_rss_ind_table *p)
WARNING:LONG_LINE: line over 90 characters
#1898: FILE: drivers/net/ena/base/ena_defs/ena_admin_defs.h:1561:
+static inline void set_ena_admin_feature_rss_ind_table_one_entry_update(struct ena_admin_feature_rss_ind_table *p, uint8_t val)
WARNING:LONG_LINE: line over 90 characters
#2214: FILE: drivers/net/ena/base/ena_defs/ena_eth_io_defs.h:857:
+static inline uint32_t get_ena_eth_io_rx_cdesc_base_l4_csum_checked(const struct ena_eth_io_rx_cdesc_base *p)
WARNING:LONG_LINE: line over 90 characters
#2216: FILE: drivers/net/ena/base/ena_defs/ena_eth_io_defs.h:859:
+ return (p->status & ENA_ETH_IO_RX_CDESC_BASE_L4_CSUM_CHECKED_MASK) >> ENA_ETH_IO_RX_CDESC_BASE_L4_CSUM_CHECKED_SHIFT;
WARNING:LONG_LINE: line over 90 characters
#2219: FILE: drivers/net/ena/base/ena_defs/ena_eth_io_defs.h:862:
+static inline void set_ena_eth_io_rx_cdesc_base_l4_csum_checked(struct ena_eth_io_rx_cdesc_base *p, uint32_t val)
WARNING:LONG_LINE: line over 90 characters
#2221: FILE: drivers/net/ena/base/ena_defs/ena_eth_io_defs.h:864:
+ p->status |= (val << ENA_ETH_IO_RX_CDESC_BASE_L4_CSUM_CHECKED_SHIFT) & ENA_ETH_IO_RX_CDESC_BASE_L4_CSUM_CHECKED_MASK;
WARNING:LONG_LINE: line over 90 characters
#2770: FILE: drivers/net/ena/base/ena_eth_com.c:266:
+ last = (READ_ONCE32(cdesc->status) & ENA_ETH_IO_RX_CDESC_BASE_LAST_MASK) >>
CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses around 'io_sq->mem_queue_type == ENA_ADMIN_PLACEMENT_POLICY_DEV'
#2884: FILE: drivers/net/ena/base/ena_eth_com.c:453:
+ if (unlikely((io_sq->mem_queue_type == ENA_ADMIN_PLACEMENT_POLICY_DEV)
+ && !buffer_to_push))
CHECK:LOGICAL_CONTINUATIONS: Logical continuations should be on the previous line
#2885: FILE: drivers/net/ena/base/ena_eth_com.c:454:
+ if (unlikely((io_sq->mem_queue_type == ENA_ADMIN_PLACEMENT_POLICY_DEV)
+ && !buffer_to_push))
CHECK:BOOL_MEMBER: Avoid using bool structure members because of possible alignment issues - see: https://lkml.org/lkml/2017/11/21/384
#3029: FILE: drivers/net/ena/base/ena_eth_com.h:74:
+ bool l4_csum_checked;
WARNING:MEMORY_BARRIER: memory barrier without comment
#3241: FILE: drivers/net/ena/base/ena_plat_dpdk.h:280:
+#define dma_rmb() rmb()
CHECK:MACRO_ARG_PRECEDENCE: Macro argument 'timeout' may be better as '(timeout)' to avoid precedence issues
#3254: FILE: drivers/net/ena/base/ena_plat_dpdk.h:293:
+#define ENA_TIME_EXPIRE(timeout) (timeout < rte_get_timer_cycles())
CHECK:MACRO_ARG_PRECEDENCE: Macro argument 'timeout_us' may be better as '(timeout_us)' to avoid precedence issues
#3255: FILE: drivers/net/ena/base/ena_plat_dpdk.h:294:
+#define ENA_GET_SYSTEM_TIMEOUT(timeout_us) \
+ (timeout_us * rte_get_timer_hz() / 1000000 + rte_get_timer_cycles())
WARNING:LEADING_SPACE: please, no spaces at the start of a line
#3256: FILE: drivers/net/ena/base/ena_plat_dpdk.h:295:
+ (timeout_us * rte_get_timer_hz() / 1000000 + rte_get_timer_cycles())$
ERROR:SPACING: space required before the open parenthesis '('
#3276: FILE: drivers/net/ena/base/ena_plat_dpdk.h:315:
+ } while(0)
CHECK:MACRO_ARG_REUSE: Macro argument reuse 'd' - possible side-effects?
#3278: FILE: drivers/net/ena/base/ena_plat_dpdk.h:317:
+#define DIV_ROUND_UP(n, d) (((n) + (d) - 1) / (d))
total: 1 errors, 40 warnings, 7 checks, 3086 lines checked
^ permalink raw reply [flat|nested] only message in thread
only message in thread, other threads:[~2018-12-14 13:19 UTC | newest]
Thread overview: (only message) (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
[not found] <20181214131846.22439-2-mk@semihalf.com>
2018-12-14 13:19 ` [dpdk-test-report] |WARNING| pw48860 [01/20] net/ena: update ena_com for the ENAv2 checkpatch
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).