From: checkpatch@dpdk.org
To: test-report@dpdk.org
Cc: Liang Ma <liang.j.ma@intel.com>
Subject: [dpdk-test-report] |WARNING| pw49189 [v4] libs/power: add p-state driver compatibility
Date: Thu, 20 Dec 2018 15:43:57 +0100 (CET) [thread overview]
Message-ID: <20181220144357.94FEF1BD41@dpdk.org> (raw)
In-Reply-To: <1545317022-3939-1-git-send-email-liang.j.ma@intel.com>
Test-Label: checkpatch
Test-Status: WARNING
http://dpdk.org/patch/49189
_coding style issues_
WARNING:SINGLE_STATEMENT_DO_WHILE_MACRO: Single statement macros should not use a do {} while (0) loop
#112: FILE: lib/librte_power/power_pstate_cpufreq.c:25:
+#define POWER_DEBUG_TRACE(fmt, args...) do { \
+ RTE_LOG(ERR, POWER, "%s: " fmt, __func__, ## args); \
+} while (0)
WARNING:MACRO_WITH_FLOW_CONTROL: Macros with flow control statements should be avoided
#119: FILE: lib/librte_power/power_pstate_cpufreq.c:32:
+#define FOPEN_OR_ERR_RET(f, retval) do { \
+ if ((f) == NULL) { \
+ RTE_LOG(ERR, POWER, "File not openned
"); \
+ return retval; \
+ } \
+} while (0)
WARNING:MACRO_WITH_FLOW_CONTROL: Macros with flow control statements should be avoided
#126: FILE: lib/librte_power/power_pstate_cpufreq.c:39:
+#define FOPS_OR_NULL_GOTO(ret, label) do { \
+ if ((ret) == NULL) { \
+ RTE_LOG(ERR, POWER, "fgets returns nothing
"); \
+ goto label; \
+ } \
+} while (0)
WARNING:MACRO_WITH_FLOW_CONTROL: Macros with flow control statements should be avoided
#133: FILE: lib/librte_power/power_pstate_cpufreq.c:46:
+#define FOPS_OR_ERR_GOTO(ret, label) do { \
+ if ((ret) < 0) { \
+ RTE_LOG(ERR, POWER, "File operations failed
"); \
+ goto label; \
+ } \
+} while (0)
total: 0 errors, 4 warnings, 1111 lines checked
parent reply other threads:[~2018-12-20 14:43 UTC|newest]
Thread overview: expand[flat|nested] mbox.gz Atom feed
[parent not found: <1545317022-3939-1-git-send-email-liang.j.ma@intel.com>]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20181220144357.94FEF1BD41@dpdk.org \
--to=checkpatch@dpdk.org \
--cc=liang.j.ma@intel.com \
--cc=test-report@dpdk.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).