From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <checkpatch@dpdk.org>
Received: by dpdk.org (Postfix, from userid 1017)
 id 94FEF1BD41; Thu, 20 Dec 2018 15:43:57 +0100 (CET)
In-Reply-To: <1545317022-3939-1-git-send-email-liang.j.ma@intel.com>
References: <1545317022-3939-1-git-send-email-liang.j.ma@intel.com>
To: test-report@dpdk.org
Cc: Liang Ma <liang.j.ma@intel.com>
Message-Id: <20181220144357.94FEF1BD41@dpdk.org>
Date: Thu, 20 Dec 2018 15:43:57 +0100 (CET)
From: checkpatch@dpdk.org
Subject: [dpdk-test-report] |WARNING| pw49189 [v4] libs/power: add p-state
	driver compatibility
X-BeenThere: test-report@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: automatic DPDK test reports <test-report.dpdk.org>
List-Unsubscribe: <https://mails.dpdk.org/options/test-report>,
 <mailto:test-report-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://mails.dpdk.org/archives/test-report/>
List-Post: <mailto:test-report@dpdk.org>
List-Help: <mailto:test-report-request@dpdk.org?subject=help>
List-Subscribe: <https://mails.dpdk.org/listinfo/test-report>,
 <mailto:test-report-request@dpdk.org?subject=subscribe>
X-List-Received-Date: Thu, 20 Dec 2018 14:43:57 -0000

Test-Label: checkpatch
Test-Status: WARNING
http://dpdk.org/patch/49189

_coding style issues_


WARNING:SINGLE_STATEMENT_DO_WHILE_MACRO: Single statement macros should not use a do {} while (0) loop
#112: FILE: lib/librte_power/power_pstate_cpufreq.c:25:
+#define POWER_DEBUG_TRACE(fmt, args...) do { \
+		RTE_LOG(ERR, POWER, "%s: " fmt, __func__, ## args); \
+} while (0)

WARNING:MACRO_WITH_FLOW_CONTROL: Macros with flow control statements should be avoided
#119: FILE: lib/librte_power/power_pstate_cpufreq.c:32:
+#define FOPEN_OR_ERR_RET(f, retval) do { \
+		if ((f) == NULL) { \
+			RTE_LOG(ERR, POWER, "File not openned
"); \
+			return retval; \
+		} \
+} while (0)

WARNING:MACRO_WITH_FLOW_CONTROL: Macros with flow control statements should be avoided
#126: FILE: lib/librte_power/power_pstate_cpufreq.c:39:
+#define FOPS_OR_NULL_GOTO(ret, label) do { \
+		if ((ret) == NULL) { \
+			RTE_LOG(ERR, POWER, "fgets returns nothing
"); \
+			goto label; \
+		} \
+} while (0)

WARNING:MACRO_WITH_FLOW_CONTROL: Macros with flow control statements should be avoided
#133: FILE: lib/librte_power/power_pstate_cpufreq.c:46:
+#define FOPS_OR_ERR_GOTO(ret, label) do { \
+		if ((ret) < 0) { \
+			RTE_LOG(ERR, POWER, "File operations failed
"); \
+			goto label; \
+		} \
+} while (0)

total: 0 errors, 4 warnings, 1111 lines checked