From: checkpatch@dpdk.org
To: test-report@dpdk.org
Cc: David Zeng <zengxiaoh81@gmail.com>
Subject: [dpdk-test-report] |WARNING| pw49245 kni: fix build on RHEL8 and RHEL7.6-ALT
Date: Fri, 21 Dec 2018 17:16:28 +0100 (CET) [thread overview]
Message-ID: <20181221161628.62DB71BE7F@dpdk.org> (raw)
In-Reply-To: <1545408927-72528-2-git-send-email-zengxhsh@cn.ibm.com>
Test-Label: checkpatch
Test-Status: WARNING
http://dpdk.org/patch/49245
_coding style issues_
WARNING:COMMIT_MESSAGE: Missing commit description - Add an appropriate one
WARNING:CONSTANT_COMPARISON: Comparisons should place the constant on the right side of the test
#37: FILE: kernel/linux/kni/compat.h:111:
+ (RHEL_RELEASE_CODE >= RHEL_RELEASE_VERSION(7, 5)) && \
WARNING:CONSTANT_COMPARISON: Comparisons should place the constant on the right side of the test
#38: FILE: kernel/linux/kni/compat.h:112:
+ (RHEL_RELEASE_CODE < RHEL_RELEASE_VERSION(8, 0)) && \
WARNING:CONSTANT_COMPARISON: Comparisons should place the constant on the right side of the test
#39: FILE: kernel/linux/kni/compat.h:113:
+ (LINUX_VERSION_CODE < KERNEL_VERSION(4, 14, 0)))
WARNING:CONSTANT_COMPARISON: Comparisons should place the constant on the right side of the test
#52: FILE: kernel/linux/kni/ethtool/igb/kcompat.h:3933:
+ (RHEL_RELEASE_CODE >= RHEL_RELEASE_VERSION(7, 5)) && \
ERROR:CODE_INDENT: code indent should use tabs where possible
#53: FILE: kernel/linux/kni/ethtool/igb/kcompat.h:3934:
+ (RHEL_RELEASE_CODE < RHEL_RELEASE_VERSION(8, 0)) && \$
WARNING:LEADING_SPACE: please, no spaces at the start of a line
#53: FILE: kernel/linux/kni/ethtool/igb/kcompat.h:3934:
+ (RHEL_RELEASE_CODE < RHEL_RELEASE_VERSION(8, 0)) && \$
WARNING:CONSTANT_COMPARISON: Comparisons should place the constant on the right side of the test
#53: FILE: kernel/linux/kni/ethtool/igb/kcompat.h:3934:
+ (RHEL_RELEASE_CODE < RHEL_RELEASE_VERSION(8, 0)) && \
ERROR:CODE_INDENT: code indent should use tabs where possible
#54: FILE: kernel/linux/kni/ethtool/igb/kcompat.h:3935:
+ (LINUX_VERSION_CODE < KERNEL_VERSION(4, 14, 0)))$
WARNING:LEADING_SPACE: please, no spaces at the start of a line
#54: FILE: kernel/linux/kni/ethtool/igb/kcompat.h:3935:
+ (LINUX_VERSION_CODE < KERNEL_VERSION(4, 14, 0)))$
WARNING:CONSTANT_COMPARISON: Comparisons should place the constant on the right side of the test
#54: FILE: kernel/linux/kni/ethtool/igb/kcompat.h:3935:
+ (LINUX_VERSION_CODE < KERNEL_VERSION(4, 14, 0)))
WARNING:NO_AUTHOR_SIGN_OFF: Missing Signed-off-by: line by nominal patch author 'David Zeng <zengxiaoh81@gmail.com>'
total: 2 errors, 10 warnings, 26 lines checked
parent reply other threads:[~2018-12-21 16:16 UTC|newest]
Thread overview: expand[flat|nested] mbox.gz Atom feed
[parent not found: <1545408927-72528-2-git-send-email-zengxhsh@cn.ibm.com>]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20181221161628.62DB71BE7F@dpdk.org \
--to=checkpatch@dpdk.org \
--cc=test-report@dpdk.org \
--cc=zengxiaoh81@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).