From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <checkpatch@dpdk.org>
Received: by dpdk.org (Postfix, from userid 1017)
 id 62DB71BE7F; Fri, 21 Dec 2018 17:16:28 +0100 (CET)
In-Reply-To: <1545408927-72528-2-git-send-email-zengxhsh@cn.ibm.com>
References: <1545408927-72528-2-git-send-email-zengxhsh@cn.ibm.com>
To: test-report@dpdk.org
Cc: David Zeng <zengxiaoh81@gmail.com>
Message-Id: <20181221161628.62DB71BE7F@dpdk.org>
Date: Fri, 21 Dec 2018 17:16:28 +0100 (CET)
From: checkpatch@dpdk.org
Subject: [dpdk-test-report] |WARNING| pw49245 kni: fix build on RHEL8 and
	RHEL7.6-ALT
X-BeenThere: test-report@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: automatic DPDK test reports <test-report.dpdk.org>
List-Unsubscribe: <https://mails.dpdk.org/options/test-report>,
 <mailto:test-report-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://mails.dpdk.org/archives/test-report/>
List-Post: <mailto:test-report@dpdk.org>
List-Help: <mailto:test-report-request@dpdk.org?subject=help>
List-Subscribe: <https://mails.dpdk.org/listinfo/test-report>,
 <mailto:test-report-request@dpdk.org?subject=subscribe>
X-List-Received-Date: Fri, 21 Dec 2018 16:16:28 -0000

Test-Label: checkpatch
Test-Status: WARNING
http://dpdk.org/patch/49245

_coding style issues_


WARNING:COMMIT_MESSAGE: Missing commit description - Add an appropriate one

WARNING:CONSTANT_COMPARISON: Comparisons should place the constant on the right side of the test
#37: FILE: kernel/linux/kni/compat.h:111:
+	(RHEL_RELEASE_CODE >= RHEL_RELEASE_VERSION(7, 5)) && \

WARNING:CONSTANT_COMPARISON: Comparisons should place the constant on the right side of the test
#38: FILE: kernel/linux/kni/compat.h:112:
+	(RHEL_RELEASE_CODE < RHEL_RELEASE_VERSION(8, 0)) && \

WARNING:CONSTANT_COMPARISON: Comparisons should place the constant on the right side of the test
#39: FILE: kernel/linux/kni/compat.h:113:
+	(LINUX_VERSION_CODE < KERNEL_VERSION(4, 14, 0)))

WARNING:CONSTANT_COMPARISON: Comparisons should place the constant on the right side of the test
#52: FILE: kernel/linux/kni/ethtool/igb/kcompat.h:3933:
+	(RHEL_RELEASE_CODE >= RHEL_RELEASE_VERSION(7, 5)) && \

ERROR:CODE_INDENT: code indent should use tabs where possible
#53: FILE: kernel/linux/kni/ethtool/igb/kcompat.h:3934:
+        (RHEL_RELEASE_CODE < RHEL_RELEASE_VERSION(8, 0)) && \$

WARNING:LEADING_SPACE: please, no spaces at the start of a line
#53: FILE: kernel/linux/kni/ethtool/igb/kcompat.h:3934:
+        (RHEL_RELEASE_CODE < RHEL_RELEASE_VERSION(8, 0)) && \$

WARNING:CONSTANT_COMPARISON: Comparisons should place the constant on the right side of the test
#53: FILE: kernel/linux/kni/ethtool/igb/kcompat.h:3934:
+        (RHEL_RELEASE_CODE < RHEL_RELEASE_VERSION(8, 0)) && \

ERROR:CODE_INDENT: code indent should use tabs where possible
#54: FILE: kernel/linux/kni/ethtool/igb/kcompat.h:3935:
+        (LINUX_VERSION_CODE < KERNEL_VERSION(4, 14, 0)))$

WARNING:LEADING_SPACE: please, no spaces at the start of a line
#54: FILE: kernel/linux/kni/ethtool/igb/kcompat.h:3935:
+        (LINUX_VERSION_CODE < KERNEL_VERSION(4, 14, 0)))$

WARNING:CONSTANT_COMPARISON: Comparisons should place the constant on the right side of the test
#54: FILE: kernel/linux/kni/ethtool/igb/kcompat.h:3935:
+        (LINUX_VERSION_CODE < KERNEL_VERSION(4, 14, 0)))

WARNING:NO_AUTHOR_SIGN_OFF: Missing Signed-off-by: line by nominal patch author 'David Zeng <zengxiaoh81@gmail.com>'

total: 2 errors, 10 warnings, 26 lines checked