From: checkpatch@dpdk.org
To: test-report@dpdk.org
Cc: Cristian Dumitrescu <cristian.dumitrescu@intel.com>
Subject: [dpdk-test-report] |WARNING| pw49578 [v2] net/softnic: add support for service cores
Date: Thu, 10 Jan 2019 12:37:17 +0100 (CET) [thread overview]
Message-ID: <20190110113717.D02671B63D@dpdk.org> (raw)
In-Reply-To: <20190110113647.117569-1-cristian.dumitrescu@intel.com>
Test-Label: checkpatch
Test-Status: WARNING
http://dpdk.org/patch/49578
_coding style issues_
WARNING:COMMIT_MESSAGE: Missing commit description - Add an appropriate one
CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses around 'pipeline->enabled'
#151: FILE: drivers/net/softnic/rte_eth_softnic_pipeline.c:118:
+ if ((pipeline->enabled) && (pipeline->thread_id == thread_id))
CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses around 'pipeline->thread_id == thread_id'
#151: FILE: drivers/net/softnic/rte_eth_softnic_pipeline.c:118:
+ if ((pipeline->enabled) && (pipeline->thread_id == thread_id))
CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses around 'thread_id >= RTE_MAX_LCORE'
#200: FILE: drivers/net/softnic/rte_eth_softnic_thread.c:105:
+ if ((thread_id >= RTE_MAX_LCORE) ||
+ (thread_id == cfg->master_lcore))
CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses around 'thread_id == cfg->master_lcore'
#200: FILE: drivers/net/softnic/rte_eth_softnic_thread.c:105:
+ if ((thread_id >= RTE_MAX_LCORE) ||
+ (thread_id == cfg->master_lcore))
CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses around 'role == ROLE_SERVICE'
#206: FILE: drivers/net/softnic/rte_eth_softnic_thread.c:111:
+ if ((softnic->params.sc && (role == ROLE_SERVICE)) ||
+ (!softnic->params.sc && (role == ROLE_RTE)))
CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses around 'role == ROLE_RTE'
#206: FILE: drivers/net/softnic/rte_eth_softnic_thread.c:111:
+ if ((softnic->params.sc && (role == ROLE_SERVICE)) ||
+ (!softnic->params.sc && (role == ROLE_RTE)))
CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses around 'p == NULL'
#308: FILE: drivers/net/softnic/rte_eth_softnic_thread.c:301:
+ if (!thread_is_valid(softnic, thread_id) ||
(p == NULL) ||
(p->n_ports_in == 0) ||
(p->n_ports_out == 0) ||
+ (p->n_tables == 0) ||
+ p->enabled)
CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses around 'p->n_ports_in == 0'
#308: FILE: drivers/net/softnic/rte_eth_softnic_thread.c:301:
+ if (!thread_is_valid(softnic, thread_id) ||
(p == NULL) ||
(p->n_ports_in == 0) ||
(p->n_ports_out == 0) ||
+ (p->n_tables == 0) ||
+ p->enabled)
CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses around 'p->n_ports_out == 0'
#308: FILE: drivers/net/softnic/rte_eth_softnic_thread.c:301:
+ if (!thread_is_valid(softnic, thread_id) ||
(p == NULL) ||
(p->n_ports_in == 0) ||
(p->n_ports_out == 0) ||
+ (p->n_tables == 0) ||
+ p->enabled)
CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses around 'p->n_tables == 0'
#308: FILE: drivers/net/softnic/rte_eth_softnic_thread.c:301:
+ if (!thread_is_valid(softnic, thread_id) ||
(p == NULL) ||
(p->n_ports_in == 0) ||
(p->n_ports_out == 0) ||
+ (p->n_tables == 0) ||
+ p->enabled)
CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses around 'n_pipelines == 0'
#324: FILE: drivers/net/softnic/rte_eth_softnic_thread.c:313:
+ if (softnic->params.sc && (n_pipelines == 0)) {
CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses around 'p == NULL'
#357: FILE: drivers/net/softnic/rte_eth_softnic_thread.c:395:
+ if (!thread_is_valid(softnic, thread_id) ||
+ (p == NULL) ||
+ (p->enabled && (p->thread_id != thread_id)))
CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses around 'p->thread_id != thread_id'
#357: FILE: drivers/net/softnic/rte_eth_softnic_thread.c:395:
+ if (!thread_is_valid(softnic, thread_id) ||
+ (p == NULL) ||
+ (p->enabled && (p->thread_id != thread_id)))
CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses around 'td->n_pipelines == 0'
#375: FILE: drivers/net/softnic/rte_eth_softnic_thread.c:432:
+ if (softnic->params.sc && (td->n_pipelines == 0))
CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses around 'n_pipelines == 0'
#386: FILE: drivers/net/softnic/rte_eth_softnic_thread.c:465:
+ if (softnic->params.sc && (n_pipelines == 0))
total: 0 errors, 1 warnings, 15 checks, 370 lines checked
parent reply other threads:[~2019-01-10 11:37 UTC|newest]
Thread overview: expand[flat|nested] mbox.gz Atom feed
[parent not found: <20190110113647.117569-1-cristian.dumitrescu@intel.com>]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190110113717.D02671B63D@dpdk.org \
--to=checkpatch@dpdk.org \
--cc=cristian.dumitrescu@intel.com \
--cc=test-report@dpdk.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).